Because of Bedrock limitations, if a player has text background opacity enabled, they'll see an empty section where the title is usually displayed as the fake cooldown is shown. This commit minimizes the time that is shown by clearing the text as soon as possible. Reference issue: https://github.com/GeyserMC/Geyser/issues/1710
This commit also removes starting the fake cooldown process if the client switches to an inventory slot with the same Java ID.
This reduces computation processing needing, since Bedrock doesn't have any hover text ability. This also fixes a 1.8 bug where villager titles would not process correctly - by having a dummy serializer, a recent MCProtocolLib update would not stop the window packet from processing.
By simulating the exact processing that Java Edition does on the client-side, we can achieve full packet parity with Java when interacting with an entity.
These changes fix up things that were missed with Java Edition inventory changes in 1.17 and 1.17.1. Working with the inventory in modern versions should be much nicer.
Previously we've had discussions on if the render distance math should be tweaked like we do server -> client, but for now this is better than nothing and can be tweaked further in the future.
* Fix ArrayIndexOutOfBoundsException for worlds lower than -64
`chunkSize` is Java section count while `sectionCount` is the Bedrock section count
* Send biomes for air sections while also staying within limits
.-.
* Move protocol version check to variable
- Introduce a state ID incrementation emulation. This prevents the server from spamming back with tons of set content packets, and can instead reply with set slot packets.
- Fix what we were sending as a carried item in the ServerboundContainerClickPacket.
* Fix sneaking speed adjustment and bounding box
Also remove redundant session variable in SessionPlayerEntity
* Add comment to valid field
* Hopefully fix crawling after swimming in water
* Prevent boats from floating when a Bedrock player rides in the back
* Update llama and shulker mount height offset
* Fix Trader llama mount offset
* Change passengers to an IntList
Also move rotation lock stuff to EntityUtils
* Allow EntityCache.getEntityByJavaId to return the session's player
Removes many checks from several translators.
* Fix mount offset on armorstands and area effect clouds
Also prevent area effect clouds from despawning when used as an invisible entity (used in GSit to offset players riding on other players)
* Update mount offsets on height changes
TODO test this
* Actually update vehicleId and optimize StriderEntity metadata update
* Don't hide marker armor stands and properly update mount offsets
* What?
* Remove y offset for Shulkers riding other entities
* Confirm teleports in the order received
This allows Bedrock players to move after standing up when using GSit
* Fix mount offset for riders on baby zoglins
* Cache only the latest teleport and confirm teleports immediately
* Fix crawling with GSit
* Inline var and undo respawn method
* Use Entity reference for vehicles
* Remove ridingVehicleEntity from GeyserSession
* Use Entity references for passengers and drop cachedPlayerEntityLinks
* Reuse variable and remove setVehicle(null)
* Fix amount & javaId being used before it is initialized
Fixes invisible falling blocks and incorrectly sized exp orbs
* Add missing item metadata to throwable items and fireballs
Renamed ItemedFireballEntity -> FireballEntity
* Renamed more EntityDefinitions to match MCProtocolLib
* Add some missing metadata and add null check
* Use entity type when possible in debug spawn message
Fallback onto classes simple name
Also don't register ENDER_DRAGON_PART
* Remove redundant entity identifiers and fix END_CRYSTAL and FISHING_BOBBER identifiers
minecraft:end_crystal -> minecraft:ender_crystal
minecraft:fishing_book -> minecraft:fishing_hook
* Cave spider should inherit metadata from spider
* Keep entity definitions in roughly alphabetical order
* Alphabetize entity definitions
* ABCs?
* Bump MCProtocolLib version
