Commit graph

286 commits

Author SHA1 Message Date
Sijawusz Pur Rahnama
28e2871165
Merge pull request #301 from crystal-ameba/Sija/style-redundant-parentheses-rule
Add `Style/RedundantParentheses` rule
2022-11-16 12:22:39 +01:00
Sijawusz Pur Rahnama
935296b041 Refactor ternary handling in Style/RedundantParentheses rule 2022-11-16 03:54:31 +01:00
Sijawusz Pur Rahnama
2fb37da80f Refactor AST::Util#literal? helper 2022-11-15 17:42:08 +01:00
Sijawusz Pur Rahnama
cbf5d3de74 Add Style/RedundantParentheses rule 2022-11-15 15:17:32 +01:00
Sijawusz Pur Rahnama
04b19a60db
Merge pull request #300 from crystal-ameba/Sija/some-refactors
Misc refactors
2022-11-14 17:27:29 +01:00
Sijawusz Pur Rahnama
e668ba5bf5 Readability-related refactors 2022-11-14 02:26:52 +01:00
Sijawusz Pur Rahnama
52bf0a5be4 Refactor Style/PredicateName rule
Do not report `has_<name>?` method names
2022-11-13 20:12:23 +01:00
Vitalii Elenhaupt
2811352cae
Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly
Fix specs on Crystal nightly
2022-11-13 21:07:29 +02:00
Sijawusz Pur Rahnama
5f46612e89 Remove obsolete spec 2022-11-13 01:32:49 +01:00
Sijawusz Pur Rahnama
84540d2a22 Change to alternative approach skipping all macro contexts 2022-11-13 01:25:24 +01:00
Sijawusz Pur Rahnama
5491d31b5f Fix the edge case re: free var comparison 2022-11-13 01:24:59 +01:00
Sijawusz Pur Rahnama
6bf8db81e3 Refactor Lint/StaticComparison to LiteralsComparison 2022-11-02 02:00:37 +01:00
Sijawusz Pur Rahnama
ea42911c3c Extend StaticComparison w/ support of === operator 2022-11-01 03:35:20 +01:00
Sijawusz Pur Rahnama
849be52618 Add Lint/StaticComparison rule 2022-11-01 03:34:28 +01:00
Sijawusz Pur Rahnama
63407c1bd1 Rename to Lint/NotNilAfterNoBang 2022-11-01 02:13:04 +01:00
Sijawusz Pur Rahnama
9515e624c3 Add Lint/NotNilWithNoBang rule 2022-10-31 14:17:47 +01:00
Sijawusz Pur Rahnama
eb64fde437 Fix few issues reported by the newly added rule 2022-10-30 21:44:55 +01:00
Sijawusz Pur Rahnama
67356f246b Add Lint/NotNil rule 2022-10-30 21:36:47 +01:00
Sijawusz Pur Rahnama
ffc712a838 Reduce usage of Object#not_nil! 2022-10-29 00:03:39 +02:00
Vitalii Elenhaupt
60bf8e13ce
fix(style): properly tokenize in RedundantBegin rule 2022-10-14 21:09:30 +03:00
Sijawusz Pur Rahnama
fbd72a5171 Fix regression in AnyInsteadOfEmpty rule 2022-04-22 00:58:37 +02:00
Sijawusz Pur Rahnama
e2faffacfe
Merge branch 'master' into fix/crystal-nightly 2022-04-05 00:37:48 +02:00
Sijawusz Pur Rahnama
20db75a54a Fix typo in UnneededDisableDirective rule spec filename 2022-04-04 22:30:23 +02:00
Sijawusz Pur Rahnama
48d0089d23 Add some whitespaces for readability 2022-04-04 22:17:41 +02:00
Sijawusz Pur Rahnama
306bc34019 Use issue expectation helpers in Performance::FirstLastAfterFilter rule spec 2022-04-04 22:17:13 +02:00
Sijawusz Pur Rahnama
119e20d5e5 Use issue expectation helpers in Performance::SizeAfterFilter rule spec 2022-04-04 22:17:02 +02:00
Sijawusz Pur Rahnama
e0867c04b0 Use issue expectation helpers in Performance::MapInsteadOfBlock rule spec 2022-04-04 22:16:48 +02:00
Sijawusz Pur Rahnama
6f30881ae6 Use issue expectation helpers in Performance::FlattenAfterMap rule spec 2022-04-04 22:16:37 +02:00
Sijawusz Pur Rahnama
931dc3d2dc Use issue expectation helpers in Performance::CompactAfterMap rule spec 2022-04-04 22:16:21 +02:00
Sijawusz Pur Rahnama
b54f0f0738 Use issue expectation helpers in Metrics::CyclomaticComplexity rule spec 2022-04-04 22:15:43 +02:00
Sijawusz Pur Rahnama
8a37d5bbe2 Use issue expectation helpers in Layout::LineLength rule spec 2022-04-04 22:15:07 +02:00
Sijawusz Pur Rahnama
390b26d7f1 Use issue expectation helpers in Lint::AmbiguousAssignment rule spec 2022-04-04 21:32:46 +02:00
Sijawusz Pur Rahnama
caeb1609c9 Use issue expectation helpers in Lint::BadDirective rule spec 2022-04-04 21:27:04 +02:00
Sijawusz Pur Rahnama
5283ae4a96 Use issue expectation helpers in Lint::EmptyLoop rule spec 2022-04-04 21:23:17 +02:00
Sijawusz Pur Rahnama
3cbb388393 Use issue expectation helpers in Lint::HashDuplicatedKey rule spec 2022-04-04 21:20:13 +02:00
Sijawusz Pur Rahnama
18316eaa8b Use issue expectation helpers in Lint::LiteralInInterpolation rule spec 2022-04-04 21:16:48 +02:00
Sijawusz Pur Rahnama
7f85434c85 Use issue expectation helpers in Lint::RandZero rule spec 2022-04-04 21:14:45 +02:00
Sijawusz Pur Rahnama
c58d4cc65a Use issue expectation helpers in Lint::Syntax rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c89d32fcf6 Use issue expectation helpers in Lint::UselessConditionInWhen rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c8daaf4324 Use issue expectation helpers in Lint::UnneededDisableDirective rule spec 2022-04-04 21:10:54 +02:00
Sijawusz Pur Rahnama
614fcfa6a8 Skip macro scopes in ShadowingOuterLocalVar 2022-04-04 01:38:04 +02:00
Sijawusz Pur Rahnama
ad5d56b313 Use issue expectation helpers in ShadowingOuterLocalVar spec 2022-04-04 01:30:27 +02:00
Sijawusz Pur Rahnama
353d09df29 Rename file according to the rule name 2022-04-04 00:42:22 +02:00
Vitalii Elenhaupt
8d4730182f
Rework breaking specs, break backward compatibility 2022-04-04 00:59:21 +03:00
Vitalii Elenhaupt
1f4dda1c4a
Add conditional check using semantic version 2022-04-03 20:16:00 +03:00
Vitalii Elenhaupt
087f470f15
Backward compatibility to Crystal 1.3 2022-04-03 19:17:47 +03:00
Vitalii Elenhaupt
7192b64df0
Fix rest of the specs 2022-03-11 18:00:25 +02:00
Vitalii Elenhaupt
1cfc926a28
Fix specs for tokenizer 2022-03-11 16:18:33 +02:00
Vitalii Elenhaupt
03adc20872
Pass on crystal-nightly 2022-03-11 14:15:05 +02:00
Sijawusz Pur Rahnama
1795bd2959 Bump default value of LargeNumbers#int_min_digits to 6
As most of the error codes are smaller than 6 digits
2022-03-08 14:42:32 +01:00