iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use issue expectation helpers in Performance::FlattenAfterMap rule spec

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2022-04-04 22:16:37 +02:00
parent 931dc3d2dc
commit 6f30881ae6
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
spec/ameba/rule/performance/flatten_after_map_spec.cr
View file

@ -5,32 +5,29 @@ module Ameba::Rule::Performance
describe FlattenAfterMap do
it "passes if there is no potential performance improvements" do
source = Source.new %(
expect_no_issues subject, <<-CRYSTAL
%w[Alice Bob].flat_map(&.chars)
)
subject.catch(source).should be_valid
CRYSTAL
end
it "reports if there is map followed by flatten call" do
source = Source.new %(
expect_issue subject, <<-CRYSTAL
%w[Alice Bob].map(&.chars).flatten
)
subject.catch(source).should_not be_valid
# ^^^^^^^^^^^^^^^^^^^^^ error: Use `flat_map {...}` instead of `map {...}.flatten`
CRYSTAL
end
it "does not report is source is a spec" do
source = Source.new %(
expect_no_issues subject, path: "source_spec.cr", code: <<-CRYSTAL
%w[Alice Bob].map(&.chars).flatten
), "source_spec.cr"
subject.catch(source).should be_valid
CRYSTAL
end
context "macro" do
it "doesn't report in macro scope" do
source = Source.new %(
expect_no_issues subject, <<-CRYSTAL
{{ %w[Alice Bob].map(&.chars).flatten }}
)
subject.catch(source).should be_valid
CRYSTAL
end
end