071a8b7afb
Consistently use `CRYSTAL` marker for heredocs with crystal code
2022-12-08 13:57:46 +01:00
2cb8c1381f
Don’t treat crystal paths as literals in `Lint/LiteralsComparison`
2022-12-08 13:55:29 +01:00
e18da84ede
Add requested spec
2022-12-08 02:16:16 +01:00
1524aad299
Add `Style/QueryBoolMethods` rule
2022-12-08 02:16:16 +01:00
33ef9c6293
Refactor `ExplainFormatter`
2022-11-28 11:38:41 +01:00
38eb5d5e50
Fix invalid crystal syntax in `Lint/Syntax` rule spec
2022-11-23 03:26:55 +01:00
60813e4899
Test generated boolean rule property
2022-11-22 19:53:27 +01:00
9f670c09b5
Refactor `TODOFormatter` spec
2022-11-22 19:52:32 +01:00
c7c75ee36a
`Rule#enabled` -> `Rule#enabled?`
2022-11-22 19:47:37 +01:00
6bd18f9cbf
Fix typo
2022-11-22 19:43:52 +01:00
5ee4074c1b
Rename `RedundantParentheses` -> `ParenthesesAroundCondition`
...
Also rename the option: `parenthesized_assignments` -> `allow_safe_assignment`
2022-11-18 21:06:51 +01:00
0b0a815c31
Add additional test case
2022-11-18 07:04:51 +01:00
eabe463386
Instead of adding the new rule to support enforcing parens around assignments, refactor existing `RedundantParentheses` rule
2022-11-18 05:27:05 +01:00
496e8930e2
Merge pull request #303 from crystal-ameba/Sija/lint-literal-assignments-in-expressions-rule
...
Add `Lint/LiteralAssignmentsInExpressions` rule
2022-11-17 14:19:17 +01:00
95d68114c7
Fix typos throughout the code
2022-11-16 16:55:32 +01:00
5c08b64e72
Add `Lint/LiteralAssignmentsInExpressions` rule
2022-11-16 15:08:41 +01:00
28e2871165
Merge pull request #301 from crystal-ameba/Sija/style-redundant-parentheses-rule
...
Add `Style/RedundantParentheses` rule
2022-11-16 12:22:39 +01:00
935296b041
Refactor ternary handling in `Style/RedundantParentheses` rule
2022-11-16 03:54:31 +01:00
2fb37da80f
Refactor `AST::Util#literal?` helper
2022-11-15 17:42:08 +01:00
cbf5d3de74
Add `Style/RedundantParentheses` rule
2022-11-15 15:17:32 +01:00
04b19a60db
Merge pull request #300 from crystal-ameba/Sija/some-refactors
...
Misc refactors
2022-11-14 17:27:29 +01:00
e668ba5bf5
Readability-related refactors
2022-11-14 02:26:52 +01:00
52bf0a5be4
Refactor `Style/PredicateName` rule
...
Do not report `has_<name>?` method names
2022-11-13 20:12:23 +01:00
2811352cae
Merge pull request #298 from crystal-ameba/Sija/fix-specs-on-crystal-nightly
...
Fix specs on Crystal nightly
2022-11-13 21:07:29 +02:00
5f46612e89
Remove obsolete spec
2022-11-13 01:32:49 +01:00
84540d2a22
Change to alternative approach skipping all macro contexts
2022-11-13 01:25:24 +01:00
5491d31b5f
Fix the edge case re: free var comparison
2022-11-13 01:24:59 +01:00
6bf8db81e3
Refactor `Lint/StaticComparison` to `LiteralsComparison`
2022-11-02 02:00:37 +01:00
ea42911c3c
Extend `StaticComparison` w/ support of `===` operator
2022-11-01 03:35:20 +01:00
849be52618
Add `Lint/StaticComparison` rule
2022-11-01 03:34:28 +01:00
63407c1bd1
Rename to `Lint/NotNilAfterNoBang`
2022-11-01 02:13:04 +01:00
9515e624c3
Add `Lint/NotNilWithNoBang` rule
2022-10-31 14:17:47 +01:00
eb64fde437
Fix few issues reported by the newly added rule
2022-10-30 21:44:55 +01:00
67356f246b
Add `Lint/NotNil` rule
2022-10-30 21:36:47 +01:00
ffc712a838
Reduce usage of `Object#not_nil!`
2022-10-29 00:03:39 +02:00
60bf8e13ce
fix(style): properly tokenize in RedundantBegin rule
2022-10-14 21:09:30 +03:00
fbd72a5171
Fix regression in `AnyInsteadOfEmpty` rule
2022-04-22 00:58:37 +02:00
e2faffacfe
Merge branch 'master' into fix/crystal-nightly
2022-04-05 00:37:48 +02:00
20db75a54a
Fix typo in `UnneededDisableDirective` rule spec filename
2022-04-04 22:30:23 +02:00
48d0089d23
Add some whitespaces for readability
2022-04-04 22:17:41 +02:00
306bc34019
Use issue expectation helpers in `Performance::FirstLastAfterFilter` rule spec
2022-04-04 22:17:13 +02:00
119e20d5e5
Use issue expectation helpers in `Performance::SizeAfterFilter` rule spec
2022-04-04 22:17:02 +02:00
e0867c04b0
Use issue expectation helpers in `Performance::MapInsteadOfBlock` rule spec
2022-04-04 22:16:48 +02:00
6f30881ae6
Use issue expectation helpers in `Performance::FlattenAfterMap` rule spec
2022-04-04 22:16:37 +02:00
931dc3d2dc
Use issue expectation helpers in `Performance::CompactAfterMap` rule spec
2022-04-04 22:16:21 +02:00
b54f0f0738
Use issue expectation helpers in `Metrics::CyclomaticComplexity` rule spec
2022-04-04 22:15:43 +02:00
8a37d5bbe2
Use issue expectation helpers in `Layout::LineLength` rule spec
2022-04-04 22:15:07 +02:00
390b26d7f1
Use issue expectation helpers in `Lint::AmbiguousAssignment` rule spec
2022-04-04 21:32:46 +02:00
caeb1609c9
Use issue expectation helpers in `Lint::BadDirective` rule spec
2022-04-04 21:27:04 +02:00
5283ae4a96
Use issue expectation helpers in `Lint::EmptyLoop` rule spec
2022-04-04 21:23:17 +02:00
3cbb388393
Use issue expectation helpers in `Lint::HashDuplicatedKey` rule spec
2022-04-04 21:20:13 +02:00
18316eaa8b
Use issue expectation helpers in `Lint::LiteralInInterpolation` rule spec
2022-04-04 21:16:48 +02:00
7f85434c85
Use issue expectation helpers in `Lint::RandZero` rule spec
2022-04-04 21:14:45 +02:00
c58d4cc65a
Use issue expectation helpers in `Lint::Syntax` rule spec
2022-04-04 21:11:04 +02:00
c89d32fcf6
Use issue expectation helpers in `Lint::UselessConditionInWhen` rule spec
2022-04-04 21:11:04 +02:00
c8daaf4324
Use issue expectation helpers in `Lint::UnneededDisableDirective` rule spec
2022-04-04 21:10:54 +02:00
614fcfa6a8
Skip macro scopes in `ShadowingOuterLocalVar`
2022-04-04 01:38:04 +02:00
ad5d56b313
Use issue expectation helpers in `ShadowingOuterLocalVar` spec
2022-04-04 01:30:27 +02:00
353d09df29
Rename file according to the rule name
2022-04-04 00:42:22 +02:00
8d4730182f
Rework breaking specs, break backward compatibility
2022-04-04 00:59:21 +03:00
1f4dda1c4a
Add conditional check using semantic version
2022-04-03 20:16:00 +03:00
087f470f15
Backward compatibility to Crystal 1.3
2022-04-03 19:17:47 +03:00
7192b64df0
Fix rest of the specs
2022-03-11 18:00:25 +02:00
1cfc926a28
Fix specs for tokenizer
2022-03-11 16:18:33 +02:00
03adc20872
Pass on crystal-nightly
2022-03-11 14:15:05 +02:00
1795bd2959
Bump default value of `LargeNumbers#int_min_digits` to 6
...
As most of the error codes are smaller than 6 digits
2022-03-08 14:42:32 +01:00
66ee7642cf
Add `Lint/DebugCalls` rule
2021-12-31 16:44:02 +01:00
f288cc3c4f
Add `Style/GuardClause` rule ( #254 )
2021-12-09 21:33:47 +01:00
63bafba72e
Fix unexpected token compiler error match
2021-11-29 22:04:59 +01:00
63a6c73dc0
Autocorrect various rules ( #253 )
2021-11-16 22:30:33 +01:00
429f76f8b6
Do not report unreachable code after loops
...
closes #251
2021-11-10 09:16:14 +02:00
d06812ea8e
Add `VariableNames` test for method with multiple instance vars
2021-11-09 11:52:31 -08:00
01dfcbe76a
Add tests for `AST::Util#control_exp_code`
2021-11-09 11:52:31 -08:00
c9ba487373
Add custom `NodeVisitor` subclass for `Style/VariableNames`
2021-11-09 09:26:00 -08:00
bd1a1a1fd4
Shorten long line in `Stye/VerboseBlock` spec
2021-11-09 09:07:19 -08:00
b32b00adad
Convert remaining `Style` specs
2021-11-08 14:24:11 -08:00
72a3487bb6
Autocorrect `Stye/WhileTrue`
2021-11-08 14:24:11 -08:00
571969265f
Convert `Style/VerboseBlock` spec
2021-11-08 14:24:11 -08:00
e93dfe9cdc
Convert `Style/VariableNames` spec
2021-11-08 14:24:11 -08:00
265bc51481
Convert `Style/UnlessElse` spec
2021-11-08 14:07:35 -08:00
06c0887136
Convert `Style/TypeNames` spec
2021-11-08 14:07:35 -08:00
e7cfe387d6
Autocorrect `Stye/RedundantNext` and `Style/RedundantReturn`
2021-11-08 14:07:35 -08:00
7b437fbd2f
Remove `normalize` parameter from `expect_issue` ( #249 )
...
* Add `normalize` parameter to `expect_correction`
* Convert Style/IsAFilter spec
* Revert "Add `normalize` parameter to `expect_correction`"
This reverts commit 4b67e4b900
2021-11-06 15:15:19 +02:00
78071722c4
Rename `s` to `source`
2021-11-01 08:55:48 -07:00
c2aa2fedb6
Return `source` from `expect_issue`
2021-10-31 22:44:48 -07:00
437584f9db
Raise error if infinite correction loop
2021-10-26 22:22:22 -07:00
1d5f554e88
Apply suggestions from code review
2021-10-26 12:06:24 -07:00
f39a7a4cd4
Re-run autocorrect until all correctable issues have been corrected
2021-10-25 15:09:44 -07:00
573881cb8a
Autocorrect `Layout/TrailingBlankLines` partially
2021-10-25 12:38:29 -07:00
e5fb0526e0
Autocorrect `Style/LargeNumbers`
2021-10-25 12:38:29 -07:00
c1b4add094
Add `Source::Corrector` and `Source::Rewriter`
2021-10-25 12:38:29 -07:00
9f0b9a709e
Allow named replacements in expect_issue
2021-10-23 01:37:24 -07:00
3d432fdee8
Add expect_issue and expect_no_issues spec helpers ( #245 )
2021-10-22 19:54:39 +02:00
48b15b9bf8
Add Lint/AmbiguousAssignment rule ( #244 )
2021-10-19 11:44:41 +02:00
43dea0e49d
Fix typos throughout the codebase
2021-07-03 14:15:23 +02:00
651f70f680
Update spec/ameba/ast/visitors/counting_visitor_spec.cr
2021-06-05 20:49:00 +02:00
0ea6238dc6
Count an exhaustive `case`'s complexity as 1
2021-06-05 22:31:58 +10:00
a64f48b543
ShadowingOuterLocalVar while it is not in macro
...
closes #224
2021-04-18 20:55:10 +03:00
9e2d4f1856
Disable performance rules for spec files
...
closes #220
2021-04-18 09:39:55 +03:00
2694a0c865
Remove “join” from the list of trigger methods
2021-04-12 06:22:54 +02:00
Sijawusz Pur Rahnama
Vitalii Elenhaupt
Vitalii Elenhaupt
fn ⌃ ⌥
Johannes Müller
Caspian Baska