Commit graph

407 commits

Author SHA1 Message Date
Stephen Dolan
04ba9cd57a
Change Style/VerboseBlock - ExcludeOperators - setting default (#218) 2021-03-24 21:16:51 +01:00
Sijawusz Pur Rahnama
f4ffb8a287
Merge pull request #216 from crystal-ameba/is_a_filter_in_multi_args_block
Do not report IsAFilter if there is a block with multiple args
2021-03-23 21:30:09 +01:00
Sijawusz Pur Rahnama
975ff31099
Merge pull request #217 from kachick/revert-215-follow-crystal-1.0.0
Revert "Follow crystal 1.0.0 in shard.yml"
2021-03-23 21:27:04 +01:00
Kenichi Kamiya
e7b7b10081
Revert "Follow crystal 1.0.0 in shard.yml" 2021-03-24 03:58:40 +09:00
Vitalii Elenhaupt
13605afe4a
Do not report IsAFilter if there is a block with multiple args 2021-03-23 20:57:50 +02:00
Vitalii Elenhaupt
320ec2ba75
Merge pull request #215 from kachick/follow-crystal-1.0.0
Follow crystal 1.0.0 in shard.yml
2021-03-23 18:20:46 +02:00
Kenichi Kamiya
ef91c0ea11 Follow crystal 1.0.0 in shard.yml 2021-03-24 01:10:16 +09:00
Vitalii Elenhaupt
6aaf398c43
Bump v0.14.1 2021-03-14 16:20:42 +02:00
Vitalii Elenhaupt
ad405e09b0
Merge branch 'master' into develop 2021-03-08 11:09:32 +02:00
Sijawusz Pur Rahnama
c1deb8ab73
Use alpine:latest image in Dockerfile 2021-03-08 11:08:31 +02:00
Sijawusz Pur Rahnama
e32f1dd673
Merge pull request #210 from crystal-ameba/tweak-verbose-block-rule-defaults 2021-03-03 16:12:49 +01:00
Sijawusz Pur Rahnama
56110b3883 Default to exclude_multiple_line_blocks in Style/VerboseBlock rule 2021-03-03 00:31:53 +01:00
Sijawusz Pur Rahnama
6e622456ff
Merge pull request #209 from crystal-ameba/Sija/fix-missed-operator
Add ~ as the prefix operator to the Style/VerboseBlock rule
2021-03-02 15:28:00 +01:00
Sijawusz Pur Rahnama
8f308e73e5 Add ~ as the prefix operator 2021-03-02 12:40:46 +01:00
Vitalii Elenhaupt
d8c32f0045
Merge pull request #207 from crystal-ameba/release/0.14.0
Release 0.14.0
2021-02-24 10:09:47 +02:00
Vitalii Elenhaupt
3a1ee7fa21
Correct yml examples 2021-02-11 11:01:30 +02:00
Sijawusz Pur Rahnama
bf64c8242b Bump to v0.14.0 2021-02-08 21:03:34 +01:00
Sijawusz Pur Rahnama
a169b12b99
Merge pull request #201 from crystal-ameba/feature/verbose-block-rule
Add Style/VerboseBlock rule
2021-02-08 15:13:01 +01:00
Sijawusz Pur Rahnama
694c41650c Remove redundant check and add a few more test cases 2021-02-05 01:23:29 +01:00
Sijawusz Pur Rahnama
a9d1b17deb Support named arguments in VerboseBlock#node_to_s 2021-02-05 01:23:29 +01:00
Sijawusz Pur Rahnama
16743a756c Add ExcludePrefixOperators option to Style/VerboseBlock rule 2021-02-04 21:59:23 +01:00
Sijawusz Pur Rahnama
eed094b928 Fix couple of edge-cases in VerboseBlock rule 2021-02-04 21:59:23 +01:00
Sijawusz Pur Rahnama
5faf8da81c Split VerboseBlock#test method into a smaller pieces 2021-02-04 21:59:23 +01:00
Sijawusz Pur Rahnama
4b7f3ba6ee Add MaxLineLength option to Style/VerboseBlock rule 2021-02-04 21:59:22 +01:00
Sijawusz Pur Rahnama
a53d44617d Fix newly found issues 2021-02-04 21:59:22 +01:00
Sijawusz Pur Rahnama
0739fad670 Add Style/VerboseBlock rule 2021-02-04 21:59:22 +01:00
Vitalii Elenhaupt
7697663fec
Merge pull request #205 from crystal-ameba/master-into-develop
Merge master into develop
2021-02-04 08:00:11 +02:00
Sijawusz Pur Rahnama
99da6b6916 Merge remote-tracking branch 'origin/master' into master-into-develop 2021-02-03 22:45:35 +01:00
Vitalii Elenhaupt
d8aa218e20
NewRule: SpecFocus (#204)
* NewRule: SpecFocus

closes #172

* Utilize Source#spec?
2021-02-03 17:36:39 +02:00
Vitalii Elenhaupt
f8c22a6e77
Utilize Source#spec? 2021-02-03 17:25:46 +02:00
Vitalii Elenhaupt
ecad80a96b
NewRule: SpecFocus
closes #172
2021-02-03 17:10:07 +02:00
Vitalii Elenhaupt
51b0a07e81
Avoid exponential recursion while finding variable references in scopes (#203)
* Avoid exponential recursion while finding variable references in scopes

* Adjust source example in test
2021-01-31 16:40:44 +02:00
Sijawusz Pur Rahnama
fac8072ec1
Merge pull request #197 from crystal-ameba/feature/any-instead-of-empty
Add Performance/AnyInsteadOfEmpty rule
2021-01-28 10:28:30 +01:00
Sijawusz Pur Rahnama
2dc37360b2
Merge pull request #202 from crystal-ameba/feature/is-a-filter-rule
Add Style/IsAFilter rule
2021-01-28 10:28:06 +01:00
Sijawusz Pur Rahnama
7b3c814914 Fix newly found issues 2021-01-28 01:03:48 +01:00
Sijawusz Pur Rahnama
d71091a40c Add Performance/AnyInsteadOfEmpty rule 2021-01-28 01:03:48 +01:00
Sijawusz Pur Rahnama
95d340c3ad Add Style/IsAFilter rule 2021-01-28 00:58:06 +01:00
Vitalii Elenhaupt
d28f9f756e
Bump v0.13.4 2021-01-26 18:21:51 +02:00
Sijawusz Pur Rahnama
ea98554191
Add support for showing end location marker (#200)
* Add support for showing end location marker

* Cleanup Reportable method definitions

There’s no need for double splats, since they mess up method resolution, and obscure the actual - single (!) - argument - `status`, so… be gone

Also, all of the helpers return the constructed `Issue` like a behaving good methods.

* Refactor Util#affected_code

* Increase max length of trimmed lines to 120 characters

* Refactor Issue to use enum instead of a symbol for #status

* Optimize Reportable#valid?

* Add spec coverage for newly added Util methods

* Refactor DotFormatter a bit

Make text format moar in line with Crystal spec runner.

* Update README.md
2021-01-26 08:38:19 +02:00
Sijawusz Pur Rahnama
8b52dc4b1d
Merge pull request #199 from crystal-ameba/Sija/rename-chained-calls-with-no-bang
ChainedCallsWithNoBang -> ChainedCallWithNoBang
2021-01-22 22:48:57 +01:00
Sijawusz Pur Rahnama
6acb8ad2eb ChainedCallsWithNoBang -> ChainedCallWithNoBang 2021-01-22 17:24:45 +01:00
Sijawusz Pur Rahnama
79ff1f75db
Merge pull request #198 from crystal-ameba/Sija/followup-to-pr-195 2021-01-22 16:11:32 +01:00
Sijawusz Pur Rahnama
8babeea80f Add repeated_combinations and repeated_permutations 2021-01-22 12:21:14 +01:00
Sijawusz Pur Rahnama
a219a73258 Remove rotate from the list of call_names
In some cases it returns `self` and not a copy.
2021-01-22 12:20:50 +01:00
Sijawusz Pur Rahnama
5f6c14c9d6
Merge pull request #195 from crystal-ameba/feature/chained-calls-with-no-bang
Add Performance/ChainedCallsWithNoBang rule
2021-01-21 13:27:35 +01:00
Sijawusz Pur Rahnama
d3b952f58a Add Performance/ChainedCallsWithNoBang rule 2021-01-21 12:47:10 +01:00
Vitalii Elenhaupt
7aa7efd4bd Do not report if variable is assigned and referenced in MacroFor/MacroIf/MacroExpression
closes #194
2021-01-20 13:14:42 +02:00
Sijawusz Pur Rahnama
9853203f19
Merge pull request #191 from crystal-ameba/Sija/change-rule-to-class
Change Rule to a class
2021-01-19 22:20:05 +01:00
Sijawusz Pur Rahnama
ad8f570a04 Change Rule to class 2021-01-19 22:17:17 +01:00
Sijawusz Pur Rahnama
ddaa58f475
Merge pull request #192 from crystal-ameba/feature/flatten-after-map-rule
Add Performance/FlattenAfterMap rule
2021-01-19 22:16:10 +01:00