Fix newly found issues

This commit is contained in:
Sijawusz Pur Rahnama 2021-01-22 02:37:11 +01:00
parent d71091a40c
commit 7b3c814914
7 changed files with 8 additions and 8 deletions

View file

@ -51,7 +51,7 @@ module Ameba::AST
it "adds a new variable to the scope" do
scope = Scope.new as_node("")
scope.add_variable(Crystal::Var.new "foo")
scope.variables.any?.should be_true
scope.variables.empty?.should be_false
end
end

View file

@ -48,7 +48,7 @@ module Ameba::AST
it "assigns the variable (creates a new assignment)" do
variable = Variable.new(var_node, scope)
variable.assign(assign_node, scope)
variable.assignments.any?.should be_true
variable.assignments.empty?.should be_false
end
it "can create multiple assignments" do
@ -64,7 +64,7 @@ module Ameba::AST
variable = Variable.new(var_node, scope)
variable.assign(as_node("foo=1"), scope)
variable.reference(var_node, scope)
variable.references.any?.should be_true
variable.references.empty?.should be_false
end
it "adds a reference to the scope" do

View file

@ -58,7 +58,7 @@ module Ameba::AST
# variable.referenced? # => true
# ```
def referenced?
references.any?
!references.empty?
end
# Creates a reference to this variable in some scope.

View file

@ -60,7 +60,7 @@ module Ameba::AST
end
private def in_loop?
@loop_stack.any?
!@loop_stack.empty?
end
end
end

View file

@ -61,7 +61,7 @@ module Ameba::Cli
if f.size == 1 && f.first =~ /.+:\d+:\d+/
configure_explain_opts(f.first, opts)
else
opts.globs = f if f.any?
opts.globs = f unless f.empty?
end
end

View file

@ -36,7 +36,7 @@ module Ameba::Rule::Lint
next unless token.type == :COMMENT
next unless directive = source.parse_inline_directive(token.value.to_s)
next unless names = unneeded_disables(source, directive, token.location)
next unless names.any?
next if names.empty?
issue_for token, MSG % names.join(", ")
end

View file

@ -45,7 +45,7 @@ module Ameba::Rule::Performance
def test(source, node : Crystal::Call)
return unless node.name.in?(CALL_NAMES) && (obj = node.obj)
return unless obj.is_a?(Crystal::Call) && obj.block
return if !node.block.nil? || node.args.any?
return unless node.block.nil? && node.args.empty?
return unless obj.name.in?(filter_names)
message = node.name.includes?(CALL_NAMES.first) ? MSG : MSG_REVERSE