Commit Graph

268 Commits

Author SHA1 Message Date
Sijawusz Pur Rahnama ffc712a838 Reduce usage of `Object#not_nil!` 2022-10-29 00:03:39 +02:00
Vitalii Elenhaupt 60bf8e13ce
fix(style): properly tokenize in RedundantBegin rule 2022-10-14 21:09:30 +03:00
Sijawusz Pur Rahnama fbd72a5171 Fix regression in `AnyInsteadOfEmpty` rule 2022-04-22 00:58:37 +02:00
Sijawusz Pur Rahnama e2faffacfe
Merge branch 'master' into fix/crystal-nightly 2022-04-05 00:37:48 +02:00
Sijawusz Pur Rahnama 20db75a54a Fix typo in `UnneededDisableDirective` rule spec filename 2022-04-04 22:30:23 +02:00
Sijawusz Pur Rahnama 48d0089d23 Add some whitespaces for readability 2022-04-04 22:17:41 +02:00
Sijawusz Pur Rahnama 306bc34019 Use issue expectation helpers in `Performance::FirstLastAfterFilter` rule spec 2022-04-04 22:17:13 +02:00
Sijawusz Pur Rahnama 119e20d5e5 Use issue expectation helpers in `Performance::SizeAfterFilter` rule spec 2022-04-04 22:17:02 +02:00
Sijawusz Pur Rahnama e0867c04b0 Use issue expectation helpers in `Performance::MapInsteadOfBlock` rule spec 2022-04-04 22:16:48 +02:00
Sijawusz Pur Rahnama 6f30881ae6 Use issue expectation helpers in `Performance::FlattenAfterMap` rule spec 2022-04-04 22:16:37 +02:00
Sijawusz Pur Rahnama 931dc3d2dc Use issue expectation helpers in `Performance::CompactAfterMap` rule spec 2022-04-04 22:16:21 +02:00
Sijawusz Pur Rahnama b54f0f0738 Use issue expectation helpers in `Metrics::CyclomaticComplexity` rule spec 2022-04-04 22:15:43 +02:00
Sijawusz Pur Rahnama 8a37d5bbe2 Use issue expectation helpers in `Layout::LineLength` rule spec 2022-04-04 22:15:07 +02:00
Sijawusz Pur Rahnama 390b26d7f1 Use issue expectation helpers in `Lint::AmbiguousAssignment` rule spec 2022-04-04 21:32:46 +02:00
Sijawusz Pur Rahnama caeb1609c9 Use issue expectation helpers in `Lint::BadDirective` rule spec 2022-04-04 21:27:04 +02:00
Sijawusz Pur Rahnama 5283ae4a96 Use issue expectation helpers in `Lint::EmptyLoop` rule spec 2022-04-04 21:23:17 +02:00
Sijawusz Pur Rahnama 3cbb388393 Use issue expectation helpers in `Lint::HashDuplicatedKey` rule spec 2022-04-04 21:20:13 +02:00
Sijawusz Pur Rahnama 18316eaa8b Use issue expectation helpers in `Lint::LiteralInInterpolation` rule spec 2022-04-04 21:16:48 +02:00
Sijawusz Pur Rahnama 7f85434c85 Use issue expectation helpers in `Lint::RandZero` rule spec 2022-04-04 21:14:45 +02:00
Sijawusz Pur Rahnama c58d4cc65a Use issue expectation helpers in `Lint::Syntax` rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama c89d32fcf6 Use issue expectation helpers in `Lint::UselessConditionInWhen` rule spec 2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama c8daaf4324 Use issue expectation helpers in `Lint::UnneededDisableDirective` rule spec 2022-04-04 21:10:54 +02:00
Sijawusz Pur Rahnama 614fcfa6a8 Skip macro scopes in `ShadowingOuterLocalVar` 2022-04-04 01:38:04 +02:00
Sijawusz Pur Rahnama ad5d56b313 Use issue expectation helpers in `ShadowingOuterLocalVar` spec 2022-04-04 01:30:27 +02:00
Sijawusz Pur Rahnama 353d09df29 Rename file according to the rule name 2022-04-04 00:42:22 +02:00
Vitalii Elenhaupt 8d4730182f
Rework breaking specs, break backward compatibility 2022-04-04 00:59:21 +03:00
Vitalii Elenhaupt 1f4dda1c4a
Add conditional check using semantic version 2022-04-03 20:16:00 +03:00
Vitalii Elenhaupt 087f470f15
Backward compatibility to Crystal 1.3 2022-04-03 19:17:47 +03:00
Vitalii Elenhaupt 7192b64df0
Fix rest of the specs 2022-03-11 18:00:25 +02:00
Vitalii Elenhaupt 1cfc926a28
Fix specs for tokenizer 2022-03-11 16:18:33 +02:00
Vitalii Elenhaupt 03adc20872
Pass on crystal-nightly 2022-03-11 14:15:05 +02:00
Sijawusz Pur Rahnama 1795bd2959 Bump default value of `LargeNumbers#int_min_digits` to 6
As most of the error codes are smaller than 6 digits
2022-03-08 14:42:32 +01:00
Sijawusz Pur Rahnama 66ee7642cf Add `Lint/DebugCalls` rule 2021-12-31 16:44:02 +01:00
fn ⌃ ⌥ f288cc3c4f
Add `Style/GuardClause` rule (#254) 2021-12-09 21:33:47 +01:00
Johannes Müller 63bafba72e
Fix unexpected token compiler error match 2021-11-29 22:04:59 +01:00
fn ⌃ ⌥ 63a6c73dc0
Autocorrect various rules (#253) 2021-11-16 22:30:33 +01:00
Vitalii Elenhaupt 429f76f8b6
Do not report unreachable code after loops
closes #251
2021-11-10 09:16:14 +02:00
fn ⌃ ⌥ d06812ea8e Add `VariableNames` test for method with multiple instance vars 2021-11-09 11:52:31 -08:00
fn ⌃ ⌥ 01dfcbe76a Add tests for `AST::Util#control_exp_code` 2021-11-09 11:52:31 -08:00
fn ⌃ ⌥ c9ba487373 Add custom `NodeVisitor` subclass for `Style/VariableNames` 2021-11-09 09:26:00 -08:00
fn ⌃ ⌥ bd1a1a1fd4 Shorten long line in `Stye/VerboseBlock` spec 2021-11-09 09:07:19 -08:00
fn ⌃ ⌥ b32b00adad Convert remaining `Style` specs 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥ 72a3487bb6 Autocorrect `Stye/WhileTrue` 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥ 571969265f Convert `Style/VerboseBlock` spec 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥ e93dfe9cdc Convert `Style/VariableNames` spec 2021-11-08 14:24:11 -08:00
fn ⌃ ⌥ 265bc51481 Convert `Style/UnlessElse` spec 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥ 06c0887136 Convert `Style/TypeNames` spec 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥ e7cfe387d6 Autocorrect `Stye/RedundantNext` and `Style/RedundantReturn` 2021-11-08 14:07:35 -08:00
fn ⌃ ⌥ 7b437fbd2f
Remove `normalize` parameter from `expect_issue` (#249)
* Add `normalize` parameter to `expect_correction`

* Convert Style/IsAFilter spec

* Revert "Add `normalize` parameter to `expect_correction`"

This reverts commit 4b67e4b900.

* Remove `normalize` parameter from `expect_issue`

* Require indentation if multiple issues on a single line

* Update `Style/IsAFilter` spec

* Update `ExpectIssue` documentation

* Add missing `expect_no_corrections`

* Use carets and space with issues at column 1 or 2

* Update `expect_issue` docs
2021-11-06 15:15:19 +02:00
fn ⌃ ⌥ 78071722c4 Rename `s` to `source` 2021-11-01 08:55:48 -07:00