76a4209706
Tweak comments in `AST::Util`
2022-11-15 17:42:08 +01:00
2fb37da80f
Refactor `AST::Util#literal?` helper
2022-11-15 17:42:08 +01:00
3340613a6a
Fix newly found issue
2022-11-15 15:17:32 +01:00
cbf5d3de74
Add `Style/RedundantParentheses` rule
2022-11-15 15:17:32 +01:00
04b19a60db
Merge pull request #300 from crystal-ameba/Sija/some-refactors
...
Misc refactors
2022-11-14 17:27:29 +01:00
e668ba5bf5
Readability-related refactors
2022-11-14 02:26:52 +01:00
a6ebb48f14
Remove redundant parentheses in `if` expressions
...
+ `elsif` -> `case`
2022-11-14 01:52:07 +01:00
d1bfdaabeb
Use `#in?` instead of `#includes?` in several places
...
Because:
1. it’s more semantically descriptive
2. it’s shorter
2022-11-14 01:18:43 +01:00
ed6085e6a6
Several refactors in `Style/GuardClause` rule
...
Mostly readability related
2022-11-14 01:18:43 +01:00
353c0a1583
Fix typo + add `NOTE` pragma
2022-11-14 01:05:13 +01:00
5db7a2cf5a
Turn on `Style/PredicateName` rule by default
2022-11-13 20:12:39 +01:00
52bf0a5be4
Refactor `Style/PredicateName` rule
...
Do not report `has_<name>?` method names
2022-11-13 20:12:23 +01:00
84540d2a22
Change to alternative approach skipping all macro contexts
2022-11-13 01:25:24 +01:00
5491d31b5f
Fix the edge case re: free var comparison
2022-11-13 01:24:59 +01:00
aee5de517b
Add `Crystal::Path` to the list of primitive types
...
So, the comparisons like `Regex == 1=42` will also be detected.
2022-11-02 02:06:22 +01:00
6bf8db81e3
Refactor `Lint/StaticComparison` to `LiteralsComparison`
2022-11-02 02:00:37 +01:00
ea42911c3c
Extend `StaticComparison` w/ support of `===` operator
2022-11-01 03:35:20 +01:00
849be52618
Add `Lint/StaticComparison` rule
2022-11-01 03:34:28 +01:00
63407c1bd1
Rename to `Lint/NotNilAfterNoBang`
2022-11-01 02:13:04 +01:00
9515e624c3
Add `Lint/NotNilWithNoBang` rule
2022-10-31 14:17:47 +01:00
8d4a4dfd7a
Merge pull request #290 from crystal-ameba/Sija/remove-trailing-dots-from-rule-descriptions
...
Remove trailing dots from rule descriptions
2022-10-30 23:51:32 +01:00
038a3657c0
Merge pull request #288 from crystal-ameba/Sija/lint-not-nil-rule
...
Add `Lint/NotNil` rule
2022-10-30 23:50:38 +01:00
d942524efa
Remove trailing dots from rule descriptions
2022-10-30 21:53:09 +01:00
eb64fde437
Fix few issues reported by the newly added rule
2022-10-30 21:44:55 +01:00
67356f246b
Add `Lint/NotNil` rule
2022-10-30 21:36:47 +01:00
6834292265
Merge pull request #287 from crystal-ameba/enable-lint-empty-expression-by-default
...
Enable `Lint/EmptyExpression` by default
2022-10-30 21:01:28 +01:00
e54e5d0534
Fix `Source::Corrector#remove_{leading,trailing}` methods
2022-10-30 19:50:25 +01:00
2d3bca7b1a
Enable `Lint/EmptyExpression` by default
2022-10-30 15:30:55 +01:00
400954ebb5
Use `String#hash` instead of `Digest::SHA1.hexdigest`
2022-10-29 21:49:00 +02:00
4700ae7649
Merge pull request #282 from crystal-ameba/Sija/fix-issue-270
...
Populate `Rule::Base+.parsed_doc` on compile time
2022-10-29 18:12:55 +02:00
ca2c5a7273
Small refactor to `DocFinder#visit`
2022-10-29 18:07:52 +02:00
d55b93c866
Rename `read_rule_doc` -> `read_type_doc`
...
Also, move the helper script into the `contrib` directory
2022-10-29 18:03:30 +02:00
a9ae491aca
Merge pull request #280 from crystal-ameba/Sija-verbose-block-configuration-example-typo
2022-10-29 11:59:06 +02:00
3d61254739
Populate `Rule::Base+.parsed_doc` on compile time
2022-10-29 01:35:34 +02:00
ffc712a838
Reduce usage of `Object#not_nil!`
2022-10-29 00:03:39 +02:00
4063290530
Fix typo in a `Style/VerboseBlock` configuration example
2022-10-28 23:48:47 +02:00
60bf8e13ce
fix(style): properly tokenize in RedundantBegin rule
2022-10-14 21:09:30 +03:00
d2fbf484f4
Crystal 1.6 support
2022-10-14 20:55:29 +03:00
1bef5fc5c1
fix restriction issue ( #271 )
...
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
2022-08-01 23:50:30 +02:00
fbd72a5171
Fix regression in `AnyInsteadOfEmpty` rule
2022-04-22 00:58:37 +02:00
e2faffacfe
Merge branch 'master' into fix/crystal-nightly
2022-04-05 00:37:48 +02:00
e6ad7c5d24
Fix bug in `AST::Scope#in_macro?` not taking account for `Crystal::MacroFor`
2022-04-04 02:05:13 +02:00
71de3f0012
Cleanup method docs in `AST::Scope`
2022-04-04 02:05:13 +02:00
614fcfa6a8
Skip macro scopes in `ShadowingOuterLocalVar`
2022-04-04 01:38:04 +02:00
2e9ef7fcb2
Reword `visit(node)` methods comment in `AST::NodeVisitor`
2022-04-04 01:35:59 +02:00
a38cfd1661
Refactor `AST::ScopeVisitor` similarly to `AST::NodeVisitor`
2022-04-04 01:35:32 +02:00
3f7ade573a
Add ability to skip some of the nodes in `AST::ScopeVisitor`
2022-04-04 01:34:34 +02:00
353d09df29
Rename file according to the rule name
2022-04-04 00:42:22 +02:00
8d4730182f
Rework breaking specs, break backward compatibility
2022-04-04 00:59:21 +03:00
2f29999106
Return boolean
2022-04-03 19:43:51 +03:00
087f470f15
Backward compatibility to Crystal 1.3
2022-04-03 19:17:47 +03:00
7192b64df0
Fix rest of the specs
2022-03-11 18:00:25 +02:00
1cfc926a28
Fix specs for tokenizer
2022-03-11 16:18:33 +02:00
03adc20872
Pass on crystal-nightly
2022-03-11 14:15:05 +02:00
dad72341cb
Merge pull request #258 from crystal-ameba/bump-large-numbers-min-int-digits
...
Bump default value of `LargeNumbers#int_min_digits` to 6
2022-03-08 14:48:45 +01:00
1795bd2959
Bump default value of `LargeNumbers#int_min_digits` to 6
...
As most of the error codes are smaller than 6 digits
2022-03-08 14:42:32 +01:00
9e81777e7e
Disable `Style/LargeNumbers` by default
2022-03-05 22:38:36 +01:00
66ee7642cf
Add `Lint/DebugCalls` rule
2021-12-31 16:44:02 +01:00
f288cc3c4f
Add `Style/GuardClause` rule ( #254 )
2021-12-09 21:33:47 +01:00
63a6c73dc0
Autocorrect various rules ( #253 )
2021-11-16 22:30:33 +01:00
429f76f8b6
Do not report unreachable code after loops
...
closes #251
2021-11-10 09:16:14 +02:00
01dfcbe76a
Add tests for `AST::Util#control_exp_code`
2021-11-09 11:52:31 -08:00
c9ba487373
Add custom `NodeVisitor` subclass for `Style/VariableNames`
2021-11-09 09:26:00 -08:00
72a3487bb6
Autocorrect `Stye/WhileTrue`
2021-11-08 14:24:11 -08:00
571969265f
Convert `Style/VerboseBlock` spec
2021-11-08 14:24:11 -08:00
e93dfe9cdc
Convert `Style/VariableNames` spec
2021-11-08 14:24:11 -08:00
e7cfe387d6
Autocorrect `Stye/RedundantNext` and `Style/RedundantReturn`
2021-11-08 14:07:35 -08:00
7b437fbd2f
Remove `normalize` parameter from `expect_issue` ( #249 )
...
* Add `normalize` parameter to `expect_correction`
* Convert Style/IsAFilter spec
* Revert "Add `normalize` parameter to `expect_correction`"
This reverts commit 4b67e4b900
2021-11-06 15:15:19 +02:00
7cb0c15747
Merge pull request #248 from FnControlOption/autocorrect
...
Add autocorrect
2021-11-01 20:24:43 +01:00
c2aa2fedb6
Return `source` from `expect_issue`
2021-10-31 22:44:48 -07:00
470e41cb7b
Raise error if attempting to both explain issue and autocorrect
2021-10-31 22:23:14 -07:00
a40fdee33f
Revert "Add autocorrect checks to `ExplainFormatter`"
...
This reverts commit 1b6fe40a3b
2021-10-31 22:12:21 -07:00
3e1df339ae
Consistent parser options
2021-11-01 02:08:16 +02:00
61fc99e107
Inline the `do_combine` method
2021-10-27 11:19:15 -07:00
73e97ac42e
Avoid using iterators and throw-away heap allocations
2021-10-27 11:08:18 -07:00
b7bb282b99
Apply suggestions from code review
2021-10-27 10:08:36 -07:00
d51ef27d54
Add `remove_preceding`, `remove_leading`, `remove_trailing`
2021-10-26 22:22:22 -07:00
1b6fe40a3b
Add autocorrect checks to `ExplainFormatter`
2021-10-26 22:22:22 -07:00
8d3b76003e
Add autocorrect checks to Flycheck, JSON, and TODO formatters
2021-10-26 22:22:22 -07:00
749c53527e
Add documentation
2021-10-26 22:22:22 -07:00
437584f9db
Raise error if infinite correction loop
2021-10-26 22:22:22 -07:00
16608965f5
Allowed named arguments with `Rule::Base.issue_for`
2021-10-26 22:22:22 -07:00
3b11491cea
Add `insert_*` overloads that accept both location and end_location
2021-10-26 22:22:22 -07:00
e8c0f49cb8
Delete redundant alias `SourceLocation`
2021-10-26 22:22:22 -07:00
f87d99a83b
Add `Corrector` method overloads that accept `ASTNode`
2021-10-26 22:22:22 -07:00
1d5f554e88
Apply suggestions from code review
2021-10-26 12:06:24 -07:00
f39a7a4cd4
Re-run autocorrect until all correctable issues have been corrected
2021-10-25 15:09:44 -07:00
573881cb8a
Autocorrect `Layout/TrailingBlankLines` partially
2021-10-25 12:38:29 -07:00
e5fb0526e0
Autocorrect `Style/LargeNumbers`
2021-10-25 12:38:29 -07:00
99e7ccd23b
Add `--autocorrect` CLI option
2021-10-25 12:38:29 -07:00
d3d3ccd7e3
Add `expect_correction` and `expect_no_corrections`
2021-10-25 12:38:29 -07:00
c1b4add094
Add `Source::Corrector` and `Source::Rewriter`
2021-10-25 12:38:29 -07:00
9f0b9a709e
Allow named replacements in expect_issue
2021-10-23 01:37:24 -07:00
3d432fdee8
Add expect_issue and expect_no_issues spec helpers ( #245 )
2021-10-22 19:54:39 +02:00
48b15b9bf8
Add Lint/AmbiguousAssignment rule ( #244 )
2021-10-19 11:44:41 +02:00
43dea0e49d
Fix typos throughout the codebase
2021-07-03 14:15:23 +02:00
c49c69ed9f
Early return in CountVisitor if macro node
...
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
2021-06-06 04:12:56 +10:00
0ea6238dc6
Count an exhaustive `case`'s complexity as 1
2021-06-05 22:31:58 +10:00
a64f48b543
ShadowingOuterLocalVar while it is not in macro
...
closes #224
2021-04-18 20:55:10 +03:00
9e2d4f1856
Disable performance rules for spec files
...
closes #220
2021-04-18 09:39:55 +03:00
788e0a3fad
Enable MapInsteadOfBlock rule again
2021-04-12 06:23:03 +02:00
2694a0c865
Remove “join” from the list of trigger methods
2021-04-12 06:22:54 +02:00
58d7775d65
Merge branch 'master' into develop
2021-04-04 21:08:02 +03:00
8d21733b10
Skip macro code in Style/IsAFilter rule
2021-04-04 11:19:45 +02:00
0881b861d7
Disable MapInsteadOfBlock by default
...
refs #208
2021-03-29 09:15:18 +03:00
04ba9cd57a
Change Style/VerboseBlock - ExcludeOperators - setting default ( #218 )
2021-03-24 21:16:51 +01:00
13605afe4a
Do not report IsAFilter if there is a block with multiple args
2021-03-23 20:57:50 +02:00
ad405e09b0
Merge branch 'master' into develop
2021-03-08 11:09:32 +02:00
56110b3883
Default to exclude_multiple_line_blocks in Style/VerboseBlock rule
2021-03-03 00:31:53 +01:00
8f308e73e5
Add ~ as the prefix operator
2021-03-02 12:40:46 +01:00
3a1ee7fa21
Correct yml examples
2021-02-11 11:01:30 +02:00
694c41650c
Remove redundant check and add a few more test cases
2021-02-05 01:23:29 +01:00
a9d1b17deb
Support named arguments in VerboseBlock#node_to_s
2021-02-05 01:23:29 +01:00
16743a756c
Add ExcludePrefixOperators option to Style/VerboseBlock rule
2021-02-04 21:59:23 +01:00
eed094b928
Fix couple of edge-cases in VerboseBlock rule
2021-02-04 21:59:23 +01:00
5faf8da81c
Split VerboseBlock#test method into a smaller pieces
2021-02-04 21:59:23 +01:00
4b7f3ba6ee
Add MaxLineLength option to Style/VerboseBlock rule
2021-02-04 21:59:22 +01:00
a53d44617d
Fix newly found issues
2021-02-04 21:59:22 +01:00
0739fad670
Add Style/VerboseBlock rule
2021-02-04 21:59:22 +01:00
99da6b6916
Merge remote-tracking branch 'origin/master' into master-into-develop
2021-02-03 22:45:35 +01:00
f8c22a6e77
Utilize Source#spec?
2021-02-03 17:25:46 +02:00
ecad80a96b
NewRule: SpecFocus
...
closes #172
2021-02-03 17:10:07 +02:00
51b0a07e81
Avoid exponential recursion while finding variable references in scopes ( #203 )
...
* Avoid exponential recursion while finding variable references in scopes
* Adjust source example in test
2021-01-31 16:40:44 +02:00
fac8072ec1
Merge pull request #197 from crystal-ameba/feature/any-instead-of-empty
...
Add Performance/AnyInsteadOfEmpty rule
2021-01-28 10:28:30 +01:00
7b3c814914
Fix newly found issues
2021-01-28 01:03:48 +01:00
d71091a40c
Add Performance/AnyInsteadOfEmpty rule
2021-01-28 01:03:48 +01:00
95d340c3ad
Add Style/IsAFilter rule
2021-01-28 00:58:06 +01:00
ea98554191
Add support for showing end location marker ( #200 )
...
* Add support for showing end location marker
* Cleanup Reportable method definitions
There’s no need for double splats, since they mess up method resolution, and obscure the actual - single (!) - argument - `status`, so… be gone
Also, all of the helpers return the constructed `Issue` like a behaving good methods.
* Refactor Util#affected_code
* Increase max length of trimmed lines to 120 characters
* Refactor Issue to use enum instead of a symbol for #status
* Optimize Reportable#valid?
* Add spec coverage for newly added Util methods
* Refactor DotFormatter a bit
Make text format moar in line with Crystal spec runner.
* Update README.md
2021-01-26 08:38:19 +02:00
6acb8ad2eb
ChainedCallsWithNoBang -> ChainedCallWithNoBang
2021-01-22 17:24:45 +01:00
8babeea80f
Add `repeated_combinations` and `repeated_permutations`
2021-01-22 12:21:14 +01:00
a219a73258
Remove rotate from the list of call_names
...
In some cases it returns `self` and not a copy.
2021-01-22 12:20:50 +01:00
d3b952f58a
Add Performance/ChainedCallsWithNoBang rule
2021-01-21 12:47:10 +01:00
7aa7efd4bd
Do not report if variable is assigned and referenced in MacroFor/MacroIf/MacroExpression
...
closes #194
2021-01-20 13:14:42 +02:00
ad8f570a04
Change Rule to class
2021-01-19 22:17:17 +01:00
ddaa58f475
Merge pull request #192 from crystal-ameba/feature/flatten-after-map-rule
...
Add Performance/FlattenAfterMap rule
2021-01-19 22:16:10 +01:00
4958fa2315
Merge pull request #184 from mamantoha/fix-crystal-nightly
...
fix Crystal nightly
2021-01-19 13:18:18 +02:00
23b4b4c4f0
Add Performance/FlattenAfterMap rule
2021-01-18 18:04:54 +01:00
b7286dc673
Add Performance/CompactAfterMap rule
2021-01-18 18:04:12 +01:00
d2fa75280f
Extend JoinAfterMap to check also calls to `sum/product` and rename it to MapInsteadOfBlock ( #190 )
2021-01-18 17:42:50 +02:00
e9ec91654c
New Rule: Lint/DuplicatedRequire
...
closes https://github.com/crystal-ameba/ameba/issues/176
2021-01-17 22:32:24 +02:00
6898aa8976
Fix issue #187 ( #189 )
...
* Avoid using `tap` with structs
* Remove extraneous blank lines
* Readability
2021-01-17 22:31:53 +02:00
928a260d51
Remove extraneous blank lines
2021-01-17 18:45:14 +01:00
af5d825015
Followup to #185
2021-01-17 18:45:14 +01:00
fd4b2f309c
Don’t allocate the array on every call
2021-01-17 18:05:08 +01:00
5e58a60ade
Move constant definitions after `properties` call
2021-01-17 17:39:32 +01:00
a892cd43b0
Add Performance/JoinAfterMap rule
2021-01-17 16:57:15 +01:00
06852c490b
Followup to #185
2021-01-17 13:25:50 +01:00
1a091c1f1a
Optimize rules ( #185 )
...
* Replace pointless interpolations with actual values
* Rules optimizations
* Stylistic refactors
* Remove extraneous blank lines
* Remove some instances of .not_nil! usage
2021-01-17 14:16:04 +02:00
270a003df6
Merge pull request #184 from mamantoha/fix-crystal-nightly
...
fix Crystal nightly
2021-01-16 19:53:48 +01:00
6f0f8352f9
fix Crystal nightly
2021-01-16 20:42:27 +02:00
c4d34d74d8
Add support for showing code context lines ( #181 )
...
* Add support for showing code context lines
* Show context lines only in ExplainFormatter
* Add spec coverage for context_lines option
2021-01-12 17:20:43 +02:00
19c370aee0
Misc refactors ( #180 )
...
* Optimize Severity#symbol
* Remove empty else branches
* Optimize map+compact/flatten calls
* Misc stylistic refactors
2021-01-11 20:13:58 +02:00
2eff832669
Add --rules switch to the CLI
2021-01-09 21:01:04 +01:00
de3f16a9dc
Disable Lint/EmptyExpression rule
...
closes #169
2020-10-23 19:21:39 +03:00
44290a6a5d
Handle case when compiler reports incorrect node location
...
fixes #168
2020-10-23 10:41:17 +03:00
f8d57345d4
Merge branch 'develop'
2020-08-26 22:46:03 +03:00
b5bd76dfa8
Useless Assign: ignore variables with '_' prefix
...
closes #164
2020-08-20 21:15:58 +03:00
d650ca5477
Incorrectly reporting shadowingOuterLocalVar within macro included
...
closes #161
2020-07-15 10:18:12 +03:00
7f501a1df5
RedundantStringCoercion: do not report to_s with named args
...
closes #160
2020-06-24 09:26:03 +03:00
3448de30da
Enable rules which were disabled during bugfix release
2020-06-19 21:41:02 +03:00
c3260c1740
Move to YAML::Serializable
2020-06-15 14:29:49 +03:00
25fd493145
Fix compatiblity with crystal nightly
2020-05-14 11:43:13 +03:00
bdeb6e3391
Feature/Layout trailing lines, final newline checkup ( #152 )
2020-05-05 16:52:24 +03:00
f1adf14527
Handle duplicated files on GlobUtils ( #151 )
...
* Handle duplicated files on GlobUtils
* Update src/ameba/glob_utils.cr
Co-Authored-By: George Dietrich <yomoejoe@gmail.com>
Co-authored-by: George Dietrich <yomoejoe@gmail.com>
2020-04-19 11:52:15 +03:00
b215b34060
Disable new rules before the coming bugfix release
2020-04-13 10:11:15 +03:00
478da94c20
Allow constants to be in PascalCase (i.e. Log, SuperConstant)
...
closes #148
2020-04-13 09:38:05 +03:00
1a25583036
Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict ( #146 )
2020-04-11 09:55:41 +03:00
458c492730
Do not report shadowing outer local var is var is declared below the
...
shadowed var
closes #144
2020-04-10 10:44:42 +03:00
99c65b5a28
New rule: Lint/BadDirective ( #143 )
...
* New rule: Lint/BadDirective
* Address PR feedback
2020-04-06 15:10:34 +03:00
db6b54e63c
New rule: Style/IsANil
2020-03-29 19:45:13 +03:00
02f4afaa64
Correct doc typo
2020-03-27 23:17:36 +02:00
04497feeed
Lint/LiteralInInterpolation: properly report node position
2020-03-27 19:44:04 +02:00
6259e26457
Comply exhaustive case check
2020-03-27 09:25:07 -03:00
9c6bc2a376
Merge pull request #137 from crystal-ameba/feat/redundant-string-coercion
...
New rule: Lint/RedundantStringCoercion
2020-03-26 23:55:23 +02:00
59bc021e57
Do not report if Object#to_s is called without receiver
2020-03-26 23:51:54 +02:00
ff1669ebe8
New rule: Lint/RedundantStringCoercion
2020-03-26 16:26:27 +02:00
98bc6bb76a
Improve Lint/SharedVarInFiber rule description
2020-03-26 15:18:44 +02:00
f27842e111
Correct doc typos
2020-03-26 10:35:27 +02:00
a6958ab455
New rule: EmptyLoop
2020-03-26 10:27:00 +02:00
1a0468c653
Use NodeVisitor by default and remove the boilerplace code
2020-03-25 18:21:07 +02:00
4f185db0a2
New rule: SharedVarInSpawn
...
closes #132
2020-03-25 17:52:20 +02:00
0002c36fae
RedundantNext params
2020-03-24 18:27:49 +02:00
a5dd07e9e4
New rule: RedundantNext
...
closes #131
2020-03-24 18:06:01 +02:00
946ec67fae
Include binary op node to redundant return
2020-03-22 20:12:24 +02:00
9a6c4e52f4
Document Globs/Excluded
2020-03-22 15:08:04 +02:00
2303bd82ae
Ability to excluded globally
2020-03-22 15:05:47 +02:00
bffc46c545
Ability to configure globs
2020-03-22 15:05:47 +02:00
aff723b682
Incorrectly reporting shadowingOuterLocalVar within macro included
...
closes #129
2020-02-15 20:49:47 +02:00
43b566a852
Crystal 0.33 formatting
2020-02-15 17:33:20 +02:00
cc3200f3cf
Reformat sources
2020-01-11 23:58:06 +02:00
74dfa0b934
Lint/UselessAssign: ignore transformed assignemnts by the compiler
...
closes #127
2020-01-11 23:51:28 +02:00
6b56c87e78
Shadowing via short instance variable syntax
...
closes #122
2019-11-11 15:51:09 +02:00
fde321f7e6
New rule: RedundantWithObject ( #121 )
2019-11-10 09:47:30 +02:00
b6cc454039
New rule: RedundantWithIndex ( #120 )
2019-11-10 09:29:17 +02:00
07e72b7bf9
Lint in parallel ( #118 )
...
* Lint in parallel
* Synced output for dot/flycheck formatters
* Re-raise exceptions raised in fibers
* Add readme instructions
2019-11-09 19:31:41 +02:00
8d00d54012
Fix typos
2019-10-28 00:02:31 +02:00
4ae0195628
Avoid duplicated sections in a generated TODO file (additional fix)
2019-10-27 22:56:53 +02:00
111596541b
Avoid duplicated sections in a generated TODO file
2019-10-27 22:15:04 +02:00
19d9223ec1
Properly detect if scope references a variable
2019-10-27 21:53:07 +02:00
904b5beec2
Lint/UnusedArgument: fails to recognized used argument inside macro
...
closes #117
2019-10-27 21:32:55 +02:00
677c75716f
Typeof scope
2019-10-27 21:22:33 +02:00
2704a0d8b1
Do not generate todo file there are no issues
2019-10-27 17:49:30 +02:00
d418fb0ef7
Surround __DIR__ with quotes to handle paths with spaces ( #114 )
2019-09-14 18:31:55 +03:00
504f537208
Parse docs
2019-07-22 16:23:59 +03:00
9065a5f414
Remove unneeded code to support crystal 0.24.2
2019-07-19 23:51:30 +03:00
b868d88a85
CyclomaticCompexity: report onle def name
2019-07-12 23:33:08 +03:00
54706192d2
Default cmd args
2019-07-06 22:42:50 +03:00
ffa5dc9b4c
Crystal 0.29 fixes ( #109 )
...
* Fixes vs crystal head
* Use crystal nightly
* Remove trailing ? from local variable
* Do not use ? in the lhs
ref https://github.com/crystal-lang/crystal/issues/6685#issuecomment-419758587
* Upgrade to crystal 0.29.0 (warnings free) (#108 )
* Remove trailing ? from local variable (take 2)
* Fix Time.now deprecation warnings
* Remove Crystal nightly
2019-06-06 19:10:26 +03:00
037d1dde74
Performance/FirstLastAfterFilter: ignore .first/.last with args
...
closes #104
2019-06-03 18:25:48 +03:00
de587f500a
Rename Severity::Refactoring -> Severity::Convention
...
it preserves clang format
2019-05-11 21:17:49 +03:00
94e1d4567a
Properly report performance rules in macros
...
closes #102
2019-05-05 18:05:08 +03:00
2ddf26b8c3
Correct doc example
2019-04-29 16:27:12 +03:00
ca5e894e0b
Rename Severity.from_name to Severity.parse
2019-04-26 18:15:36 +03:00
af395a3c13
Do not report if disabled rules exist
...
closes #101
2019-04-25 08:47:37 +03:00
f1fe34f8b9
Use Enum.parse
2019-04-14 19:31:50 +03:00
117e100855
Add severity to formatters
2019-04-14 16:45:31 +03:00
575fe07879
Change the level of failure in the runner
2019-04-14 15:57:48 +03:00
f6a57f9272
Set default severities
2019-04-14 12:15:38 +03:00
0be42f94db
Convertable severity
2019-04-13 21:16:59 +03:00
c95ea297bd
Stop calculating cyclomatic complexity for methods which have Macro conditions ( #99 )
2019-03-31 20:27:20 +03:00
a059ade305
Remove one-line methods
...
Unnecessary level of abstraction
2019-03-23 19:25:16 +02:00
3a71b86193
Properly report literals ( #96 )
2019-03-23 19:20:32 +02:00
d2b36047ef
Correct variable name rule doc
2019-02-24 20:04:35 +02:00
3dabfb8dec
Correct json formatter output example
2019-02-24 20:04:04 +02:00
e8a68a80d5
Fix several misspellings ( #94 )
2019-02-23 07:06:28 +02:00
e850bff60f
Hk cyclomatic complexity ( #92 )
...
* Proof of concept for cyclomatic complexity
* Enable configurability of rule
* Use the same nodes to increment the complexity as rubocop
* Fix typo in test description
* Properly indent code and simplify macro
* Move metric into metrics
* Cover a violation supressed by increased threshold
* Extract visitor into its own file
* Document cyclomatic complexity rule and visitor
* Refactor specs to use a macro
* Indent code inside macro
* Replace array with tuple for string formatting.
`Tuple` is stack based, whereas `Array` is allocated on the heap increasing GC pressure.
* Fix formatting
* Enable cyclomatic complexity rule by default
2019-02-16 21:03:44 +02:00
f294bb6a68
Improve explain output
2019-01-13 22:14:25 +02:00
3c5e3cdef4
Exclude globs as arguments
...
Examples:
$ ameba path/to/shard/*.cr !path/to/shard/lib
$ ameba . !lib
2019-01-13 10:48:46 +02:00
866af184f1
Redundant return ( #87 )
2018-12-30 09:04:59 +02:00
c91da1aa08
Let ameba explain the issue at the specified location ( #86 )
2018-12-27 23:34:10 +02:00
4e19571fb3
Correct VariableNames doc example
2018-12-26 10:57:06 +02:00
32ac199162
Correct trailing blank line position
2018-12-24 00:44:15 +02:00
1d96319506
Remove unneded argument
2018-12-15 22:16:40 +02:00
60ce034f1b
UnusedArgument: fix crystal upgrade regression
2018-12-12 22:21:33 +02:00
f671d6f857
Show affected code while using a default formatter
2018-12-12 21:45:00 +02:00
148044f479
Add description to syntax special rule
2018-12-09 00:12:14 +02:00
20938da89a
Dynamically load rule documentation
2018-12-08 22:52:32 +02:00
f8dab3bc34
MethodNames: correct reported location/end_location
2018-11-25 00:56:21 +02:00
e951c0772a
ConstantNames: correct reported end_location
2018-11-25 00:37:46 +02:00
9885457227
Track issue.end_location properly
2018-11-24 19:38:13 +02:00
ad2c6bad0e
Use utility method to check if node is a loop
2018-11-22 11:52:00 +02:00
0fd5890738
Extend UnreachableCode rule: handle control flow ( #83 )
2018-11-22 10:38:32 +02:00
eca0f3f350
Handle raise, exit, abort in unreachable code
2018-11-11 20:33:48 +02:00
67d76116f7
Basic implementation of UnreachableCode rule
2018-11-05 21:39:27 +02:00
12aa48c98f
Fix Style/RedundantBegin: begin-end in a proc literal
...
closes #80
2018-09-22 21:58:38 +03:00
cb5f802012
Correctly process record declaration at a top level ( #78 )
2018-09-07 00:47:02 +03:00
18ac04d992
Generate UTC time in todo
2018-09-06 18:48:36 +03:00
fd78d17c40
New rule: Performance/FirstLastAfterFilter ( #76 )
2018-09-06 17:59:11 +03:00
a1b34eb7be
New rule: Performance/AnyAfterFilter
2018-09-03 22:55:10 +03:00
068733a9d3
Correct yaml configuration examples in docs
2018-09-03 22:53:11 +03:00
Sijawusz Pur Rahnama
Vitalii Elenhaupt
Anton Maminov
fn ⌃ ⌥
Caspian Baska
Caspian Baska
Stephen Dolan
Vitalii Elenhaupt
Vladislav Trotsenko
Matheus Richard
Brian J. Cardiff
Hannes Käufler