mirror of
https://gitea.invidious.io/iv-org/shard-ameba.git
synced 2024-08-15 00:53:29 +00:00
Rename Severity.from_name to Severity.parse
This commit is contained in:
parent
af395a3c13
commit
ca5e894e0b
3 changed files with 12 additions and 12 deletions
|
@ -22,22 +22,22 @@ module Ameba
|
|||
end
|
||||
end
|
||||
|
||||
describe ".from_name" do
|
||||
describe ".parse" do
|
||||
it "creates error severity by name" do
|
||||
Severity.from_name("Error").should eq Severity::Error
|
||||
Severity.parse("Error").should eq Severity::Error
|
||||
end
|
||||
|
||||
it "creates warning severity by name" do
|
||||
Severity.from_name("Warning").should eq Severity::Warning
|
||||
Severity.parse("Warning").should eq Severity::Warning
|
||||
end
|
||||
|
||||
it "creates refactoring severity by name" do
|
||||
Severity.from_name("Refactoring").should eq Severity::Refactoring
|
||||
Severity.parse("Refactoring").should eq Severity::Refactoring
|
||||
end
|
||||
|
||||
it "raises when name is incorrect" do
|
||||
expect_raises(Exception, "Incorrect severity name BadName. Try one of [Error, Warning, Refactoring]") do
|
||||
Severity.from_name("BadName")
|
||||
Severity.parse("BadName")
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -85,7 +85,7 @@ module Ameba::Cli
|
|||
end
|
||||
|
||||
parser.on("--fail-level SEVERITY", "Change the level of failure to exit. Defaults to Refactoring") do |level|
|
||||
opts.fail_level = Severity.from_name(level)
|
||||
opts.fail_level = Severity.parse(level)
|
||||
end
|
||||
|
||||
parser.on("-e", "--explain PATH:line:column",
|
||||
|
|
|
@ -16,14 +16,14 @@ module Ameba
|
|||
# Creates Severity by the name.
|
||||
#
|
||||
# ```
|
||||
# Severity.from_name('refactoring') # => Severity::Refactoring
|
||||
# Severity.from_name('foo-bar') # => Exception: Incorrect severity name..
|
||||
# Severity.parse('refactoring') # => Severity::Refactoring
|
||||
# Severity.parse('foo-bar') # => Exception: Incorrect severity name
|
||||
# ```
|
||||
#
|
||||
def self.from_name(name : String)
|
||||
parse(name)
|
||||
def self.parse(name : String)
|
||||
super name
|
||||
rescue ArgumentError
|
||||
raise "Incorrect severity name #{name}. Try one of #{Severity.values}"
|
||||
raise "Incorrect severity name #{name}. Try one of #{values}"
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -35,7 +35,7 @@ module Ameba
|
|||
end
|
||||
|
||||
case value = node.value
|
||||
when String then Severity.from_name(value)
|
||||
when String then Severity.parse(value)
|
||||
when Nil then nil
|
||||
else
|
||||
raise "Incorrect severity: #{value}"
|
||||
|
|
Loading…
Reference in a new issue