Sijawusz Pur Rahnama
82e0e53080
Revert "Fix Performance/ExcessiveAllocations to exclude each calls without a block"
...
This reverts commit 29e29b8e1d
2023-11-17 19:48:41 +01:00
Sijawusz Pur Rahnama
10b577d23a
Use square brackets for %w and %i array literals
2023-11-17 17:34:39 +01:00
Sijawusz Pur Rahnama
327ed546b9
Apply suggestions from code review
...
Co-authored-by: Vitalii Elenhaupt <3624712+veelenga@users.noreply.github.com>
2023-07-10 16:09:01 +02:00
Sijawusz Pur Rahnama
ddff8d226b
Add Performance/MinMaxAfterMap rule
2023-07-10 15:46:17 +02:00
Sijawusz Pur Rahnama
29e29b8e1d
Fix Performance/ExcessiveAllocations to exclude each calls without a block
2023-06-30 21:44:47 +02:00
Sijawusz Pur Rahnama
abe5237802
Add Performance/ExcessiveAllocations rule
2023-06-30 15:17:40 +02:00
Sijawusz Pur Rahnama
d31e41b8a7
Fix specs on Crystal nightly (soon to be v1.7.0)
2023-01-10 13:10:05 +01:00
Sijawusz Pur Rahnama
6f0b6ffcd0
Remove buggy auto-correction from Performance/AnyInsteadOfEmpty rule
2023-01-04 02:40:07 +01:00
Sijawusz Pur Rahnama
9926f0295a
Remove most of the obsolete specs
2022-12-21 21:13:22 +01:00
Sijawusz Pur Rahnama
70078cf77f
Synchronize properties context names in rules’ specs
2022-12-20 03:25:10 +01:00
Sijawusz Pur Rahnama
8112dddc8f
Specs cleanup
2022-12-20 03:25:06 +01:00
Sijawusz Pur Rahnama
fbd72a5171
Fix regression in AnyInsteadOfEmpty rule
2022-04-22 00:58:37 +02:00
Sijawusz Pur Rahnama
48d0089d23
Add some whitespaces for readability
2022-04-04 22:17:41 +02:00
Sijawusz Pur Rahnama
306bc34019
Use issue expectation helpers in Performance::FirstLastAfterFilter rule spec
2022-04-04 22:17:13 +02:00
Sijawusz Pur Rahnama
119e20d5e5
Use issue expectation helpers in Performance::SizeAfterFilter rule spec
2022-04-04 22:17:02 +02:00
Sijawusz Pur Rahnama
e0867c04b0
Use issue expectation helpers in Performance::MapInsteadOfBlock rule spec
2022-04-04 22:16:48 +02:00
Sijawusz Pur Rahnama
6f30881ae6
Use issue expectation helpers in Performance::FlattenAfterMap rule spec
2022-04-04 22:16:37 +02:00
Sijawusz Pur Rahnama
931dc3d2dc
Use issue expectation helpers in Performance::CompactAfterMap rule spec
2022-04-04 22:16:21 +02:00
fn ⌃ ⌥
63a6c73dc0
Autocorrect various rules ( #253 )
2021-11-16 22:30:33 +01:00
fn ⌃ ⌥
7b437fbd2f
Remove normalize parameter from expect_issue ( #249 )
...
* Add `normalize` parameter to `expect_correction`
* Convert Style/IsAFilter spec
* Revert "Add `normalize` parameter to `expect_correction`"
This reverts commit 4b67e4b900
2021-11-06 15:15:19 +02:00
fn ⌃ ⌥
3d432fdee8
Add expect_issue and expect_no_issues spec helpers ( #245 )
2021-10-22 19:54:39 +02:00
Vitalii Elenhaupt
9e2d4f1856
Disable performance rules for spec files
...
closes #220
2021-04-18 09:39:55 +03:00
Sijawusz Pur Rahnama
2694a0c865
Remove “join” from the list of trigger methods
2021-04-12 06:22:54 +02:00
Sijawusz Pur Rahnama
d71091a40c
Add Performance/AnyInsteadOfEmpty rule
2021-01-28 01:03:48 +01:00
Sijawusz Pur Rahnama
6acb8ad2eb
ChainedCallsWithNoBang -> ChainedCallWithNoBang
2021-01-22 17:24:45 +01:00
Sijawusz Pur Rahnama
d3b952f58a
Add Performance/ChainedCallsWithNoBang rule
2021-01-21 12:47:10 +01:00
Sijawusz Pur Rahnama
ddaa58f475
Merge pull request #192 from crystal-ameba/feature/flatten-after-map-rule
...
Add Performance/FlattenAfterMap rule
2021-01-19 22:16:10 +01:00
Sijawusz Pur Rahnama
23b4b4c4f0
Add Performance/FlattenAfterMap rule
2021-01-18 18:04:54 +01:00
Sijawusz Pur Rahnama
b7286dc673
Add Performance/CompactAfterMap rule
2021-01-18 18:04:12 +01:00
Sijawusz Pur Rahnama
d2fa75280f
Extend JoinAfterMap to check also calls to sum/product and rename it to MapInsteadOfBlock ( #190 )
2021-01-18 17:42:50 +02:00
Sijawusz Pur Rahnama
a892cd43b0
Add Performance/JoinAfterMap rule
2021-01-17 16:57:15 +01:00
Vitalii Elenhaupt
ffa5dc9b4c
Crystal 0.29 fixes ( #109 )
...
* Fixes vs crystal head
* Use crystal nightly
* Remove trailing ? from local variable
* Do not use ? in the lhs
ref https://github.com/crystal-lang/crystal/issues/6685#issuecomment-419758587
* Upgrade to crystal 0.29.0 (warnings free) (#108 )
* Remove trailing ? from local variable (take 2)
* Fix Time.now deprecation warnings
* Remove Crystal nightly
2019-06-06 19:10:26 +03:00
Vitalii Elenhaupt
037d1dde74
Performance/FirstLastAfterFilter: ignore .first/.last with args
...
closes #104
2019-06-03 18:25:48 +03:00
Vitalii Elenhaupt
94e1d4567a
Properly report performance rules in macros
...
closes #102
2019-05-05 18:05:08 +03:00
Vitalii Elenhaupt
d7b0e10d1e
Normalize sources for tests
2018-09-07 15:07:03 +03:00
V. Elenhaupt
fd78d17c40
New rule: Performance/FirstLastAfterFilter ( #76 )
2018-09-06 17:59:11 +03:00
Vitalii Elenhaupt
a1b34eb7be
New rule: Performance/AnyAfterFilter
2018-09-03 22:55:10 +03:00
Vitalii Elenhaupt
790b519653
Performance/Count -> Performance/SizeAfterFilter
2018-09-03 22:44:30 +03:00
Vitalii Elenhaupt
799c0fd5e1
Correct location name of reported issue
2018-09-03 13:26:19 +03:00
Vitalii Elenhaupt
446f557c23
New rule: Performance/Count
2018-09-03 01:07:34 +03:00
