cadence suggested changes for cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone.

cadence commented on pull request cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

12px please, it doesn't need to be tiny.

cadence commented on pull request cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

This needs to be a lighter red for better contrast. Try #ff6561 I guess?

cadence commented on pull request cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

This link doesn't go anywhere. I assume the site is yet to be created?

cadence commented on pull request cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

style: indentation 2 spaces, line break above selectors.

cadence commented on pull request cadence/Carbon#20 2020-11-01 09:16:07 +00:00
WIP: Some visual improvements for login

Please create a class .homeserver-question and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.

cadence commented on pull request cadence/Carbon#24 2020-10-30 23:49:15 +00:00
Rich message rendering

1 MB bundle size is kind of ridiculous. We could simply not highlight code blocks, or we could maybe inline async import the module on demand when we actually need to do highlighting, so it's out of…

cadence commented on issue cadence/Carbon#18 2020-10-30 11:51:06 +00:00
[Discussion] New user UX

That's a really good prompt message.

I'd like to use a circled ? icon next to the "homeserver" label that responds to clicking, rather than hovering, or requiring the input box to be empty. Those…

cadence commented on pull request cadence/Carbon#24 2020-10-29 07:46:58 +00:00
Rich message rendering

Just going through a visual analysis of your code, I'll test it and give a full review in the future.

cadence commented on pull request cadence/Carbon#24 2020-10-29 07:46:58 +00:00
Rich message rendering

Not sure how I feel about a function that creates classes. Can we inherit from a base class instead?

cadence commented on pull request cadence/Carbon#24 2020-10-29 07:46:58 +00:00
Rich message rendering

The original idea here was that we'd have a predicate for things like whether the method can be displayed as a message group, whether it should show a timestamp, or whatever other things could affect the display based on the class. I haven't actually put this method to any use yet.

cadence commented on pull request cadence/Carbon#24 2020-10-29 07:46:58 +00:00
Rich message rendering

style: can we put spaces after // ?

cadence commented on pull request cadence/Carbon#24 2020-10-29 07:46:58 +00:00
Rich message rendering

Again here. I think a better way would be to have a base class like MembershipEvent, and then for each kind of membership we subclass it and only implement the canRender method on each.

cadence pushed to princess at cadence/Carbon 2020-10-29 04:32:18 +00:00
ff196a64bb Improve message sender rendering
a4c7f29ec9 Emacs files to gitignore
5bfe98bdf4 Stop scrollback at top of timeline
Compare 3 commits »
cadence pushed to princess at cadence/Carbon 2020-10-26 10:57:05 +00:00
f4b368ea3e Better message line breaking
cadence pushed to princess at cadence/Carbon 2020-10-26 10:36:44 +00:00
6da9f41519 Merge pull request 'Add scrollback' (#22) from scrollback into princess
df47c8a88a Style load more; fix message group order
c9dffc9d4a Wait for events to load before saving scroll position
6227f6fa84 Add scrollback
Compare 4 commits »
cadence merged pull request cadence/Carbon#22 2020-10-26 10:36:44 +00:00
Add scrollback
cadence pushed to scrollback at cadence/Carbon 2020-10-26 10:35:57 +00:00
df47c8a88a Style load more; fix message group order
cadence pushed to princess at cadence/Carbon 2020-10-26 09:33:52 +00:00
5ab182e615 Merge pull request 'Bundle with browserify' (#19) from browserify into princess
08a0990bc8 Add back jshint; format
51905ab3f2 add browserify
Compare 3 commits »
cadence merged pull request cadence/Carbon#19 2020-10-26 09:33:52 +00:00
Bundle with browserify