cadence/breezewiki
2
4
Fork 4
Code Issues Pull requests 1 Releases Wiki Activity

Deduplicate the wiki name regex #4

Merged
cadence merged 1 commit from blankie/breezewiki:wikiname-regex into main 2022-10-04 08:19:06 +00:00
Conversation 1 Commits 1 Files changed 3 +12 -7
blankie commented 2022-10-02 09:49:46 +00:00
Contributor
Copy link

wikiname-regex is in url-utils.rkt instead of application-globals.rkt since application-globals.rkt requires url-utils.rkt and url-utils.rkt would require application-globals.rkt, causing a cycle.

`wikiname-regex` is in url-utils.rkt instead of application-globals.rkt since application-globals.rkt requires url-utils.rkt and url-utils.rkt would require application-globals.rkt, causing a cycle.
blankie added 1 commit 2022-10-02 09:49:46 +00:00
cadence merged commit 57e700cef5 into main 2022-10-04 08:19:06 +00:00
cadence commented 2022-10-04 08:21:40 +00:00
Owner
Copy link

Tests pass, looks great! I changed wikiname-regex to px-wikiname in 79f04565 because I personally find prefix notation more natural to represent the kind/type of something.

Tests pass, looks great! I changed `wikiname-regex` to `px-wikiname` in 79f04565 because I personally find prefix notation more natural to represent the kind/type of something.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cadence/breezewiki#4
No description provided.
Delete branch "blankie/breezewiki:wikiname-regex"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?