cadence
/
breezewiki
3
4
Fork 4
Code Issues Pull Requests 3 Releases Wiki Activity

Fix wikis with numbers in the name #3

Merged
cadence merged 1 commits from blankie/breezewiki:number-title into main 2022-10-02 08:23:22 +00:00
Conversation 2 Commits 1 Files Changed 3 +6 -6
blankie commented 2022-10-02 03:54:10 +00:00
Contributor
Copy Link

fe60579a53/extensions/wikia/CreateNewWiki/CreateWikiChecks.php (L112)
Fixes https://lists.sr.ht/~cadence/breezewiki-discuss/%3C814ef2a8-2e91-dcaf-f0c1-805cc1478198%40riseup.net%3E

https://github.com/Wikia/app/blob/fe60579a53f16816d65dad1644363160a63206a6/extensions/wikia/CreateNewWiki/CreateWikiChecks.php#L112 Fixes https://lists.sr.ht/~cadence/breezewiki-discuss/%3C814ef2a8-2e91-dcaf-f0c1-805cc1478198%40riseup.net%3E
blankie added 1 commit 2022-10-02 03:54:11 +00:00
cadence merged commit 2a56107e97 into main 2022-10-02 08:23:22 +00:00
cadence commented 2022-10-02 08:26:48 +00:00
Owner
Copy Link

Thank you so much, and extra credit for searching out the Wikia legacy source for their wiki naming rules.

Do you think we should put this [a-zA-Z0-9-]{3,50} regular expression fragment somewhere, since it is referred to several times? For example, in Bibliogram, I put some regular expressions here: https://git.sr.ht/~cadence/bibliogram/tree/master/item/src/lib/constants.js#L244

I think application-globals would be a good spot to put frequently used regular expressions.

Thank you so much, and extra credit for searching out the Wikia legacy source for their wiki naming rules. Do you think we should put this `[a-zA-Z0-9-]{3,50}` regular expression fragment somewhere, since it is referred to several times? For example, in Bibliogram, I put some regular expressions here: https://git.sr.ht/~cadence/bibliogram/tree/master/item/src/lib/constants.js#L244 I think application-globals would be a good spot to put frequently used regular expressions.
blankie commented 2022-10-02 08:48:35 +00:00
Author
Contributor
Copy Link

Sure

Sure
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cadence/breezewiki#3
No description provided.
Delete Branch "blankie/breezewiki:number-title"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?