GeyserMC/Geyser
GeyserMC
/
Geyser
mirror of https://github.com/GeyserMC/Geyser.git
4
4
Fork 3
Code Issues 103 Projects Releases Wiki Activity

Remove unneeded retain

This commit is contained in:
SupremeMortal 2023-04-20 10:45:23 +01:00
parent 0f3d5c5859
commit eaaba44e05
No known key found for this signature in database
GPG Key ID: DDBB25F8EE4FA29A
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/main/java/org/geysermc/geyser/translator/protocol/java/level/JavaLevelChunkWithLightTranslator.java
View File

@ -312,8 +312,7 @@ public class JavaLevelChunkWithLightTranslator extends PacketTranslator<Clientbo
size += bedrockBlockEntities.size() * 64; // Conservative estimate of 64 bytes per tile entity size += bedrockBlockEntities.size() * 64; // Conservative estimate of 64 bytes per tile entity
// Allocate output buffer // Allocate output buffer
byteBuf = ByteBufAllocator.DEFAULT.buffer(size); byteBuf = ByteBufAllocator.DEFAULT.ioBuffer(size);
byteBuf.retain();
for (int i = 0; i < sectionCount; i++) { for (int i = 0; i < sectionCount; i++) {
GeyserChunkSection section = sections[i]; GeyserChunkSection section = sections[i];
if (section != null) { if (section != null) {
@ -348,6 +347,7 @@ public class JavaLevelChunkWithLightTranslator extends PacketTranslator<Clientbo
for (NbtMap blockEntity : bedrockBlockEntities) { for (NbtMap blockEntity : bedrockBlockEntities) {
nbtStream.writeTag(blockEntity); nbtStream.writeTag(blockEntity);
} }
byteBuf.retain();
} catch (IOException e) { } catch (IOException e) {
session.getGeyser().getLogger().error("IO error while encoding chunk", e); session.getGeyser().getLogger().error("IO error while encoding chunk", e);
return; return;
@ -362,7 +362,7 @@ public class JavaLevelChunkWithLightTranslator extends PacketTranslator<Clientbo
levelChunkPacket.setCachingEnabled(false); levelChunkPacket.setCachingEnabled(false);
levelChunkPacket.setChunkX(packet.getX()); levelChunkPacket.setChunkX(packet.getX());
levelChunkPacket.setChunkZ(packet.getZ()); levelChunkPacket.setChunkZ(packet.getZ());
levelChunkPacket.setData(byteBuf.retain()); levelChunkPacket.setData(byteBuf);
session.sendUpstreamPacket(levelChunkPacket); session.sendUpstreamPacket(levelChunkPacket);
if (!lecterns.isEmpty()) { if (!lecterns.isEmpty()) {