[fido] add a log notice to explain why ISO downloads are disabled

* Also fix an issue where Rufus doesn't report an error if 'fmifs.dll' can't be found (#1284)
* Also improve GitHub issue template to mention that Ctrl-L can also be used to access the log
This commit is contained in:
Pete Batard 2019-03-19 12:04:29 +00:00
parent 77027b40ec
commit 82bb497c1b
No known key found for this signature in database
GPG Key ID: 38E0CF5E69EDD671
6 changed files with 18 additions and 13 deletions

View File

@ -4,7 +4,7 @@ Checklist
---------
- [ ] I looked at https://github.com/pbatard/rufus/wiki/FAQ to see if my question has already been answered.
- [ ] I performed a search in the issue tracker for similar issues using keywords relevant to my problem, such as the error message I got from the log.
- [ ] I clicked the "Log" button in Rufus (last small blue button before _START_) and copy/pasted the log into the line that says `<FULL LOG>` below.
- [ ] I clicked the 'Log' button or pressed <kbd>Ctrl</kbd>-<kbd>L</kbd> in Rufus, and copy/pasted the log into the line that says `<FULL LOG>` below.
- [ ] The log I am copying is the FULL log, starting with the line `Rufus version: x.y.z` - I have NOT removed any part of it.
Additionally (if applicable):

View File

@ -1,12 +1,13 @@
o Version 3.5 (2019.03.??)
Add a feature to download official retail Windows 8.1 or Windows 10 ISOs
(Note: 'Check for updates' must also be enabled for the above to be active)
Add Windows To Go support for MCT generated Windows ISOs
Add a notice about the 'WppRecorder.sys' Microsoft bug for Windows 10 1809 ISOs
Add a notice about trying to format a drive larger than 2 TB in MBR mode
Add a notice about Legacy boot when trying to boot UEFI-only media in Legacy mode
Report the full PID and command line of detected blocking processes in the log
Report the full PID and command line of potentially blocking processes in the log
Fix a potential silent abort when the drive is in use
Fix 'Quick Format' option always being active
Fix 'Quick Format' option always being activated
Fix some unwanted file system changes occurring after an ISO had been selected
o Version 3.4 (2018.12.05)

View File

@ -720,8 +720,8 @@ static BOOL FormatDrive(DWORD DriveIndex)
// problems with tolower(). Make sure we restore the locale. For more details,
// see http://comments.gmane.org/gmane.comp.gnu.mingw.user/39300
locale = setlocale(LC_ALL, NULL);
PF_INIT_OR_OUT(FormatEx, Fmifs);
PF_INIT(EnableVolumeCompression, Fmifs);
PF_INIT_OR_OUT(FormatEx, fmifs);
PF_INIT(EnableVolumeCompression, fmifs);
setlocale(LC_ALL, locale);
GetWindowTextW(hFileSystem, wFSType, ARRAYSIZE(wFSType));
@ -768,6 +768,8 @@ static BOOL FormatDrive(DWORD DriveIndex)
}
out:
if (!r && !IS_ERROR(FormatStatus))
FormatStatus = ERROR_SEVERITY_ERROR|FAC(FACILITY_STORAGE)|SCODE_CODE(GetLastError());
safe_free(VolumeName);
safe_free(wVolumeName);
return r;

View File

@ -94,7 +94,7 @@
#define MAX_FAT32_SIZE 2.0f // Threshold above which we disable FAT32 formatting (in TB)
#define FAT32_CLUSTER_THRESHOLD 1.011f // For FAT32, cluster size changes don't occur at power of 2 boundaries but sligthly above
#define DD_BUFFER_SIZE 65536 // Minimum size of the buffer we use for DD operations
#define UBUFFER_SIZE 2048
#define UBUFFER_SIZE 4096
#define RSA_SIGNATURE_SIZE 256
#define CBN_SELCHANGE_INTERNAL (CBN_SELCHANGE + 256)
#if defined(RUFUS_TEST)

View File

@ -33,7 +33,7 @@ LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
IDD_DIALOG DIALOGEX 12, 12, 232, 326
STYLE DS_SETFONT | DS_MODALFRAME | DS_CENTER | WS_MINIMIZEBOX | WS_POPUP | WS_CAPTION | WS_SYSMENU
EXSTYLE WS_EX_ACCEPTFILES
CAPTION "Rufus 3.5.1476"
CAPTION "Rufus 3.5.1477"
FONT 9, "Segoe UI Symbol", 400, 0, 0x0
BEGIN
LTEXT "Drive Properties",IDS_DRIVE_PROPERTIES_TXT,8,6,53,12,NOT WS_GROUP
@ -394,8 +394,8 @@ END
//
VS_VERSION_INFO VERSIONINFO
FILEVERSION 3,5,1476,0
PRODUCTVERSION 3,5,1476,0
FILEVERSION 3,5,1477,0
PRODUCTVERSION 3,5,1477,0
FILEFLAGSMASK 0x3fL
#ifdef _DEBUG
FILEFLAGS 0x1L
@ -413,13 +413,13 @@ BEGIN
VALUE "Comments", "https://akeo.ie"
VALUE "CompanyName", "Akeo Consulting"
VALUE "FileDescription", "Rufus"
VALUE "FileVersion", "3.5.1476"
VALUE "FileVersion", "3.5.1477"
VALUE "InternalName", "Rufus"
VALUE "LegalCopyright", "© 2011-2019 Pete Batard (GPL v3)"
VALUE "LegalTrademarks", "https://www.gnu.org/copyleft/gpl.html"
VALUE "OriginalFilename", "rufus-3.5.exe"
VALUE "ProductName", "Rufus"
VALUE "ProductVersion", "3.5.1476"
VALUE "ProductVersion", "3.5.1477"
END
END
BLOCK "VarFileInfo"

View File

@ -1563,8 +1563,10 @@ BOOL SetUpdateCheck(void)
}
safe_free(loc);
}
if (!enable_fido)
uprintf("Note: ISO download feature will be disabled");
if (!enable_fido) {
ubprintf("Notice: The ISO download feature has been deactivated because %s", (ReadSetting32(SETTING_UPDATE_INTERVAL) <= 0) ?
"'Check for updates' is disabled in your settings." : "the remote download script can not be accessed.");
}
return TRUE;
}