1
0
Fork 0
out-of-your-element/src/matrix/file.test.js
l1s5 3ed3219bd2 Handle d2m events with empty guild/user avatars (#106)
Should fix the following trace where a `null` value was rendered into the url:

```
Error while processing a MESSAGE_CREATE Discord event:
Error: File download had failure status code 404
    at throwDownloadError (/home/ooye/out-of-your-element/src/matrix/file.js:93:13)
    at Object._actuallyUploadDiscordFileToMxc (/home/ooye/out-of-your-element/src/matrix/file.js:104:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
    at async Promise.all (index 0)
    at async kstateUploadMxc (/home/ooye/out-of-your-element/src/matrix/kstate.js:46:2)
    at async Object.kstateToState (/home/ooye/out-of-your-element/src/matrix/kstate.js:54:2)
    at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:246:19
    at async postApplyPowerLevels (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:283:21)
    at async createRoom (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:239:21)
    at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:405:19 {
  downloadURL: 'https://cdn.discordapp.com/icons/<guild_id>/null.png?size=1024'
}
```

Reviewed-on: cadence/out-of-your-element#106
2026-11-11 13:04:52 +00:00

58 lines
2.5 KiB
JavaScript

// @ts-check
const {test} = require("supertape")
const file = require("./file")
test("removeExpiryParams: url without params is unchanged", t => {
const url = "https://cdn.discordapp.com/attachments/1154455830591176734/1157034603496882267/59ce542f-bf66-4d9a-83b7-ad6d05a69bac.jpg"
const result = file._removeExpiryParams(url)
t.equal(result, url)
})
test("removeExpiryParams: params are removed", t => {
const url = "https://cdn.discordapp.com/attachments/112760669178241024/1157363960518029322/image.png?ex=651856ae&is=6517052e&hm=88353defb15cbd833e6977817e8f72f4ff28f4edfd26b8ad5f267a4f2b946e69&"
const result = file._removeExpiryParams(url)
t.equal(result, "https://cdn.discordapp.com/attachments/112760669178241024/1157363960518029322/image.png")
})
test("removeExpiryParams: rearranged params are removed", t => {
const url = "https://cdn.discordapp.com/attachments/112760669178241024/1157363960518029322/image.png?hm=88353defb15cbd833e6977817e8f72f4ff28f4edfd26b8ad5f267a4f2b946e69&ex=651856ae&is=6517052e"
const result = file._removeExpiryParams(url)
t.equal(result, "https://cdn.discordapp.com/attachments/112760669178241024/1157363960518029322/image.png")
})
test("removeExpiryParams: works on media proxy and keeps quality", t => {
const url = "https://media.discordapp.net/attachments/1160894080998461480/1548665030898094240/855064e9-bdae-487a-a497-c662bd510487.png?ex=6aa7e234&is=6aa690b4&hm=7c153efcdd1feb1d36d0bb99955a2bfe12f26abea377fed02980521766f51620&format=webp"
const result = file._removeExpiryParams(url)
t.equal(result, "https://media.discordapp.net/attachments/1160894080998461480/1548665030898094240/855064e9-bdae-487a-a497-c662bd510487.png?format=webp")
})
test("guildIcon: returns icon path", t => {
t.equal(
// @ts-ignore
file.guildIcon({id: "112760669178241024", icon: "a_f83622e09ead74f0c5c527fe241f8f8c"}),
"/icons/112760669178241024/a_f83622e09ead74f0c5c527fe241f8f8c.png?size=1024"
)
})
test("guildIcon: returns null if guild has no icon", t => {
t.equal(
// @ts-ignore
file.guildIcon({id: "112760669178241024", icon: null}),
null
)
})
test("userAvatar: returns avatar path", t => {
t.equal(
file.userAvatar({id: "113340068197859328", username: "kumaccino", avatar: "b48302623a12bc7c59a71328f72ccb39"}),
"/avatars/113340068197859328/b48302623a12bc7c59a71328f72ccb39.png?size=1024"
)
})
test("userAvatar: returns null if user has no avatar", t => {
t.equal(
file.userAvatar({id: "113340068197859328", username: "kumaccino", avatar: null}),
null
)
})