cadence/out-of-your-element
cadence/out-of-your-element
4
10
Fork 7
Code Issues 15 Pull requests 3 Releases 32 Activity

Handle d2m events with empty guild/user avatars #106

Open
l1s5 wants to merge 3 commits from l1s5/out-of-your-element:handle-empty-guild-and-user-avatars into main
pull from: l1s5/out-of-your-element:handle-empty-guild-and-user-avatars
merge into: cadence:main
Conversation 0 Commits 3 Files changed 8 +74 -6
l1s5 commented 2026-11-09 15:51:31 +00:00
Contributor
Copy link

Should fix the following trace where a null value was rendered into the url:

Error while processing a MESSAGE_CREATE Discord event:
Error: File download had failure status code 404
    at throwDownloadError (/home/ooye/out-of-your-element/src/matrix/file.js:93:13)
    at Object._actuallyUploadDiscordFileToMxc (/home/ooye/out-of-your-element/src/matrix/file.js:104:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
    at async Promise.all (index 0)
    at async kstateUploadMxc (/home/ooye/out-of-your-element/src/matrix/kstate.js:46:2)
    at async Object.kstateToState (/home/ooye/out-of-your-element/src/matrix/kstate.js:54:2)
    at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:246:19
    at async postApplyPowerLevels (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:283:21)
    at async createRoom (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:239:21)
    at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:405:19 {
  downloadURL: 'https://cdn.discordapp.com/icons/<guild_id>/null.png?size=1024'
}
Should fix the following trace where a `null` value was rendered into the url: ``` Error while processing a MESSAGE_CREATE Discord event: Error: File download had failure status code 404 at throwDownloadError (/home/ooye/out-of-your-element/src/matrix/file.js:93:13) at Object._actuallyUploadDiscordFileToMxc (/home/ooye/out-of-your-element/src/matrix/file.js:104:16) at process.processTicksAndRejections (node:internal/process/task_queues:104:5) at async Promise.all (index 0) at async kstateUploadMxc (/home/ooye/out-of-your-element/src/matrix/kstate.js:46:2) at async Object.kstateToState (/home/ooye/out-of-your-element/src/matrix/kstate.js:54:2) at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:246:19 at async postApplyPowerLevels (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:283:21) at async createRoom (/home/ooye/out-of-your-element/src/d2m/actions/create-room.js:239:21) at async /home/ooye/out-of-your-element/src/d2m/actions/create-room.js:405:19 { downloadURL: 'https://cdn.discordapp.com/icons/<guild_id>/null.png?size=1024' } ```
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u handle-empty-guild-and-user-avatars:l1s5-handle-empty-guild-and-user-avatars
git switch l1s5-handle-empty-guild-and-user-avatars

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff l1s5-handle-empty-guild-and-user-avatars
git switch l1s5-handle-empty-guild-and-user-avatars
git rebase main
git switch main
git merge --ff-only l1s5-handle-empty-guild-and-user-avatars
git switch l1s5-handle-empty-guild-and-user-avatars
git rebase main
git switch main
git merge --no-ff l1s5-handle-empty-guild-and-user-avatars
git switch main
git merge --squash l1s5-handle-empty-guild-and-user-avatars
git switch main
git merge --ff-only l1s5-handle-empty-guild-and-user-avatars
git switch main
git merge l1s5-handle-empty-guild-and-user-avatars
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backfill
properly integrated backfill feature performed on room creation

  
blocking
critical issue that blocks release of milestone

  
design needed
must prototype and discuss to find the best way forward - suggestions appreciated!

  
moderately approachable
moderate investigation, deduction, and adaptability required - or covers multiple areas of code

  
very approachable
low mental complexity, few concepts, focused scope, no investigation

  
web
No labels
backfill
blocking
design needed
moderately approachable
very approachable
web
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cadence/out-of-your-element!106
No description provided.