luna/scritcher
1
2
Fork 0
Code Issues Pull requests Releases Activity

fix use-after-free on repl

Browse source
This commit is contained in:
Luna 2020-08-18 20:41:57 -03:00
parent f61e9b013f
commit 708ef45600
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main.zig
View file

@ -60,9 +60,11 @@ pub fn doRepl(allocator: *std.mem.Allocator, args_it: anytype) !void {
var scri_existing = try allocator.alloc(u8, total_bytes); var scri_existing = try allocator.alloc(u8, total_bytes);
_ = try file_read_opt.?.read(scri_existing); _ = try file_read_opt.?.read(scri_existing);
// we can defer this because we copy the Command structs back to cmds // we can't defer this directly because we copy the
// Command pointers to the cmds list. running deinit() directly
// would cause those pointers to be freed.
var existing_cmds = try lang.parse(scri_existing); var existing_cmds = try lang.parse(scri_existing);
defer existing_cmds.deinit(); defer existing_cmds.list.deinit();
// copy the existing command list into the repl's command list // copy the existing command list into the repl's command list
for (existing_cmds.list.items) |existing_cmd| { for (existing_cmds.list.items) |existing_cmd| {