32a9bfd356
Add no_args
2022-07-10 18:51:58 -06:00
b9eaefb424
Add docs
2022-07-10 18:33:56 -06:00
9eb2946be6
Change empty args to reusable readonly instance
2022-07-10 17:51:05 -06:00
29389f1dbf
Add indexer methods for captured arguments
2022-07-10 17:38:17 -06:00
4aaed186c3
Add `with` stub modifier
2022-07-10 17:31:13 -06:00
cd177dd2ae
Implement ProcStub
2022-07-10 11:54:51 -06:00
4d5004ab4f
Add ExceptionStub
2022-07-09 22:12:24 -06:00
9c705bf888
Add MultiValueStub
2022-07-09 20:52:01 -06:00
813983de4b
Implement and test DSL for class mocks and doubles
2022-07-07 19:09:18 -06:00
77096b76e9
Allow StubbedType alongside Stubbable for allow()
2022-07-07 19:01:02 -06:00
55b2ac9f05
Fix macro for class double name
2022-07-07 19:00:22 -06:00
70391b2d31
Fix warnings from Crystal 1.5.0 regarding positional parameters
2022-07-07 18:10:21 -06:00
f7147299ab
Add stub support to class methods on mocks
2022-07-04 20:19:13 -06:00
c76ead4065
Auto stub class methods
2022-07-04 20:16:07 -06:00
fb5f44ef10
Add 'new' and 'allocate' to reserved keywords
2022-07-04 20:06:26 -06:00
22a37d38f9
Don't automatically extend StubbedType
...
Mocked module includes StubbedType, which doesn't pass along functionality to mocks.
2022-07-04 16:43:37 -06:00
989086c4fc
Add method to clear recorded calls
2022-07-04 15:35:12 -06:00
056d5892fa
Indicate class double/mock in stubbed name
2022-07-04 15:34:38 -06:00
cecd2464de
Initial code for StubbedType
2022-07-03 13:40:29 -06:00
20c9da75a8
Add missing dot after method receiver (self)
2022-06-29 22:02:27 -06:00
c8ec0ad02a
Record calls on injected mocks
2022-06-28 23:36:24 -06:00
8aed5027aa
Remove _spectator_calls method with filter
2022-06-28 23:02:46 -06:00
3589f23475
Store calls to mocks and doubles
2022-06-28 22:54:08 -06:00
c98edcec5d
Add methods for recording calls to stubs
2022-06-08 08:18:31 -06:00
cb93f4eee0
Document mock modules
2022-06-04 18:21:08 -06:00
effad28559
Better compiler error for wrong argument type passed to mock
2022-06-01 22:23:39 -06:00
3f4216a271
Allow passing default value stubs to mock initialization
2022-06-01 22:04:18 -06:00
b6083f0e09
Fix passing along mock body
2022-05-28 10:10:20 -06:00
03754321b5
Fix existing mock DSL macros
...
Initial code for mock DSL.
2022-05-28 09:18:49 -06:00
5132ce7329
Don't define method body for abstract stub method
...
Test inheriting an abstract class with mocks.
2022-05-24 19:25:22 -06:00
ddaed636c4
Remove type resolution
...
The `resolve` macro method operates in the scope of `@type`, not where the macro method was called.
This is why types could not be found within the spec.
Change `define_subclass` to `define_subtype` and accept base type keyword.
2022-05-18 20:56:04 -06:00
4f0e2f6e46
Fix clearing stubs for mocks
...
Prevent reverting initial defaults set by mock macro.
2022-05-15 16:21:05 -06:00
a39b27387c
Add delete method to clear stubs for a mock
2022-05-15 16:19:55 -06:00
c98442e0ed
Add functionality to clear stubs
2022-05-15 15:56:32 -06:00
37c6db250d
Add ValueMockRegistry
...
Support injecting mock functionality into concrete structs (value types).
2022-05-15 12:34:50 -06:00
ac03bd439b
Address Ameba issues
2022-05-15 11:06:00 -06:00
1adcf74c3f
Fix stub_type when used on a sub-type
...
previous_def should only be used if the type being stubbed matches the type stub methods are defined in.
Re-enable tests for define_subclass mocking.
2022-05-15 10:59:44 -06:00
86b49dc20e
Add mock registry fetch method
...
Solves the issue of pre-populating a mock with stubs.
2022-05-15 00:36:29 -06:00
7923eb3ad0
Fix detection of nullable return type from stubbed method
2022-05-15 00:19:03 -06:00
380d721fad
Add ReferenceMockRegistry
2022-05-14 23:31:57 -06:00
0704fd2a48
Adjust evaluation order of change matcher expressions
...
Handles reference types better and matches RSpec more closely.
2022-05-14 23:30:15 -06:00
739629ef9d
Reintroduce nil type check for stub value cast
2022-04-30 12:10:02 -06:00
9817b2948e
Add mock inject macro
...
Debugging some type resolution issues.
2022-04-30 11:40:54 -06:00
95282e7510
Combine type stubbing macros
...
Prevent redefining stubbed methods multiple times.
2022-04-30 11:40:17 -06:00
8d14be6c67
Move spectator stub retrieval to abstract getter
2022-04-28 23:04:22 -06:00
978e6c3625
Cleanup and docs
2022-04-28 22:22:07 -06:00
ad24515d58
Dumb fix for overriding stubbed methods with default in block
2022-04-28 22:11:34 -06:00
307c679609
Rework stubbing type hierarchy
...
No longer need to "inject" stubs for new methods.
No weird lookup of super/previous_def.
Handle visibility modifier of def.
2022-04-28 22:07:12 -06:00
8f5f3becb4
Some initial rework of stub macros
2022-04-16 23:37:00 -06:00
0758c19a86
Remove need for nillable argument to cast macro
...
The `class` method cannot be stubbed as this causes the cast (via `as`) to fail at compile-time.
2022-04-16 16:33:37 -06:00
23d2c014b4
Implement fallback for methods without a stub
2022-04-15 17:27:30 -06:00
6f04e0b9da
Allow uninteresting messages through mocks
...
If they are stubbed, but don't match arguments, raise an error.
2022-04-15 17:17:34 -06:00
4b21c9e6c1
Introduce _spectator_stub_for_method? utility method
2022-04-15 17:16:49 -06:00
3961662bf6
Experimental mock functionality
2022-04-10 20:01:54 -06:00
b0e27c69e8
Fix equality check
2022-04-10 15:24:45 -06:00
e8bac86017
Ensure Stubbable can have stubs defined
...
Require implementation of _spectator_define_stub.
2022-04-10 11:11:36 -06:00
0ad1ec11f3
Initial macros for defining and initializing mocks
2022-04-02 18:43:13 -06:00
d97a62e601
Rename constant DOUBLES to TYPES
...
Will use for doubles and mocks.
2022-04-02 17:58:15 -06:00
519836147e
Restructure stub modifiers
2022-04-02 10:50:27 -06:00
318e4f3707
Store location information in stub
...
Allows tracking where a stub was originally defined.
2022-04-02 10:39:59 -06:00
e61b31e47b
Add docs for allow and receive
2022-04-02 10:25:27 -06:00
17592287ad
Replace stub value method with call method
...
Pass method call information to stub.
2022-03-31 23:07:55 -06:00
2131967ba6
Workaround Crystal compiler bug
2022-03-31 22:54:03 -06:00
e05ef94ef5
Initial work on stub DSL - found bug in Crystal compiler
...
```
Module validation failed: Invalid bitcast
%4 = bitcast i32* %3 to %"(Spectator::Arguments(T, NT) | Nil)", !dbg !16
(Exception)
from /crystal/src/int.cr:541:9 in 'finish'
from /crystal/src/compiler/crystal/codegen/codegen.cr:71:7 in 'codegen'
from /crystal/src/compiler/crystal/compiler.cr:173:16 in 'compile'
from /crystal/src/compiler/crystal/command/spec.cr:98:14 in 'spec'
from /crystal/src/hash.cr:901:11 in '__crystal_main'
from /crystal/src/crystal/main.cr:115:5 in 'main'
from src/env/__libc_start_main.c:94:2 in 'libc_start_main_stage2'
Error: you've found a bug in the Crystal compiler. ...
```
I haven't been able to reproduce this in a simplified form.
Passing the `constraint` argument in NullStub#and_return to ValueStub.new triggers the bug.
Removing the `constraint` argument fixes the issue.
2022-03-31 22:49:45 -06:00
003be48591
Use responds_to? to ensure stub is cast correctly
2022-03-31 22:39:21 -06:00
9c1357da3f
Allow passing predefined stubs in as keyword args
2022-03-31 18:55:12 -06:00
c1195ef687
Simplify macro eval by returning a lazy double
2022-03-31 18:54:39 -06:00
914def05e1
Add docs
2022-03-31 18:51:28 -06:00
231323bbf1
Add return type restriction
...
This overrides the previous definition which doesn't have a restriction.
This is a workaround for the inability to infer a stub's return type.
2022-03-30 21:10:36 -06:00
f1a68fee8c
Typo
2022-03-30 20:46:53 -06:00
39f5ea34eb
Another place that needs a cast
2022-03-30 20:33:19 -06:00
613c969fbb
Match RSpec behavior
2022-03-30 20:28:36 -06:00
1327d74040
Fix handling of stubs with the same name
2022-03-26 00:13:24 -06:00
1199379833
Various fixes
2022-03-26 00:12:37 -06:00
bbaa8816b8
Weird segfault when inspecting value type is back.
...
Working around with a crude rescue block.
2022-03-25 23:54:44 -06:00
b28437ccc4
Match RSpec behavior
2022-03-25 22:32:27 -06:00
28488d308e
Don't invoke fallback if there are stubs for the method
2022-03-25 22:30:39 -06:00
fc51c1d730
More logging
2022-03-24 02:39:15 -06:00
b97a367be7
Method return type restriction takes precedence over original return type
...
Raise TypeCastError on ambiguous stub values.
2022-03-24 02:01:25 -06:00
7dd2cffa8e
Inspecting the value's class seems to work now
2022-03-22 22:13:02 -06:00
d6fcf128ba
Temporarily disable returning un-cast value
2022-03-22 22:11:34 -06:00
78dea01abe
Manual method existence check
2022-03-20 21:49:21 -06:00
0fb7be6722
Use stub instead of abstract_stub by default for stub_all
...
RSpec doesn't appear to raise unexpected message errors for standard object methods (like to_s).
There are also a lot of issues that arise when requiring a stub on common methods.
2022-03-20 15:38:26 -06:00
e209fe3eb5
Use Box for Wrapper implementation
...
This won't raise on invalid casts.
It should reduce the amount of instantiated types and methods.
2022-03-19 22:53:50 -06:00
18a03b02fe
Include reserved
2022-03-19 22:36:25 -06:00
03a031ad38
Use absolute path to RESERVED_KEYWORDS
2022-03-19 22:00:12 -06:00
b23a567ee3
Add require statements
2022-03-19 21:56:58 -06:00
04cf211f24
Move reserved keywords to a separate file
...
Add finalize as a reserved keyword.
2022-03-19 21:56:18 -06:00
04f3614ff7
Workaround issue with `value` not being found
...
For some reason the `value` method isn't found.
Event casting to TypedStub doesn't work.
2022-03-19 20:00:50 -06:00
bed84b315d
Add lazy double
2022-03-19 19:32:41 -06:00
162ad4df33
Report call and args like other error messages
2022-03-19 18:58:06 -06:00
b3fa2e3bfe
Address Ameba issues
2022-03-19 17:22:13 -06:00
2f1999b377
Fix call expansion in debug log
...
Macro expansion somehow generated an error when calling a missing method with a block.
```
syntax error in :1
Error: unknown token: 'n'
```
It seems like 'n' is from the '\n' that was previously generated:
```
Log.debug { "Got undefined method " + "baz do\n yield\nend" }
```
2022-03-19 16:32:25 -06:00
17e97cb39a
Explode method expansion
...
Somewhere along the way the block argument gets dropped.
Even though `method` is a `Def` that accepts a block, the `&block` portion is dropped.
Possible Crystal compiler bug.
2022-03-19 16:13:11 -06:00
15dd2ea6f1
Inject stubbable method that accepts a block
2022-03-19 16:09:35 -06:00
99aa8afdce
Add as_null_object method
2022-03-19 14:41:45 -06:00
70787ce2d4
Extend NullDouble from Double
2022-03-19 13:00:42 -06:00
d40040c8ee
Remove extra block body leftover from debug
...
Update docs to show example of default method implementation.
2022-03-19 12:37:46 -06:00
25f546245a
Handle injecting stubbed abstract method
2022-03-19 12:33:09 -06:00
9091b8d027
Literally inject stubs from double block
2022-03-19 12:28:00 -06:00
5a4e95e8a2
Split double macro into def_double and new_double
2022-03-19 11:41:53 -06:00
4dff018330
Pass along block only if it exists
2022-03-19 11:28:36 -06:00
a508aeb4a3
Use a shared macro to handle stub type cast
2022-03-17 02:45:50 -06:00
751ea77172
Add docs explaining how stub macros work
2022-03-17 02:18:32 -06:00
4f7a4a3453
Avoid issue with TypeCastError message
...
For some reason, attempting to get the class of the stubbed value causes a segfault.
This appears to get swallowed in some cases.
Trying to inspect the value was difficult without triggering some error.
In the failing case, the value is 42 (returned by a stubbed foo method).
The method is supposed to return a String, and this error checking should be triggered (line 119).
The value is a union, and inspecting the bytes contained in it looks like it's prefixed with the Crystal type ID for Int32.
However it looks like Crystal tries to treat it as a Bool? I'm not sure.
Very weird behavior and instead of wasting more time on it, I'm omitting the returned type from the error.
This type of casting error shouldn't be common.
This seems like a Crystal bug, but I'm having a hard time distilling the issue.
2022-03-16 22:40:24 -06:00
280f117e23
Use TypedStub instead of ValueStub
...
Test possible issues around stub returning nil
2022-03-16 21:07:20 -06:00
8e38d3b054
Add intermediate TypedStub
2022-03-16 21:05:43 -06:00
dc74a741cf
Bit of method cleanup
2022-03-15 22:55:24 -06:00
332ab1cebc
Smarter handling of stub fallback
2022-03-15 22:46:43 -06:00
01fc91e854
Add stubs for primitive methods
2022-03-14 21:53:09 -06:00
64cd921a7e
Add block arguments and yield
2022-03-12 23:50:30 -07:00
03aa282512
Don't stub primitive methods
2022-03-12 23:02:55 -07:00
291b4c75a8
Compiler error if stub defined in a method
2022-03-12 23:02:33 -07:00
94872a498d
Better string representation of method call
2022-03-12 19:26:18 -07:00
20087f1c57
Treat any tokens starting with _spectator as reserved
2022-03-12 19:17:38 -07:00
5ad29f486f
Better formatting for empty arguments
2022-03-12 17:49:07 -07:00
ca827a3c52
Initial work on null (object) double
2022-03-12 17:07:34 -07:00
f82719746d
Stubable -> Stubbable
2022-03-12 15:45:48 -07:00
7931847164
Cleanup and docs
2022-03-12 15:43:12 -07:00
151926fd25
Fix captured arguments not handling splat
2022-03-12 14:31:39 -07:00
ea46af00a6
Add method to define stubs
2022-03-12 14:31:19 -07:00
123dd0efca
Obscure parameters to avoid accidental usage
2022-03-12 13:58:20 -07:00
c8864b169e
Quick def methods should accept any args
2022-03-12 13:51:58 -07:00
f497aeb79d
Fix redefinition of method with splat argument
2022-03-12 13:15:26 -07:00
c1a14d1ad2
Add logging
2022-03-12 12:59:44 -07:00
59f966d0e0
Fix missing double name
...
Rename internal method to _spectator_stubbed_name.
This is a better name for mocks and doubles.
Improve some handling around stubbed name.
2022-03-12 12:17:27 -07:00
56f1c77a6c
Move method masking macro to Stubable
...
Rename to stub_all.
2022-03-12 11:56:54 -07:00
85cc28c499
Utility method to define a method and a stub override
2022-03-12 11:41:47 -07:00
8de457d80c
Handle previous_def and super - don't redefine method
2022-03-12 11:34:35 -07:00
554e215898
Prevent ugly "has no type" errors
2022-03-12 11:33:56 -07:00
12eeb02a8d
Move method redefinition for stub to Stubable
...
Require stub or raise UnexpectedMessage for all double methods.
Expose abstract_stub macro to require a stub.
2022-03-12 11:11:22 -07:00
9b94245bd8
Stub's type might not match return type (subclass or union)
2022-03-12 11:08:58 -07:00
d891422b3a
Don't need to recreate method by hand
2022-03-12 11:08:29 -07:00
76c1d6a096
Some rework of stubs and doubles
2022-03-12 09:39:32 -07:00
ae14a47329
Rename Response to Stub
2022-03-05 20:09:56 -07:00
ced98778a4
Document and test MethodCall
2022-03-05 16:15:42 -07:00
13f185b801
Capture and report arguments in exception message
2022-03-05 16:06:01 -07:00
d16c55984c
Fixup macros
2022-03-05 15:39:19 -07:00
2e15686d2d
Use internal arg name
2022-03-05 12:31:00 -07:00
ec57105afd
Support response constraints
...
Reduce union expansion by casting at key points.
2022-03-05 12:21:31 -07:00
8668e495ef
Placeholder mocks DSL
2022-03-05 10:41:52 -07:00
2adc867843
Initial work on response constraints
2022-03-05 10:41:39 -07:00
de7cd90d11
Add type capturing arguments
2022-03-04 17:16:45 -07:00
d7f8c2b958
Cleanup and document double
2022-03-03 23:12:35 -07:00
7e65d94cee
Match RSpec double name string
2022-03-03 22:41:18 -07:00
9594604770
Obscure and disallow double name method
2022-03-03 22:34:57 -07:00
5644d54470
Support double names
2022-03-03 22:31:40 -07:00
26deea3d20
Initial work on Double
2022-03-03 22:10:09 -07:00
8ac6546bdd
Rip out more existing mocks
2022-02-28 22:15:29 -07:00
0ea7890ece
Merge branch 'master' into mock-redesign
2022-02-28 20:39:33 -07:00
Michael Miller