class Ameba::Rule::Style::UnlessElse

Overview

A rule that disallows the use of an else block with the unless.

For example, the rule considers these valid:

unless something
  :ok
end

if something
  :one
else
  :two
end

But it considers this one invalid as it is an unless with an else:

unless something
  :one
else
  :two
end

The solution is to swap the order of the blocks, and change the unless to an if, so the previous invalid example would become this:

if something
  :two
else
  :one
end

YAML configuration example:

Style/UnlessElse:
  Enabled: true

Included Modules

Defined in:

ameba/rule/style/unless_else.cr

Constant Summary

MSG = "Favour if over unless with else"

Constructors

Class Method Summary

Instance Method Summary

Instance methods inherited from class Ameba::Rule::Base

==(other) ==, catch(source : Source) catch, excluded?(source) excluded?, group group, hash hash, name name, special? special?, test(source : Source, node : Crystal::ASTNode, *opts)
test(source : Source) test

Class methods inherited from class Ameba::Rule::Base

default_severity : Ameba::Severity default_severity

Macros inherited from class Ameba::Rule::Base

issue_for(*args, **kwargs, &block) issue_for

Macros inherited from module Ameba::Config::RuleConfig

properties(&block) properties

Constructor Detail

def self.new(ctx : YAML::ParseContext, node : YAML::Nodes::Node) #

def self.new(config = nil) #

A rule that disallows the use of an else block with the unless.

For example, the rule considers these valid:

unless something
  :ok
end

if something
  :one
else
  :two
end

But it considers this one invalid as it is an unless with an else:

unless something
  :one
else
  :two
end

The solution is to swap the order of the blocks, and change the unless to an if, so the previous invalid example would become this:

if something
  :two
else
  :one
end

YAML configuration example:

Style/UnlessElse:
  Enabled: true

[View source]

Class Method Detail

def self.parsed_doc : String | Nil #

Returns documentation for this rule, if there is any.

module Ameba
  # This is a test rule.
  # Does nothing.
  class MyRule < Ameba::Rule::Base
    def test(source)
    end
  end
end

MyRule.parsed_doc # => "This is a test rule.\nDoes nothing."

Instance Method Detail

def description : String #

def description=(description : String) #

def enabled=(enabled : Bool) #

def enabled? : Bool #

def excluded : Array(String) | Nil #

def excluded=(excluded : Array(String) | Nil) #

def severity : Ameba::Severity #

def severity=(severity : Ameba::Severity) #

def test(source, node : Crystal::Unless) #

[View source]