Commit graph

662 commits

Author SHA1 Message Date
Sijawusz Pur Rahnama
9df66e890b Do not report anonymous block arguments in Lint/UnusedArgument 2022-12-12 18:21:19 +01:00
Sijawusz Pur Rahnama
4533e52aa5
Merge pull request #317 from crystal-ameba/Sija/further-refinements 2022-12-11 13:25:07 +01:00
Sijawusz Pur Rahnama
4d9cd4d56c Fix typo 2022-12-10 00:24:04 +01:00
Sijawusz Pur Rahnama
a8fca61b22 Doc tweaks 2022-12-10 00:20:20 +01:00
Sijawusz Pur Rahnama
99c81d3630 Add spec for positive case in macro scope in Lint/LiteralsComparison rule 2022-12-09 23:53:39 +01:00
Sijawusz Pur Rahnama
2dc21a00d9 Remove treating paths as literals in AST::Util#literal? & friends 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
0bd4ed0c45 Do not treat paths as literals in Lint/LiteralAssignmentsInExpressions 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
1261f4ba6d Tweak README.md 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
db3ef762b9 Uncomment forgotten line 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
2fb453c61f Add additional spec for Lint/NotNil rule 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
07ce595ef2 Readability refactors 2022-12-08 17:47:22 +01:00
Sijawusz Pur Rahnama
784e3ac616 Use bang variants in couple of places more 2022-12-08 13:59:42 +01:00
Sijawusz Pur Rahnama
5ab4b05add Fix incorrect Reportable#add_issue(&) definition 2022-12-08 13:59:03 +01:00
Sijawusz Pur Rahnama
7d88455b7f Add corrector to the Style/IsANil rule 2022-12-08 13:58:35 +01:00
Sijawusz Pur Rahnama
071a8b7afb Consistently use CRYSTAL marker for heredocs with crystal code 2022-12-08 13:57:46 +01:00
Sijawusz Pur Rahnama
2cb8c1381f Don’t treat crystal paths as literals in Lint/LiteralsComparison 2022-12-08 13:55:29 +01:00
Sijawusz Pur Rahnama
150ba6c70f
Merge pull request #314 from crystal-ameba/Sija/style-query-bool-methods-rule 2022-12-08 13:14:19 +01:00
Sijawusz Pur Rahnama
e18da84ede Add requested spec 2022-12-08 02:16:16 +01:00
Sijawusz Pur Rahnama
cdf0405496 Refactor Style/IsANil rule to use newly added path_named? helper 2022-12-08 02:16:16 +01:00
Sijawusz Pur Rahnama
f45d6a2ef0 Fix newly found issue 2022-12-08 02:16:16 +01:00
Sijawusz Pur Rahnama
1524aad299 Add Style/QueryBoolMethods rule 2022-12-08 02:16:16 +01:00
Sijawusz Pur Rahnama
1818bcfd27
Merge pull request #315 from crystal-ameba/refresh-readme 2022-12-02 16:03:59 +01:00
Vitalii Elenhaupt
4ec829e83d
Refresh readme
- [x] update running example
- [x] add Autocorrection section to Usage
- [x] move Explain issues section from Configuration to Usage
2022-12-02 09:24:15 +02:00
Sijawusz Pur Rahnama
be65ba2a92
Merge pull request #312 from crystal-ameba/Sija/refactors-round-3 2022-11-29 19:12:16 +01:00
Sijawusz Pur Rahnama
4dd62a3ed1 Colorize also the code in single backticks 2022-11-28 11:49:26 +01:00
Sijawusz Pur Rahnama
2113e8c055 Refactor MacroReferenceFinder class a bit 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
a8f953a2b2 Compress identical method definitions 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
b79f3e6e07 Minor refactors in Style/LargeNumbers rule 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
134963ece7 Minor details 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
523a622b34 Remove leftover from some merge/rebase gone wrong 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
5502f0f8d1 Small refactor using Object#in? 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
748cab29b4 Remove redundant empty comment lines 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
629e65127d if … == nil -> unless … 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
adff510cb6 Autocasting will do the work 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
33ef9c6293 Refactor ExplainFormatter 2022-11-28 11:38:41 +01:00
Sijawusz Pur Rahnama
f9b05a309e Redundant whitespace before nl 2022-11-28 11:25:21 +01:00
Sijawusz Pur Rahnama
0f893971dc Avoid one-letter names if possible 2022-11-28 11:25:21 +01:00
Sijawusz Pur Rahnama
20935ae381
Merge pull request #311 from crystal-ameba/Sija/add-severity-color
Add `Severity#color`
2022-11-28 11:24:31 +01:00
Sijawusz Pur Rahnama
d19d3b78c4 Implement Severity#color property 2022-11-28 06:07:19 +01:00
Sijawusz Pur Rahnama
f89e7c2d3c
Merge pull request #310 from crystal-ameba/Sija/refactor-rule-default-group-severity 2022-11-24 15:34:09 +01:00
Sijawusz Pur Rahnama
6a180757f3 Use Enumerable#zip ftw 2022-11-23 16:16:34 +01:00
Sijawusz Pur Rahnama
1399aa3cdf Doc fixes 2022-11-23 16:16:03 +01:00
Sijawusz Pur Rahnama
75482a06cf Use warning as a default severity for Metrics and Performance groups 2022-11-23 15:06:24 +01:00
Sijawusz Pur Rahnama
3b7cd3723c Refactor rules’ default group severity handling 2022-11-23 15:04:47 +01:00
Sijawusz Pur Rahnama
e7a6b6b153
Merge pull request #309 from crystal-ameba/Sija/refactor-base-rule 2022-11-23 13:50:45 +01:00
Sijawusz Pur Rahnama
735ec2462a Refactor usages of \ to sth more readable if possible 2022-11-23 05:50:32 +01:00
Sijawusz Pur Rahnama
38eb5d5e50 Fix invalid crystal syntax in Lint/Syntax rule spec 2022-11-23 03:26:55 +01:00
Sijawusz Pur Rahnama
2c67fe2c3f Use tuple instead of an array 2022-11-23 03:23:42 +01:00
Sijawusz Pur Rahnama
8b43a40a65 Misc refactors 2022-11-23 03:22:27 +01:00
Sijawusz Pur Rahnama
ffd63ef028 Fix typo in AST::Branchable example 2022-11-23 03:21:49 +01:00