Commit graph

923 commits

Author SHA1 Message Date
Sijawusz Pur Rahnama
4567293add Drop type_definition? check from Scope#top_level? 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
a49faa33a9 Refactor Lint/UselessAssign spec 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
1dd531740c Fix reported ameba issue 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
1b661d633d Refactor ScopeVisitor to ignore accessor macros 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
9745637cf9 Update UselessAssign rule to report unreferenced type declarations 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
4ad151e5e0 Do not automatically consider type definitions as referenced 2023-12-28 15:43:29 +01:00
Sijawusz Pur Rahnama
c9bc01f88c
Merge pull request #439 from crystal-ameba/fix-issue-353
Make `Lint/SharedVarInFiber` rule account for `loop { ... }`
2023-12-28 15:31:43 +01:00
Sijawusz Pur Rahnama
1feb5c279b Add test spec covering the loop { … } block to Lint/SharedVarInFiber rule specs 2023-12-28 15:31:11 +01:00
Sijawusz Pur Rahnama
57898fd797 Make BranchVisitor treat loop { … } calls as branchable 2023-12-28 15:31:11 +01:00
Sijawusz Pur Rahnama
46a42ee9e8
Merge pull request #438 from crystal-ameba/add-error-as-allowed-variable-name
Add `error` to the `RescuedExceptionsVariableName#allowed_names`
2023-12-28 14:32:45 +01:00
Sijawusz Pur Rahnama
61afa5bb2b Add error to the RescuedExceptionsVariableName#allowed_names 2023-12-28 13:07:14 +01:00
Sijawusz Pur Rahnama
9bb6c9ac75
Merge pull request #436 from crystal-ameba/cleanup-properties-macro
Make `RuleConfig#properties` accept only `Call` nodes
2023-12-28 09:24:09 +01:00
Sijawusz Pur Rahnama
954345d316
Merge pull request #435 from crystal-ameba/revert-pr-394
Revert "Merge pull request #394 from stufro/388-raise-on-invalid-file…
2023-12-28 09:20:27 +01:00
Sijawusz Pur Rahnama
55f3ec53b7 Make RuleConfig#properties accept only Call nodes
Add optional named argument `as`, in order to specify the property type
2023-12-28 04:48:18 +01:00
Sijawusz Pur Rahnama
26d9bc0bd0 Revert "Merge pull request #394 from stufro/388-raise-on-invalid-file-path"
This reverts commit 18d193bd08, reversing
changes made to 7b8316f061.
2023-12-28 02:03:44 +01:00
Sijawusz Pur Rahnama
47088b10ca Add some more excluded operators to BinaryOperatorParameterName rule 2023-11-24 21:13:04 +01:00
Sijawusz Pur Rahnama
9f9d5fae32
Merge pull request #428 from crystal-ameba/revert-incorrect-excessive-allocations-condition
Revert "Fix `Performance/ExcessiveAllocations` to exclude `each` call…
2023-11-18 09:50:45 +01:00
Sijawusz Pur Rahnama
5e70ae4f8c
Merge pull request #427 from crystal-ameba/fix-gha-ci-badge-in-readme
Fix GitHub Actions CI badge in `README.md`
2023-11-18 06:34:34 +01:00
Sijawusz Pur Rahnama
82e0e53080 Revert "Fix Performance/ExcessiveAllocations to exclude each calls without a block"
This reverts commit 29e29b8e1d.
2023-11-17 19:48:41 +01:00
Sijawusz Pur Rahnama
1b8523def6
Fix GitHub Actions CI badge in README.md 2023-11-17 19:23:06 +01:00
Sijawusz Pur Rahnama
a88033c8ce
Merge pull request #426 from crystal-ameba/fix-issue-409
Do not report expanded arguments in `ShadowingOuterLocalVar` rule
2023-11-17 19:00:34 +01:00
Sijawusz Pur Rahnama
30e3816ed1 Do not report expanded arguments in ShadowingOuterLocalVar rule 2023-11-17 18:36:19 +01:00
Sijawusz Pur Rahnama
5aac63ea74
Merge pull request #425 from crystal-ameba/prepare-release-1.6.0
Prepare release 1.6.0
2023-11-17 18:14:20 +01:00
Sijawusz Pur Rahnama
10b577d23a Use square brackets for %w and %i array literals 2023-11-17 17:34:39 +01:00
Sijawusz Pur Rahnama
06dc201344 Bump supported crystal version to 1.10 2023-11-17 16:22:31 +01:00
Sijawusz Pur Rahnama
d079f4bae6 Bump version to 1.6.0 2023-11-14 12:34:44 +01:00
Sijawusz Pur Rahnama
0461fff702 Relax crystal version in shard.yml 2023-11-14 12:34:44 +01:00
Sijawusz Pur Rahnama
22e2d1de00 Cleanup my involvement status 2023-11-14 12:34:44 +01:00
Sijawusz Pur Rahnama
810a3440dd Remove shard version specifier from README.md 2023-11-14 12:34:44 +01:00
Sijawusz Pur Rahnama
f3f1f3a2ab Misc cleanups/refactors 2023-11-14 12:34:44 +01:00
Sijawusz Pur Rahnama
547fec5a94 Refactor TypeNames to report the name itself only 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
a8b8c35cc7 Fix usage of deprecated methods 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
11bf9ffcdc Remove unused include AST::Util 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
52ccf23ef9 Remove deprecated Assignment#transformed? method 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
b3f11913ed Reports also methods not ending with ? suffix in PredicateName rule 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
633ed7538e Use prefer_name_location: true in PredicateName rule 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
15d241e138 Add spec for AST::Util#{static,dynamic}_literal? 2023-11-14 11:22:17 +01:00
Sijawusz Pur Rahnama
52a3e47a3b
Merge pull request #423 from crystal-ameba/lint-not-nil-after-no-bang-reports-match-calls
Make `Lint/NotNilAfterNoBang` report calls to `#match`
2023-11-14 10:25:44 +01:00
Sijawusz Pur Rahnama
3b87aa6490
Merge pull request #424 from crystal-ameba/report-string-literals-in-ascii-identifiers-rule
Report symbol literals in `Naming/AsciiIdentifiers` rule
2023-11-14 10:24:29 +01:00
Sijawusz Pur Rahnama
018adb54be Add AsciiIdentifiers#ignore_symbols property 2023-11-14 05:22:29 +01:00
Sijawusz Pur Rahnama
be76b3682a Report string literals in AsciiIdentifiers rule 2023-11-14 05:15:38 +01:00
Sijawusz Pur Rahnama
775650c882 Add MultiAssign to NodeVisitor::NODES 2023-11-14 05:00:49 +01:00
Sijawusz Pur Rahnama
21a406e56d Make Lint/NotNilAfterNoBang report calls to #match 2023-11-14 03:50:58 +01:00
Sijawusz Pur Rahnama
0b225da9ba
Merge pull request #422 from crystal-ameba/refactor-adding-issues-with-name-location
Make it easier to add issues for nodes with name location preference
2023-11-13 19:16:14 +01:00
Sijawusz Pur Rahnama
0a2609c1b4 Add ip to the list of BlockParameterName#allowed_names 2023-11-12 11:59:06 +01:00
Sijawusz Pur Rahnama
06952fc7d3 Add op to the list of BlockParameterName#allowed_names 2023-11-12 11:36:03 +01:00
Sijawusz Pur Rahnama
f984d83b05 Use name(_end)_location helpers consistently 2023-11-12 10:24:12 +01:00
Sijawusz Pur Rahnama
98cc6fd612 Make it easier to add issues for nodes with name location preference 2023-11-12 10:23:36 +01:00
Sijawusz Pur Rahnama
6caf24ad6d
Merge pull request #421 from crystal-ameba/add-binary-operator-parameter-name-rule
Add `Naming/BinaryOperatorParameterName` rule
2023-11-12 09:56:26 +01:00
Sijawusz Pur Rahnama
e62fffae80
Merge pull request #419 from crystal-ameba/add-block-parameter-name-rule
Add `Naming/BlockParameterName` rule
2023-11-12 09:55:50 +01:00