Sijawusz Pur Rahnama
18316eaa8b
Use issue expectation helpers in Lint::LiteralInInterpolation rule spec
2022-04-04 21:16:48 +02:00
Sijawusz Pur Rahnama
7f85434c85
Use issue expectation helpers in Lint::RandZero rule spec
2022-04-04 21:14:45 +02:00
Sijawusz Pur Rahnama
c58d4cc65a
Use issue expectation helpers in Lint::Syntax rule spec
2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c89d32fcf6
Use issue expectation helpers in Lint::UselessConditionInWhen rule spec
2022-04-04 21:11:04 +02:00
Sijawusz Pur Rahnama
c8daaf4324
Use issue expectation helpers in Lint::UnneededDisableDirective rule spec
2022-04-04 21:10:54 +02:00
Sijawusz Pur Rahnama
a69fba88bd
Merge pull request #260 from crystal-ameba/fix-issue-224
2022-04-04 09:46:35 +02:00
Sijawusz Pur Rahnama
e6ad7c5d24
Fix bug in AST::Scope#in_macro? not taking account for Crystal::MacroFor
2022-04-04 02:05:13 +02:00
Sijawusz Pur Rahnama
71de3f0012
Cleanup method docs in AST::Scope
2022-04-04 02:05:13 +02:00
Sijawusz Pur Rahnama
614fcfa6a8
Skip macro scopes in ShadowingOuterLocalVar
2022-04-04 01:38:04 +02:00
Sijawusz Pur Rahnama
2e9ef7fcb2
Reword visit(node) methods comment in AST::NodeVisitor
2022-04-04 01:35:59 +02:00
Sijawusz Pur Rahnama
a38cfd1661
Refactor AST::ScopeVisitor similarly to AST::NodeVisitor
2022-04-04 01:35:32 +02:00
Sijawusz Pur Rahnama
3f7ade573a
Add ability to skip some of the nodes in AST::ScopeVisitor
2022-04-04 01:34:34 +02:00
Sijawusz Pur Rahnama
ad5d56b313
Use issue expectation helpers in ShadowingOuterLocalVar spec
2022-04-04 01:30:27 +02:00
Sijawusz Pur Rahnama
353d09df29
Rename file according to the rule name
2022-04-04 00:42:22 +02:00
Vitalii Elenhaupt
528ec460b0
Add StandWithUkraine banner
2022-03-11 09:28:44 +02:00
Sijawusz Pur Rahnama
dad72341cb
Merge pull request #258 from crystal-ameba/bump-large-numbers-min-int-digits
...
Bump default value of `LargeNumbers#int_min_digits` to 6
2022-03-08 14:48:45 +01:00
Sijawusz Pur Rahnama
1795bd2959
Bump default value of LargeNumbers#int_min_digits to 6
...
As most of the error codes are smaller than 6 digits
2022-03-08 14:42:32 +01:00
Sijawusz Pur Rahnama
ae29754de5
Merge pull request #257 from crystal-ameba/disable-style-large-numbers-rule
2022-03-08 12:20:09 +01:00
Sijawusz Pur Rahnama
9e81777e7e
Disable Style/LargeNumbers by default
2022-03-05 22:38:36 +01:00
Vitalii Elenhaupt
276b429e70
Merge pull request #256 from crystal-ameba/Sija/debug-method-calls
...
Add `Lint/DebugCalls` rule
2021-12-31 19:39:51 +02:00
Sijawusz Pur Rahnama
66ee7642cf
Add Lint/DebugCalls rule
2021-12-31 16:44:02 +01:00
fn ⌃ ⌥
f288cc3c4f
Add Style/GuardClause rule ( #254 )
2021-12-09 21:33:47 +01:00
Vitalii Elenhaupt
c7f1f94cca
Merge pull request #255 from straight-shoota/fix/unknown-token-error
...
Fix unexpected token compiler error match
2021-11-30 11:42:25 +02:00
Johannes Müller
63bafba72e
Fix unexpected token compiler error match
2021-11-29 22:04:59 +01:00
fn ⌃ ⌥
63a6c73dc0
Autocorrect various rules ( #253 )
2021-11-16 22:30:33 +01:00
Sijawusz Pur Rahnama
255d10f921
Merge pull request #252 from crystal-ameba/unreachable-code-loops
...
Do not report unreachable code after loops
2021-11-10 12:32:37 +01:00
Vitalii Elenhaupt
429f76f8b6
Do not report unreachable code after loops
...
closes #251
2021-11-10 09:16:14 +02:00
Sijawusz Pur Rahnama
d843afd962
Merge pull request #250 from FnControlOption/spec/style
...
Use `expect_issue` in `Style` specs
2021-11-09 22:35:38 +01:00
fn ⌃ ⌥
d06812ea8e
Add VariableNames test for method with multiple instance vars
2021-11-09 11:52:31 -08:00
fn ⌃ ⌥
01dfcbe76a
Add tests for AST::Util#control_exp_code
2021-11-09 11:52:31 -08:00
fn ⌃ ⌥
c9ba487373
Add custom NodeVisitor subclass for Style/VariableNames
2021-11-09 09:26:00 -08:00
fn ⌃ ⌥
bd1a1a1fd4
Shorten long line in Stye/VerboseBlock spec
2021-11-09 09:07:19 -08:00
fn ⌃ ⌥
b32b00adad
Convert remaining Style specs
2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
72a3487bb6
Autocorrect Stye/WhileTrue
2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
571969265f
Convert Style/VerboseBlock spec
2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
e93dfe9cdc
Convert Style/VariableNames spec
2021-11-08 14:24:11 -08:00
fn ⌃ ⌥
265bc51481
Convert Style/UnlessElse spec
2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
06c0887136
Convert Style/TypeNames spec
2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
e7cfe387d6
Autocorrect Stye/RedundantNext and Style/RedundantReturn
2021-11-08 14:07:35 -08:00
fn ⌃ ⌥
7b437fbd2f
Remove normalize parameter from expect_issue ( #249 )
...
* Add `normalize` parameter to `expect_correction`
* Convert Style/IsAFilter spec
* Revert "Add `normalize` parameter to `expect_correction`"
This reverts commit 4b67e4b900
2021-11-06 15:15:19 +02:00
Sijawusz Pur Rahnama
7cb0c15747
Merge pull request #248 from FnControlOption/autocorrect
...
Add autocorrect
2021-11-01 20:24:43 +01:00
fn ⌃ ⌥
78071722c4
Rename s to source
2021-11-01 08:55:48 -07:00
fn ⌃ ⌥
c2aa2fedb6
Return source from expect_issue
2021-10-31 22:44:48 -07:00
fn ⌃ ⌥
470e41cb7b
Raise error if attempting to both explain issue and autocorrect
2021-10-31 22:23:14 -07:00
fn ⌃ ⌥
a40fdee33f
Revert "Add autocorrect checks to ExplainFormatter"
...
This reverts commit 1b6fe40a3b
2021-10-31 22:12:21 -07:00
Vitalii Elenhaupt
3e1df339ae
Consistent parser options
2021-11-01 02:08:16 +02:00
fn ⌃ ⌥
61fc99e107
Inline the do_combine method
2021-10-27 11:19:15 -07:00
fn ⌃ ⌥
73e97ac42e
Avoid using iterators and throw-away heap allocations
2021-10-27 11:08:18 -07:00
fn ⌃ ⌥
b7bb282b99
Apply suggestions from code review
2021-10-27 10:08:36 -07:00
fn ⌃ ⌥
d51ef27d54
Add remove_preceding, remove_leading, remove_trailing
2021-10-26 22:22:22 -07:00
