iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Simplify implementation of Lint/EmptyExpression rule

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2022-12-21 17:54:41 +01:00
parent 8e86374d08
commit 3b79392ef2
1 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ameba/rule/lint/empty_expression.cr
View file

@ -34,19 +34,11 @@ module Ameba::Rule::Lint
description "Disallows empty expressions" description "Disallows empty expressions"
end end
MSG = "Avoid empty expression %s" MSG = "Avoid empty expressions"
MSG_EXRS = "Avoid empty expressions"
def test(source, node : Crystal::NilLiteral)
exp = node_source(node, source.lines)
return if exp.in?(nil, "nil")
issue_for node, MSG % exp
end
def test(source, node : Crystal::Expressions) def test(source, node : Crystal::Expressions)
return unless node.expressions.size == 1 && node.expressions.first.nop? return unless node.expressions.size == 1 && node.expressions.first.nop?
issue_for node, MSG_EXRS issue_for node, MSG
end end
end end
end end