From 3b79392ef2011bc7b570c17d88b792825cb7380b Mon Sep 17 00:00:00 2001 From: Sijawusz Pur Rahnama Date: Wed, 21 Dec 2022 17:54:41 +0100 Subject: [PATCH] Simplify implementation of `Lint/EmptyExpression` rule --- src/ameba/rule/lint/empty_expression.cr | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/ameba/rule/lint/empty_expression.cr b/src/ameba/rule/lint/empty_expression.cr index 8a8f89ff..9ceb2147 100644 --- a/src/ameba/rule/lint/empty_expression.cr +++ b/src/ameba/rule/lint/empty_expression.cr @@ -34,19 +34,11 @@ module Ameba::Rule::Lint description "Disallows empty expressions" end - MSG = "Avoid empty expression %s" - MSG_EXRS = "Avoid empty expressions" - - def test(source, node : Crystal::NilLiteral) - exp = node_source(node, source.lines) - return if exp.in?(nil, "nil") - - issue_for node, MSG % exp - end + MSG = "Avoid empty expressions" def test(source, node : Crystal::Expressions) return unless node.expressions.size == 1 && node.expressions.first.nop? - issue_for node, MSG_EXRS + issue_for node, MSG end end end