iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Report only wrong predicate names

Browse source
This commit is contained in:
Vitalii Elenhaupt 2017-11-23 19:58:59 +02:00
parent dceafd26e5
commit 21abce63bd
No known key found for this signature in database
GPG key ID: 7558EF3A4056C706
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
spec/ameba/rule/predicate_name_spec.cr
View file

@ -13,6 +13,9 @@ module Ameba::Rule
def picture?(x) def picture?(x)
end end
end end
def allow_this_picture?
end
) )
subject.catch(s).should be_valid subject.catch(s).should be_valid
end end

2
src/ameba/rule/predicate_name.cr
View file

@ -39,7 +39,7 @@ module Ameba::Rule
end end
def test(source, node : Crystal::Def) def test(source, node : Crystal::Def)
if node.name =~ /(is|has)_(\w+)\?/ if node.name =~ /^(is|has)_(\w+)\?/
source.error self, node.location, source.error self, node.location,
"Favour method name '#{$2}?' over '#{node.name}'" "Favour method name '#{$2}?' over '#{node.name}'"
end end