From 21abce63bde051e0238b1b6126da304cc73fa25c Mon Sep 17 00:00:00 2001 From: Vitalii Elenhaupt Date: Thu, 23 Nov 2017 19:58:59 +0200 Subject: [PATCH] Report only wrong predicate names --- spec/ameba/rule/predicate_name_spec.cr | 3 +++ src/ameba/rule/predicate_name.cr | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/spec/ameba/rule/predicate_name_spec.cr b/spec/ameba/rule/predicate_name_spec.cr index badac723..d7d1a24a 100644 --- a/spec/ameba/rule/predicate_name_spec.cr +++ b/spec/ameba/rule/predicate_name_spec.cr @@ -13,6 +13,9 @@ module Ameba::Rule def picture?(x) end end + + def allow_this_picture? + end ) subject.catch(s).should be_valid end diff --git a/src/ameba/rule/predicate_name.cr b/src/ameba/rule/predicate_name.cr index 619c3205..c0b49d37 100644 --- a/src/ameba/rule/predicate_name.cr +++ b/src/ameba/rule/predicate_name.cr @@ -39,7 +39,7 @@ module Ameba::Rule end def test(source, node : Crystal::Def) - if node.name =~ /(is|has)_(\w+)\?/ + if node.name =~ /^(is|has)_(\w+)\?/ source.error self, node.location, "Favour method name '#{$2}?' over '#{node.name}'" end