10.2.0 #50

Merged

a merged 1 commits from eatsfoobars/cutthecord:1020 into master

2020-01-12 08:57:16 +00:00

eatsfoobars commented

2020-01-11 15:52:32 +00:00

Collaborator

No description provided.

a commented

2020-01-12 08:55:20 +00:00

Owner

Heyo-

First off, I added you as a maintainer here. You can now commit directly to master.

Secondly, I'll merge this, stop CI and work on the bugs on 10.1.9 we discussed earlier:

/spoilerimg is broken again, maybe all of /ctc
spoiler and muted channel colors need fixing on customtheme (https://elixi.re/i/3coq4slu.png)

Heyo- First off, I added you as a maintainer here. You can now commit directly to master. Secondly, I'll merge this, stop CI and work on the bugs on 10.1.9 we discussed earlier: - /spoilerimg is broken again, maybe all of /ctc - spoiler and muted channel colors need fixing on customtheme (https://elixi.re/i/3coq4slu.png)

a closed this pull request

2020-01-12 08:57:16 +00:00

a commented

2020-01-12 09:48:55 +00:00

Owner

Going over spoiler and muted channel colors.

Muted channels use primary_500. This is also the color used by selected channel and "invite users" button. I'm introducing a third color here of #333333, which is lighter from #0f0f0f but is darker than the default color. Ideally I should modify the objects and point them to different colors so that texts can be lighter while buttons can be dark, but I don't want to bother with this just yet. This is an a11y issue, however, and I will get to it.

Spoilers use primary_700 through theme_chat_spoiler_bg on styles.xml. Modifying primary_700 isn't the way to go as guild bar also uses it. For this very reason, I'm changing it to primary_500 on styles.xml.

Going over spoiler and muted channel colors. Muted channels use `primary_500`. This is also the color used by selected channel and "invite users" button. I'm introducing a third color here of #333333, which is lighter from #0f0f0f but is darker than the default color. Ideally I should modify the objects and point them to different colors so that texts can be lighter while buttons can be dark, but I don't want to bother with this just yet. [This is an a11y issue](https://elixi.re/i/59kkhk3z.png), however, and I will get to it. Spoilers use `primary_700` through `theme_chat_spoiler_bg` on styles.xml. Modifying `primary_700` isn't the way to go as guild bar also uses it. For this very reason, I'm changing it to `primary_500` on styles.xml.

a commented

2020-01-12 09:59:52 +00:00

Owner

/ctc commands are good. Stuff like /upper etc work too.

It seems like something has changed though, as none of our commands work on messages sent with images.

Two guesses:

They either have a new function for messages sent with attachments.
It's the same function, but our intercept code is bad.

I'll investigate further.

/ctc commands are good. Stuff like /upper etc work too. It seems like something has changed though, as none of our commands work on messages sent with images. Two guesses: 1) They either have a new function for messages sent with attachments. 2) It's the same function, but our intercept code is bad. I'll investigate further.

This repo is archived. You cannot comment on pull requests.

No reviewers