Commit graph

11170 commits

Author SHA1 Message Date
SChernykh
a2dc960250
Fixed deadlock and crash when syncing with full dataset on Windows
It's not allowed to use WaitForSingleObject with _beginthread, because the thread closes its own handle before exiting.

So the wait function will either wait on an invalid handle, or on a different handle used by something else.

Or, if it starts waiting before the thread exits, the behavior is undefined according to MS: "If this handle is closed while the wait is still pending, the function's behavior is undefined."

In my test sync I observed threads getting stuck infinitely on WaitForSingleObject, and then rx_set_main_seedhash spamming new threads when RandomX seed changes again. Eventually the system ran out of resources, and monerod aborted with "Couldn't start RandomX seed thread" message.

This PR fixes it by using `_beginthreadex` instead and explicitly closing the handle when it's safe.
2023-04-11 15:05:34 +03:00
jeffro256
a03e5c3905
cryptonote core/protocol: don't drop peers for soft offenses
Also: txs with tx_extra which is too large will not get published to ZMQ

Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
2023-04-11 15:04:55 +03:00
wowario
e2d02caf67
update checkpoints and bump version 2023-04-11 15:03:33 +03:00
moneromooo-monero
eb2a7342b8
link against libz on non Apple/Windows
Needed by libcrypto at least
2023-03-22 11:37:20 +03:00
wowario
3341cded57
add checkpoints.dat 2023-03-19 09:22:58 +03:00
tobtoht
4578688c7b
depends: remove unused packages 2023-03-19 09:16:26 +03:00
Jeffrey Ryan
62ae03bfd3
verRctNonSemanticsSimpleCached: fix fragility 2023-03-19 09:10:08 +03:00
Francois Beutin
f8d0f857f6
device: Add ledger Stax device id to device detection 2023-03-19 09:09:47 +03:00
selsta
e44d831d7f
workflows: update dependencies to fix warnings 2023-03-19 09:09:19 +03:00
moneromooo-monero
12ad6748a4
util: make GMT timestamps explicit for clarity
For privacy reasons, time functions use GMT, to avoid logs leaking
timezones. It'd make more sense to use localtime for wallet output
(which are not logged by default), but that adds inconsistencies
which can also be confusing. So add a Z suffix for now to make it
clear these are not local time.
2023-03-18 11:31:52 +03:00
tobtoht
b1710a4fcc
cryptonote_basic: remove unused struct 2023-03-18 11:27:41 +03:00
moneromooo-monero
65764dce8c
p2p: do not log to global when re-blocking a subnet 2023-03-18 11:24:51 +03:00
moneromooo-monero
c8b4cdffdc
p2p: avoid spam blocking ipv4 addresses in a blocked subnet 2023-03-18 11:24:40 +03:00
wowario
b878068e84
update checkpoints and bump version 2023-03-18 11:15:51 +03:00
wowario
215fccb71c
Fix Offline transaction signing 2023-03-17 04:05:55 +03:00
wowario
0a6465ebcc
revert estimate_fee requires new bp+ parameter 2023-03-16 20:32:17 +03:00
wowario
2482733bc7
support old ass BPs 2023-03-04 00:07:42 +03:00
wowario
a8eb29dbe7
revert sanity check 2023-02-27 13:16:08 +03:00
wowario
e78ef8a3a7
faster sync, drop unconfirmed mempool txs after 1 day 2023-02-26 10:58:40 +03:00
wowario
7e6109d02a
silent compiler warnings 2023-02-25 12:11:18 +03:00
wowario
6fe4ceaf09
wallet seed message spacing 2023-02-25 12:11:18 +03:00
wowario
bcdc98a8b0
remove warning reusing keys 2023-02-25 12:11:17 +03:00
wowario
6c97d87295
remove warning about background mining 2023-02-25 12:11:17 +03:00
wowario
d10480a12f
add clear screen command 2023-02-25 12:11:17 +03:00
wowario
79a4abdc18
show wallet info 2023-02-25 12:11:17 +03:00
hinto-janaiyo
864255d783
simplewallet/wallet2: set option - show-detailed-prompt 2023-02-25 12:11:16 +03:00
moneromooo-monero
4ac984bc56
blockchain_prune: faster
on my anecdotal SSD, goes from about 9 hours to 1h20.
2023-02-25 12:11:16 +03:00
Offshore Monero
9be78e756b
Turn readline off on OpenBSD because it is broken 2023-02-25 12:11:16 +03:00
moneromooo-monero
bd011fcae9
rpc: do not misidentify coinbase txes as pruned 2023-02-25 12:11:16 +03:00
moneromooo-monero
399593a320
heed NO_COLOR environment variable 2023-02-25 12:11:15 +03:00
plowsof
d0bacf4f77
win-service: enable auto startup 2023-02-25 12:11:15 +03:00
Jeffrey Ryan
f25a655cff
readline_buffer: disable bracketed paste escape sequences 2023-02-25 12:11:15 +03:00
selsta
ddfefa5dd5
daemonizer: don't uninstall windows service on exit 2023-02-25 12:11:14 +03:00
moneromooo-monero
22e71f9449
simplewallet: print fully qualified filename for new wallets
from time to time, some people don't realize their wallets get
created in their current working directory
2023-02-24 15:50:41 +03:00
wowario
15b7b9d05b
wownero chan 2023-02-24 15:44:52 +03:00
wowario
5022273035
update README.md 2023-02-24 11:37:05 +03:00
wowario
c36f266520
update checkpoints 2023-02-24 11:36:48 +03:00
wowario
e9e18bdf56
set fork height 2023-02-24 11:34:13 +03:00
wowario
83b5e5ada1
from v20, limit tx extra size 2023-02-24 11:34:00 +03:00
tevador
2944371b43
Add a size limit for tx_extra in tx pool 2023-02-24 11:33:45 +03:00
wowario
b06dd76792
use rx_set_miner_thread after RX_BLOCK_VERSION 2023-02-24 11:33:30 +03:00
wowario
8695701058
Debug level No incoming connections 2023-02-24 11:33:17 +03:00
wowario
99682fb3a7
update checkpoints 2023-02-24 11:32:24 +03:00
thotbot
e84d5ba8c0
Misc. network related
- Add interface for bytes sent/received
- Allow wallet refresh while daemon is not synchronized
- emit success boolean for refreshed()
- don't call refreshThreadFunc (we don't need it)
- lower rpc timeout from 3m30s (?!) to 10 seconds
2023-02-24 11:31:19 +03:00
thotbot
200586592c
Import transaction 2023-02-24 11:31:04 +03:00
dsc
b2d752b298
estimate_fee requires new bp+ parameter 2023-02-24 11:30:50 +03:00
thotbot
3d25c90053
Skip unneeded blocks in fast refresh 2023-02-24 11:30:35 +03:00
thotbot
fd18ad1e60
subaddressIndex() 2023-02-24 11:30:22 +03:00
thotbot
d2a170f6e4
Print wallet cache 2023-02-24 11:30:10 +03:00
thotbot
60ff2f668e
Misc. wallet API and wallet2 changes 2023-02-24 11:29:55 +03:00