d0s3t3ch/wownero
1
0
Fork 0
mirror of https://git.wownero.com/wownero/wownero.git synced 2024-08-15 01:03:23 +00:00
Code Issues Projects Releases Wiki Activity

UB: virtual method in destructor of WalletImpl v0.17

Browse source
This commit is contained in:
mj-xmr 2021-08-16 08:58:15 +02:00 • committed by wowario
parent fe41c18266
commit 8e9a4aed7a
No known key found for this signature in database
GPG key ID: 24DCBE762DE9C111
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/wallet/api/wallet.cpp
View file

@ -447,7 +447,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again
pauseRefresh();
WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities
// Stop refresh thread