From 8e9a4aed7ac5c959506c0106e57d1f8ce92900e1 Mon Sep 17 00:00:00 2001 From: mj-xmr Date: Mon, 16 Aug 2021 08:58:15 +0200 Subject: [PATCH] UB: virtual method in destructor of WalletImpl v0.17 --- src/wallet/api/wallet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp index a0f147b96..ef21f7a81 100644 --- a/src/wallet/api/wallet.cpp +++ b/src/wallet/api/wallet.cpp @@ -447,7 +447,7 @@ WalletImpl::~WalletImpl() LOG_PRINT_L1(__FUNCTION__); m_wallet->callback(NULL); // Pause refresh thread - prevents refresh from starting again - pauseRefresh(); + WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor. // Close wallet - stores cache and stops ongoing refresh operation close(false); // do not store wallet as part of the closing activities // Stop refresh thread