Fix and test broken room bridge check #104

Merged

cadence merged 2 commits from l1s5/out-of-your-element:fix-room-bridged-sql-query into main

2026-11-04 22:26:37 +00:00

l1s5 commented

2026-11-02 09:18:04 +00:00

Contributor

Stumbled upon a small bug, see commit message for details :)

l1s5 added 1 commit

2026-11-02 09:18:04 +00:00

Fix and test broken room bridge check 94a96dd51a

A `m.room.member` handler check intended to determine whether a room was
bridged or not ended up checking the truthiness of the db query itself,
resulting in a tautology.

This commit fixes the check and moves it over to matrix/utils so it may
be reused and tested in isolation.

cadence commented

2026-11-03 09:02:56 +00:00

Owner

Nice find. I think it makes more sense to fix this one inline rather than creating a new function for it.

Can you add a database migration to remove any cached users that are not currently in a room? I can do it for you if you don't want to.

Nice find. I think it makes more sense to fix this one inline rather than creating a new function for it. Can you add a database migration to remove any cached users that are not currently in a room? I can do it for you if you don't want to.

l1s5 added 1 commit

2026-11-03 22:12:59 +00:00

fixup! Fix and test broken room bridge check 75ead0edad