cadence/breezewiki
2
4
Fork 4
Code Issues Pull requests 1 Releases Wiki Activity

Fix error on a redirect page with no link #16

Manually merged
cadence merged 1 commit from blankie/breezewiki:no-redirect-link into main 2024-01-09 04:13:10 +00:00
Conversation 2 Commits 1 Files changed 2 +12 -6
blankie commented 2023-12-31 10:58:09 +00:00
Contributor
Copy link

I haven't tested the offline component, but hopefully it doesn't break

https://lists.sr.ht/~cadence/breezewiki-discuss/%3CCY2G0E3G55N3.ANW2QREUS5SO%40nixnetmail.com%3E

I haven't tested the offline component, but hopefully it doesn't break https://lists.sr.ht/~cadence/breezewiki-discuss/%3CCY2G0E3G55N3.ANW2QREUS5SO%40nixnetmail.com%3E
blankie added 1 commit 2023-12-31 10:58:10 +00:00 
https://lists.sr.ht/~cadence/breezewiki-discuss/%3CCY2G0E3G55N3.ANW2QREUS5SO%40nixnetmail.com%3E
blankie force-pushed no-redirect-link from 8c914a22c3 to 86c99906c6 2023-12-31 11:02:30 +00:00 Compare
cadence commented 2023-12-31 11:50:59 +00:00
Owner
Copy link

Ah I see, so the problem is when the redirect's destination is a redlink. Makes sense.

Offline mode is already OK because the target page is present in action=query&prop=links.

I won't be able to test code or review PRs until at least Jan 5th.

Ah I see, so the problem is when the redirect's destination is a redlink. Makes sense. Offline mode is already OK because the target page is present in action=query&prop=links. I won't be able to test code or review PRs until at least Jan 5th.
cadence manually merged commit 3942350468 into main 2024-01-09 04:13:10 +00:00
cadence commented 2024-01-09 04:14:19 +00:00
Owner
Copy link

Just gotten around to testing this and it works great, thanks for the contribution! Offline mode automatically follows the redirect and shows a 404, which is what it is, so nothing broken there.

Just gotten around to testing this and it works great, thanks for the contribution! Offline mode automatically follows the redirect and shows a 404, which is what it is, so nothing broken there.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cadence/breezewiki#16
No description provided.
Delete branch "blankie/breezewiki:no-redirect-link"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?