cadence
/
breezewiki
3
4
Fork 4
Code Issues Pull Requests 3 Releases Wiki Activity

Add better support for tabs #15

Open
blankie wants to merge 5 commits from blankie/breezewiki:tabs into main
pull from: blankie/breezewiki:tabs
merge into: cadence:main
Conversation 1 Commits 5 Files Changed 3 +79 -4
blankie commented 2023-05-29 16:43:40 +00:00
Contributor
Copy Link

Some pages break without actual tab support, such as https://breezewiki.com/ben10/wiki/Ultimatrix_(Original)#Modes

This change aims to work with old browsers (such as Firefox for Android 68) and browsers with Javascript disabled (by showing all tab contents and hiding the tab bar, i.e. how tabs work before this change).

Some pages break without actual tab support, such as https://breezewiki.com/ben10/wiki/Ultimatrix_(Original)#Modes This change aims to work with old browsers (such as Firefox for Android 68) and browsers with Javascript disabled (by showing all tab contents and hiding the tab bar, i.e. how tabs work before this change).
blankie added 1 commit 2023-05-29 16:43:41 +00:00
3f94452de6
Add better support for tabs 
Some pages break without actual tab support, such as
https://breezewiki.com/ben10/wiki/Ultimatrix_(Original)#Modes

This change aims to work with old browsers (such as Firefox for Android 68)
and browsers with Javascript disabled (by showing all tab contents and hiding
the tab bar, i.e. how tabs work before this change).
blankie commented 2023-05-29 16:48:33 +00:00
Author
Contributor
Copy Link

(Some notes while I was implementing this)

With this change, if you open /ben10/wiki/Ultimatrix_(Original)#Modes and click on Scan, the content seems to be truncated. Adding the class page-content to <body> fixed it, but it looks like it causes more trouble than what it's worth.
Nested tabs are a thing apparently: https://antifandom.com/community/wiki/Help:Tabber#Example
There are apparently left/right arrows inside the tab bar, but I haven't seen them yet: https://antifandom.com/community/wiki/Help:Tabber#Styling

(Some notes while I was implementing this) With this change, if you open /ben10/wiki/Ultimatrix_(Original)#Modes and click on Scan, the content seems to be truncated. Adding the class `page-content` to `<body>` fixed it, [but it looks like it causes more trouble than what it's worth](https://lists.sr.ht/~cadence/breezewiki-discuss/%3CCSL9IPTI0WTT.1BDPLVUYIMEYT%40archer%3E#%3C97f0b8e3-71d9-46d2-bc0b-67114eb0c78f@disroot.org%3E). Nested tabs are a thing apparently: https://antifandom.com/community/wiki/Help:Tabber#Example There are apparently left/right arrows inside the tab bar, but I haven't seen them yet: https://antifandom.com/community/wiki/Help:Tabber#Styling
blankie added 1 commit 2023-05-30 06:50:16 +00:00
blankie added 1 commit 2023-05-30 07:03:52 +00:00
blankie force-pushed tabs from 9ff6d3b9a8 to f5399524b1 2023-11-06 09:15:29 +00:00 Compare
blankie added 1 commit 2023-11-06 09:31:47 +00:00
blankie added 1 commit 2023-11-13 03:36:09 +00:00
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b blankie-tabs main
git pull tabs

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff blankie-tabs
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cadence/breezewiki#15
No description provided.
Delete Branch "blankie/breezewiki:tabs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?