cadence/breezewiki
2
4
Fork 4
Code Issues Pull requests 1 Releases Wiki Activity

optimizations #13

Closed
artemis wants to merge 2 commits from artemis/breezewiki:optimizations into main
pull from: artemis/breezewiki:optimizations
merge into: cadence:main
Conversation 1 Commits 2 Files changed 2 +15 -7
artemis commented 2023-03-25 01:50:57 +00:00
First-time contributor
Copy link

couple string handling optimizations i found with the flamegraph stuff. it helps a lil bit. minecraft/Block goes from 650 to 350ms on my machine.

couple string handling optimizations i found with the flamegraph stuff. it helps a lil bit. minecraft/Block goes from 650 to 350ms on my machine.
artemis added 2 commits 2023-03-25 01:50:58 +00:00
cadence commented 2023-04-01 11:19:08 +00:00
Owner
Copy link

Really helpful, thanks!! I manually merged this into 3f1946a and f5529ed.

I also added my own commit ba6c5be which optimises the pre-processing regular expression a fair bit, but that step is still very slow, and it would be better for me to fix it in the html-parsing library since I've already vendored that. Will have to do this at some point...

Really helpful, thanks!! I manually merged this into 3f1946a and f5529ed. I also added my own commit ba6c5be which optimises the pre-processing regular expression a fair bit, but that step is still very slow, and it would be better for me to fix it in the html-parsing library since I've already vendored that. Will have to do this at some point...
cadence closed this pull request 2023-04-01 11:19:08 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cadence/breezewiki#13
No description provided.
Delete branch "artemis/breezewiki:optimizations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?