cadence/Carbon
3
9
Fork 1
Code Issues 14 Pull requests 1 Releases Wiki Activity

WIP: Some visual improvements for login #20

Draft
jboi wants to merge 9 commits from fix/login-improvements into princess
pull from: fix/login-improvements
merge into: cadence:princess
Conversation 1 Commits 9 Files changed 7 +3 -3
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d8343f5976 - Show all commits

Change homserver-question into a class

Prev Next
Bad 2020-11-01 17:35:10 +01:00
commit d8343f5976

2
src/js/login.js
View file

@ -54,7 +54,7 @@ class Homeserver extends ElemJS {
constructor() {
super(q("#homeserver"));
this.tippy = tippy.default(q("#homeserver-question"), {
this.tippy = tippy.default(q(".homeserver-question"), {
content: q("#homeserver-popup-template").innerHTML,
allowHTML: true,
interactive: true,

2
src/login.pug
View file

@ -24,7 +24,7 @@ html
.form-input-container
.homeserver-label
label(for="homeserver") Homeserver
span#homeserver-question (What's this?)
span.homeserver-question (What's this?)
input(type="text" name="homeserver" placeholder="matrix.org")#homeserver
#feedback

2
src/sass/login.sass
View file

@ -44,7 +44,7 @@
.form-error
color: red
#homeserver-question
.homeserver-question
font-size: 0.6em
padding-left: 0.2em
cadence commented 2020-11-01 09:10:43 +00:00
Outdated
Copy link

Please create a class .homeserver-question and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.

Please create a class `.homeserver-question` and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.
cadence commented 2020-11-01 09:09:40 +00:00
Outdated
Copy link

12px please, it doesn't need to be tiny.

12px please, it doesn't need to be _tiny._
bad commented 2020-11-01 15:43:34 +00:00
Outdated
Copy link

Won't using px cause scaling issues on smaller screens?

Won't using px cause scaling issues on smaller screens?
cadence commented 2020-11-01 23:02:35 +00:00
Outdated
Copy link

No, px will not cause issues.

No, px will not cause issues.