WIP: Some visual improvements for login #20

Draft
jboi wants to merge 9 commits from fix/login-improvements into princess
jboi commented 2 years ago
Collaborator

(blocked until #19 is merged)

  • Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred

  • Makes homeserver not mandatory to input

  • Some dependency improvements to elements

  • Added regex file that contains common regex elements

(blocked until #19 is merged) - Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred - Makes homeserver not mandatory to input - Some dependency improvements to elements - Added regex file that contains common regex elements
jboi added a new dependency 2 years ago
cadence requested changes 2 years ago
cadence left a comment
Owner

Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone.

The "what's this" label isn't keyboard accessible, it would be good if it was. tabindex=0 doesn't help.

Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone. The "what's this" label isn't keyboard accessible, it would be good if it was. `tabindex=0` doesn't help.
| It's usually the website where you registered.
p
| Need help finding a homeserver?
a(href='#') Click here
Owner

This link doesn't go anywhere. I assume the site is yet to be created?

Can we make the link look like a link, aka underlined and blue?

This link doesn't go anywhere. I assume the site is yet to be created? Can we make the link look like a link, aka underlined and blue?
bad commented 2 years ago
Collaborator

Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org.

https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative

Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org. https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative
.form-error
color: red
Owner

This needs to be a lighter red for better contrast. Try #ff6561 I guess?

This needs to be a lighter red for better contrast. Try #ff6561 I guess?
bad commented 2 years ago
Collaborator

I think we should get a color scheme first and then replace it with css(or sass) variables

#27

I think we should get a color scheme first and then replace it with css(or sass) variables https://gitdab.com/cadence/Carbon/issues/27
.form-error
color: red
#homeserver-question
Owner

Please create a class .homeserver-question and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.

Please create a class `.homeserver-question` and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.
color: red
#homeserver-question
font-size: 0.6em
Owner

12px please, it doesn't need to be tiny.

12px please, it doesn't need to be _tiny._
bad commented 2 years ago
Collaborator

Won't using px cause scaling issues on smaller screens?

Won't using px cause scaling issues on smaller screens?
Owner

No, px will not cause issues.

No, px will not cause issues.
#homeserver-question
font-size: 0.6em
padding-left: 0.2em
Owner

This does nothing, remove it.

This does nothing, remove it.
bad marked this conversation as resolved
.tippy-box[data-theme~="carbon"]
background-color: c.$milder
border: 2px solid c.$divider
.tippy-svg-arrow
Owner

style: indentation 2 spaces, line break above selectors.

style: indentation 2 spaces, line break above selectors.
bad marked this conversation as resolved

Reviewers

cadence requested changes 2 years ago
All checks were successful
continuous-integration/drone/pr Build is passing
continuous-integration/drone/push Build is passing
This pull request has changes conflicting with the target branch.
package.json
Sign in to join this conversation.
Loading…
There is no content yet.