WIP: Some visual improvements for login
#20
Draft
jboi
wants to merge 9 commits from fix/login-improvements into princess
No reviewers
No Label
bug
discussion
duplicate
enhancement
help wanted
invalid
question
suggestion
tracker
ui/ux
wontfix
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Depends on
#19 Bundle with browserify
cadence/Carbon
Reference: cadence/Carbon#20
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'fix/login-improvements'
Deleting a branch is permanent. It CANNOT be undone. Continue?
(blocked until #19 is merged)
Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred
Makes homeserver not mandatory to input
Some dependency improvements to elements
Added regex file that contains common regex elements
Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone.
The "what's this" label isn't keyboard accessible, it would be good if it was.
tabindex=0doesn't help.@ -32,0 +38,4 @@| It's usually the website where you registered.p| Need help finding a homeserver?a(href='#') Click hereThis link doesn't go anywhere. I assume the site is yet to be created?
Can we make the link look like a link, aka underlined and blue?
Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org.
https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative
@ -43,6 +44,40 @@.form-errorcolor: redThis needs to be a lighter red for better contrast. Try #ff6561 I guess?
I think we should get a color scheme first and then replace it with css(or sass) variables
#27
@ -43,6 +44,40 @@.form-errorcolor: red#homeserver-questionPlease create a class
.homeserver-questionand target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.@ -44,2 +45,4 @@color: red#homeserver-questionfont-size: 0.6em12px please, it doesn't need to be tiny.
Won't using px cause scaling issues on smaller screens?
No, px will not cause issues.
@ -45,1 +46,4 @@#homeserver-questionfont-size: 0.6empadding-left: 0.2emThis does nothing, remove it.
@ -0,0 +5,4 @@.tippy-box[data-theme~="carbon"]background-color: c.$milderborder: 2px solid c.$divider.tippy-svg-arrowstyle: indentation 2 spaces, line break above selectors.
Reviewers
Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.