cadence
/
Carbon
3
9
Fork 1
Code Issues 14 Pull Requests 1 Releases Wiki Activity

WIP: Some visual improvements for login #20

Draft
jboi wants to merge 9 commits from fix/login-improvements into princess
pull from: fix/login-improvements
merge into: cadence:princess
Conversation 0 Commits 9 Files Changed 7 +191 -33
jboi commented 2020-10-23 16:07:28 +00:00
Collaborator
Copy Link

(blocked until #19 is merged)

  • Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred

  • Makes homeserver not mandatory to input

  • Some dependency improvements to elements

  • Added regex file that contains common regex elements

(blocked until #19 is merged) - Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred - Makes homeserver not mandatory to input - Some dependency improvements to elements - Added regex file that contains common regex elements
jboi added a new dependency 2020-10-23 16:07:36 +00:00
#19 Bundle with browserify
cadence requested changes 2020-11-01 09:16:07 +00:00
cadence left a comment
Owner
Copy Link

Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone.

The "what's this" label isn't keyboard accessible, it would be good if it was. tabindex=0 doesn't help.

Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone. The "what's this" label isn't keyboard accessible, it would be good if it was. `tabindex=0` doesn't help.
src/login.pug
@ -32,0 +38,4 @@
| It's usually the website where you registered.
p
| Need help finding a homeserver?
a(href='#') Click here
cadence commented 2020-11-01 09:05:42 +00:00
Owner
Copy Link

This link doesn't go anywhere. I assume the site is yet to be created?

Can we make the link look like a link, aka underlined and blue?

This link doesn't go anywhere. I assume the site is yet to be created? Can we make the link look like a link, aka underlined and blue?
bad commented 2020-11-01 15:45:54 +00:00
Collaborator
Copy Link

Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org.

https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative

Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org. https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative
src/sass/login.sass
@ -43,6 +44,40 @@
.form-error
color: red
cadence commented 2020-11-01 09:08:28 +00:00
Owner
Copy Link

This needs to be a lighter red for better contrast. Try #ff6561 I guess?

This needs to be a lighter red for better contrast. Try #ff6561 I guess?
bad commented 2020-11-01 15:42:47 +00:00
Collaborator
Copy Link

I think we should get a color scheme first and then replace it with css(or sass) variables

#27

I think we should get a color scheme first and then replace it with css(or sass) variables https://gitdab.com/cadence/Carbon/issues/27
src/sass/login.sass Outdated
@ -43,6 +44,40 @@
.form-error
color: red
#homeserver-question
cadence commented 2020-11-01 09:10:43 +00:00
Owner
Copy Link

Please create a class .homeserver-question and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.

Please create a class `.homeserver-question` and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.
src/sass/login.sass Outdated
@ -44,2 +45,4 @@
color: red
#homeserver-question
font-size: 0.6em
cadence commented 2020-11-01 09:09:40 +00:00
Owner
Copy Link

12px please, it doesn't need to be tiny.

12px please, it doesn't need to be _tiny._
bad commented 2020-11-01 15:43:34 +00:00
Collaborator
Copy Link

Won't using px cause scaling issues on smaller screens?

Won't using px cause scaling issues on smaller screens?
cadence commented 2020-11-01 23:02:35 +00:00
Owner
Copy Link

No, px will not cause issues.

No, px will not cause issues.
src/sass/login.sass
@ -45,1 +46,4 @@
#homeserver-question
font-size: 0.6em
padding-left: 0.2em
cadence commented 2020-11-01 09:09:50 +00:00
Owner
Copy Link

This does nothing, remove it.

This does nothing, remove it.
bad marked this conversation as resolved
src/sass/tippy.sass Outdated
@ -0,0 +5,4 @@
.tippy-box[data-theme~="carbon"]
background-color: c.$milder
border: 2px solid c.$divider
.tippy-svg-arrow
cadence commented 2020-11-01 09:11:19 +00:00
Owner
Copy Link

style: indentation 2 spaces, line break above selectors.

style: indentation 2 spaces, line break above selectors.
bad marked this conversation as resolved
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
This pull request has changes conflicting with the target branch.
  • package.json
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fix/login-improvements princess
git pull origin fix/login-improvements

Step 2:

Merge the changes and update on Forgejo.
git checkout princess
git merge --no-ff fix/login-improvements
git push origin princess
Sign in to join this conversation.
Reviewers
No reviewers
cadence
Labels
Clear labels   
bug

Something is not working

  
discussion

   
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
suggestion

A suggestion to be considered or rejected

  
tracker

   
ui/ux

Issues pertaining to User Experience

  
wontfix

This won't be fixed

No Label
bug
discussion
duplicate
enhancement
help wanted
invalid
question
suggestion
tracker
ui/ux
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#19 Bundle with browserify
cadence/Carbon
Reference: cadence/Carbon#20
No description provided.
Delete Branch "fix/login-improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?