WIP: Some visual improvements for login
Draftjboi wants to merge 9 commits from
Reference in New Issue
There is no content yet.
Delete Branch 'fix/login-improvements'
Deleting a branch is permanent. It CANNOT be undone. Continue?
(blocked until #19 is merged)
Makes serverpart from username fall into "placeholder" part of homeserver, subtle indication its inferred
Makes homeserver not mandatory to input
Some dependency improvements to elements
Added regex file that contains common regex elements
Just tried this out and I like it a lot actually! There's a couple of nitpicks before we can show it to everyone.
The "what's this" label isn't keyboard accessible, it would be good if it was.
@ -32,0 +38,4 @@
| It's usually the website where you registered.
| Need help finding a homeserver?
a(href='#') Click here
This link doesn't go anywhere. I assume the site is yet to be created?
Can we make the link look like a link, aka underlined and blue?
Yeah right now we are waiting if someone in the matrix community will make a server picker similiar to joinmastodon.org.
https://github.com/daydream-mx/keymaker looks interesting but if it doesn't get finished we might have to make our own alternative
@ -43,6 +44,40 @@
This needs to be a lighter red for better contrast. Try #ff6561 I guess?
I think we should get a color scheme first and then replace it with css(or sass) variables
@ -43,6 +44,40 @@
Please create a class
.homeserver-questionand target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.
@ -44,2 +45,4 @@
12px please, it doesn't need to be tiny.
Won't using px cause scaling issues on smaller screens?
No, px will not cause issues.
@ -45,1 +46,4 @@
This does nothing, remove it.
@ -0,0 +5,4 @@
border: 2px solid c.$divider
style: indentation 2 spaces, line break above selectors.
Step 1:From your project repository, check out a new branch and test the changes.
Step 2:Merge the changes and update on Forgejo.