cadence/Carbon
3
9
Fork 1
Code Issues 14 Pull requests 1 Releases Wiki Activity

WIP: Some visual improvements for login #20

Draft
jboi wants to merge 9 commits from fix/login-improvements into princess
pull from: fix/login-improvements
merge into: cadence:princess
Conversation 1 Commits 9 Files changed 7 +1 -2
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 48c6ae7efb - Show all commits

3
src/sass/login.sass
View file

@ -45,8 +45,7 @@
color: red color: red
cadence commented 2020-11-01 09:08:28 +00:00
Copy link

This needs to be a lighter red for better contrast. Try #ff6561 I guess?

This needs to be a lighter red for better contrast. Try #ff6561 I guess?
bad commented 2020-11-01 15:42:47 +00:00
Copy link

I think we should get a color scheme first and then replace it with css(or sass) variables

#27

I think we should get a color scheme first and then replace it with css(or sass) variables https://gitdab.com/cadence/Carbon/issues/27
.homeserver-question .homeserver-question
cadence commented 2020-11-01 09:10:43 +00:00
Outdated
Copy link

Please create a class .homeserver-question and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.

Please create a class `.homeserver-question` and target that instead. Using IDs in CSS sounds fine but quickly turns into hell. I know this from experience.
font-size: 0.6em font-size: 0.8em
cadence commented 2020-11-01 09:09:40 +00:00
Outdated
Copy link

12px please, it doesn't need to be tiny.

12px please, it doesn't need to be _tiny._
bad commented 2020-11-01 15:43:34 +00:00
Outdated
Copy link

Won't using px cause scaling issues on smaller screens?

Won't using px cause scaling issues on smaller screens?
cadence commented 2020-11-01 23:02:35 +00:00
Outdated
Copy link

No, px will not cause issues.

No, px will not cause issues.
padding-left: 0.2em
bad marked this conversation as resolved
cadence commented 2020-11-01 09:09:50 +00:00
Copy link

This does nothing, remove it.

This does nothing, remove it.
.homeserver-label .homeserver-label
display: flex display: flex