Code highlighting fixes:
continuous-integration/drone/push Build is passing Details

- Fix pre+code element moving
- Do not highlight if pre is already formatted
This commit is contained in:
Cadence Ember 2020-11-14 17:27:13 +13:00
parent c0c7278279
commit 0960ca7e97
Signed by: cadence
GPG Key ID: BC1C2C61CF521B17
1 changed files with 11 additions and 6 deletions

View File

@ -5,14 +5,16 @@ class HighlightedCode extends ElemJS {
constructor(element) {
super(element)
if (this.element.tagName === "PRE" && this.element.children.length === 1 && this.element.children[0].tagName === "CODE") {
// we shouldn't nest code inside a pre. put the text in the pre directly.
// we shouldn't nest <code> inside <pre>. put the text in <pre> directly.
const code = this.element.children[0]
this.clearChildren()
for (const child of code.childNodes) {
this.element.appendChild(child)
while (code.firstChild) {
this.element.appendChild(code.firstChild)
}
}
if (this.element.textContent.length > 80) {
let shouldHighlight = (
// if there are child _elements_, it's already formatted, we shouldn't mess that up
this.element.children.length === 0
/*
no need to highlight very short code blocks:
- content inside might not be code, some users still use code blocks
@ -23,6 +25,9 @@ class HighlightedCode extends ElemJS {
feel free to change the threshold number
*/
&& this.element.textContent.length > 80
)
if (shouldHighlight) {
lazyLoad("https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@10/build/highlight.min.js").then(hljs => hljs.highlightBlock(this.element))
}
}