anas-elgarhy
/
bfy
1
0
Fork 0
Code Issues 6 Pull Requests 2 Packages Projects Releases 2 Wiki Activity

Translated the README.md to Arabic Language #13

Merged
idrismusa4 merged 7 commits from master into master 2022-10-15 20:16:34 +00:00
Conversation 7 Commits 7 Files Changed 2 +202 -1
idrismusa4 commented 2022-10-15 14:32:37 +00:00 (Migrated from github.com)
Copy Link

Translate README.md file to Arabic as state in issue #3

Translate README.md file to Arabic as state in issue #3
anas-elgarhy (Migrated from github.com) requested changes 2022-10-15 14:59:06 +00:00
anas-elgarhy (Migrated from github.com) left a comment
Copy Link

The translation is not accurate and needs some correction, also why did you replace the original file?
You are supposed to create a new file containing the translation
README-ar.md

The translation is not accurate and needs some correction, also why did you replace the original file? You are supposed to create a new file containing the translation `README-ar.md`
README.md
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:40:42 +00:00
Copy Link

The correct translation for Features is مميزات or المميزات not سمات

The correct translation for `Features` is `مميزات` or `المميزات` not `سمات`
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:44:37 +00:00
Copy Link

the correct translation for a description is:
مترجم بسيط وREPL للغة brainfu*k مكتوب باللغة Rust

the correct translation for a description is: مترجم بسيط وREPL للغة brainfu*k مكتوب باللغة Rust
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:45:04 +00:00
Copy Link

Or
مكتوب بواسطة لغة Rust

Or مكتوب بواسطة لغة Rust
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:50:18 +00:00
Copy Link

Good translation, but we don't need to قمsentence

Good translation, but we don't need to `قم`sentence
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:50:52 +00:00
Copy Link

we don't need to قمsentence

we don't need to `قم`sentence
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:54:22 +00:00
Copy Link

the correct translation for from is من not تثبيت

the correct translation for `from` is `من` not `تثبيت`
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:55:12 +00:00
Copy Link

You can translate it to تثبيت من also

You can translate it to `تثبيت من` also
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 15:08:04 +00:00
README.md
idrismusa4 (Migrated from github.com) commented 2022-10-15 15:08:04 +00:00
Copy Link

Okay will do

Okay will do
idrismusa4 commented 2022-10-15 15:09:55 +00:00 (Migrated from github.com)
Copy Link

Okay I will create a new file and add a new pull request if it's okay?

Okay I will create a new file and add a new pull request if it's okay?
anas-elgarhy commented 2022-10-15 15:14:32 +00:00 (Migrated from github.com)
Copy Link

You don't need to create a new PR, leave this open and any new commit will reach it

You don't need to create a new PR, leave this open and any new commit will reach it
anas-elgarhy commented 2022-10-15 15:22:15 +00:00 (Migrated from github.com)
Copy Link

You can rename the file you modified to README-ar.md and do not forget to return the original file

You can rename the file you modified to README-ar.md and do not forget to return the original file
anas-elgarhy commented 2022-10-15 15:26:39 +00:00 (Migrated from github.com)
Copy Link

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17
idrismusa4 commented 2022-10-15 15:28:38 +00:00 (Migrated from github.com)
Copy Link

You can rename the file you modified to README-ar.md and do not forget to return the original file

Okay will do

> You can rename the file you modified to README-ar.md and do not forget to return the original file Okay will do
idrismusa4 commented 2022-10-15 15:29:02 +00:00 (Migrated from github.com)
Copy Link

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17

Okay thanks for the assistance

> And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17 Okay thanks for the assistance
😆 1
anas-elgarhy (Migrated from github.com) requested changes 2022-10-15 19:39:52 +00:00
anas-elgarhy (Migrated from github.com) left a comment
Copy Link

Good contribute I like it 💙, But there is only one small adjustment you have to make

Good contribute I like it 💙, But there is only one small adjustment you have to make
README-ar.md
anas-elgarhy (Migrated from github.com) commented 2022-10-15 19:37:07 +00:00
Copy Link

Please don't translate the language name

Please don't translate the language name
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 19:45:28 +00:00
README-ar.md
idrismusa4 (Migrated from github.com) commented 2022-10-15 19:45:27 +00:00
Copy Link

Do you mean the link title?

Do you mean the link title?
anas-elgarhy (Migrated from github.com) reviewed 2022-10-15 19:56:28 +00:00
README-ar.md
anas-elgarhy (Migrated from github.com) commented 2022-10-15 19:56:27 +00:00
Copy Link

yep

yep
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 20:09:34 +00:00
README-ar.md
idrismusa4 (Migrated from github.com) commented 2022-10-15 20:09:34 +00:00
Copy Link

Okay will do!

Okay will do!
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 20:10:17 +00:00
idrismusa4 (Migrated from github.com) left a comment
Copy Link

Please @anas-elgarhy can you review this and give feedback for any changes if there's any?

Please @anas-elgarhy can you review this and give feedback for any changes if there's any?
anas-elgarhy (Migrated from github.com) approved these changes 2022-10-15 20:16:17 +00:00
anas-elgarhy (Migrated from github.com) left a comment
Copy Link

Nice
شكرا 💙

Nice شكرا 💙
idrismusa4 commented 2022-10-15 20:17:12 +00:00 (Migrated from github.com)
Copy Link

Thanks so much @anas-elgarhy

Thanks so much @anas-elgarhy
❤️ 1
Sign in to join this conversation.
Reviewers
No reviewers
anas-elgarhy
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
hacktoberfest

   
hacktoberfest-accepted

   
help wanted

Extra attention is needed

  
interpreter-bug🐛

   
invalid

This doesn't seem right

  
major version

Automatically create a new major version tag after PR is merged

  
merge when passing

Merge the PR automatically once all status checks have passed

  
minor version

Automatically create a new minor version tag after PR is merged

  
patch version

Automatically create a new patch version tag after PR is merged

  
question

Further information is requested

  
size/XS

   
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
hacktoberfest
hacktoberfest-accepted
help wanted
interpreter-bug🐛
invalid
major version
merge when passing
minor version
patch version
question
size/XS
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: anas-elgarhy/bfy#13
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?