Translated the README.md to Arabic Language #13

Merged
idrismusa4 merged 7 commits from master into master 2022-10-15 20:16:34 +00:00
idrismusa4 commented 2022-10-15 14:32:37 +00:00 (Migrated from github.com)

Translate README.md file to Arabic as state in issue #3

Translate README.md file to Arabic as state in issue #3
anas-elgarhy (Migrated from github.com) requested changes 2022-10-15 14:59:06 +00:00
anas-elgarhy (Migrated from github.com) left a comment

The translation is not accurate and needs some correction, also why did you replace the original file?
You are supposed to create a new file containing the translation
README-ar.md

The translation is not accurate and needs some correction, also why did you replace the original file? You are supposed to create a new file containing the translation `README-ar.md`
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:40:42 +00:00

The correct translation for Features is مميزات or المميزات not سمات

The correct translation for `Features` is `مميزات` or `المميزات` not `سمات`
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:44:37 +00:00

the correct translation for a description is:
مترجم بسيط وREPL للغة brainfu*k مكتوب باللغة Rust

the correct translation for a description is: مترجم بسيط وREPL للغة brainfu*k مكتوب باللغة Rust
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:45:04 +00:00

Or
مكتوب بواسطة لغة Rust

Or مكتوب بواسطة لغة Rust
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:50:18 +00:00

Good translation, but we don't need to قمsentence

Good translation, but we don't need to `قم`sentence
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:50:52 +00:00

we don't need to قمsentence

we don't need to `قم`sentence
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:54:22 +00:00

the correct translation for from is من not تثبيت

the correct translation for `from` is `من` not `تثبيت`
anas-elgarhy (Migrated from github.com) commented 2022-10-15 14:55:12 +00:00

You can translate it to تثبيت من also

You can translate it to `تثبيت من` also
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 15:08:04 +00:00
idrismusa4 (Migrated from github.com) commented 2022-10-15 15:08:04 +00:00

Okay will do

Okay will do
idrismusa4 commented 2022-10-15 15:09:55 +00:00 (Migrated from github.com)

Okay I will create a new file and add a new pull request if it's okay?

Okay I will create a new file and add a new pull request if it's okay?
anas-elgarhy commented 2022-10-15 15:14:32 +00:00 (Migrated from github.com)

You don't need to create a new PR, leave this open and any new commit will reach it

You don't need to create a new PR, leave this open and any new commit will reach it
anas-elgarhy commented 2022-10-15 15:22:15 +00:00 (Migrated from github.com)

You can rename the file you modified to README-ar.md and do not forget to return the original file

You can rename the file you modified to README-ar.md and do not forget to return the original file
anas-elgarhy commented 2022-10-15 15:26:39 +00:00 (Migrated from github.com)

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17
idrismusa4 commented 2022-10-15 15:28:38 +00:00 (Migrated from github.com)

You can rename the file you modified to README-ar.md and do not forget to return the original file

Okay will do

> You can rename the file you modified to README-ar.md and do not forget to return the original file Okay will do
idrismusa4 commented 2022-10-15 15:29:02 +00:00 (Migrated from github.com)

And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17

Okay thanks for the assistance

> And don't forget to put a link to the translation version in the original README file, you can imitate this: https://github.com/anas-elgarhy/cmus-rpc-rs/pull/17 Okay thanks for the assistance
anas-elgarhy (Migrated from github.com) requested changes 2022-10-15 19:39:52 +00:00
anas-elgarhy (Migrated from github.com) left a comment

Good contribute I like it 💙, But there is only one small adjustment you have to make

Good contribute I like it 💙, But there is only one small adjustment you have to make
anas-elgarhy (Migrated from github.com) commented 2022-10-15 19:37:07 +00:00

Please don't translate the language name

Please don't translate the language name
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 19:45:28 +00:00
idrismusa4 (Migrated from github.com) commented 2022-10-15 19:45:27 +00:00

Do you mean the link title?

Do you mean the link title?
anas-elgarhy (Migrated from github.com) reviewed 2022-10-15 19:56:28 +00:00
anas-elgarhy (Migrated from github.com) commented 2022-10-15 19:56:27 +00:00

yep

yep
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 20:09:34 +00:00
idrismusa4 (Migrated from github.com) commented 2022-10-15 20:09:34 +00:00

Okay will do!

Okay will do!
idrismusa4 (Migrated from github.com) reviewed 2022-10-15 20:10:17 +00:00
idrismusa4 (Migrated from github.com) left a comment

Please @anas-elgarhy can you review this and give feedback for any changes if there's any?

Please @anas-elgarhy can you review this and give feedback for any changes if there's any?
anas-elgarhy (Migrated from github.com) approved these changes 2022-10-15 20:16:17 +00:00
anas-elgarhy (Migrated from github.com) left a comment

Nice
شكرا 💙

Nice شكرا 💙
idrismusa4 commented 2022-10-15 20:17:12 +00:00 (Migrated from github.com)

Thanks so much @anas-elgarhy

Thanks so much @anas-elgarhy
Sign in to join this conversation.
No description provided.