- https://ave.zone
-
I am one of the two people behind lavatech, hello.
- Joined on
2018-11-12
Woah, always nice to see more contributors. Thank you!
Let me check this out real quick, then I'll merge it.
That is indeed annoying, I created a fork first, committed there, then created PR.
/ctc commands are good. Stuff like /upper etc work too.
It seems like something has changed though, as none of our commands work on messages sent with images.
Two guesses:
- They either have a new function for messages sent with attachments.
- It's the same function, but our intercept code is bad.
I'll investigate further.
Going over spoiler and muted channel colors.
Muted channels use primary_500. This is also the color used by selected channel and "invite users" button. I'm introducing a third color here of #333333, which is lighter from #0f0f0f but is darker than the default color. Ideally I should modify the objects and point them to different colors so that texts can be lighter while buttons can be dark, but I don't want to bother with this just yet. This is an a11y issue, however, and I will get to it.
Spoilers use primary_700 through theme_chat_spoiler_bg on styles.xml. Modifying primary_700 isn't the way to go as guild bar also uses it. For this very reason, I'm changing it to primary_500 on styles.xml.
Heyo-
First off, I added you as a maintainer here. You can now commit directly to master.
Secondly, I'll merge this, stop CI and work on the bugs on 10.1.9 we discussed earlier:
- /spoilerimg is broken again, maybe all of /ctc
- spoiler and muted channel colors need fixing on customtheme (https://elixi.re/i/3coq4slu.png)
