Remove some unnecessary skin checks

This commit is contained in:
Camotoy 2021-11-29 10:40:27 -05:00
parent 2ae34b69af
commit eb7d71017c
No known key found for this signature in database
GPG key ID: 7EEFB66FE798081F
2 changed files with 22 additions and 28 deletions

View file

@ -112,9 +112,7 @@ public class FakeHeadProvider {
try { try {
SkinProvider.SkinData mergedSkinData = MERGED_SKINS_LOADING_CACHE.get(new FakeHeadEntry(texturesProperty, fakeHeadSkinUrl, entity)); SkinProvider.SkinData mergedSkinData = MERGED_SKINS_LOADING_CACHE.get(new FakeHeadEntry(texturesProperty, fakeHeadSkinUrl, entity));
if (session.getUpstream().isInitialized()) {
sendSkinPacket(session, entity, mergedSkinData); sendSkinPacket(session, entity, mergedSkinData);
}
} catch (ExecutionException e) { } catch (ExecutionException e) {
GeyserImpl.getInstance().getLogger().error("Couldn't merge skin of " + entity.getUsername() + " with head skin url " + fakeHeadSkinUrl, e); GeyserImpl.getInstance().getLogger().error("Couldn't merge skin of " + entity.getUsername() + " with head skin url " + fakeHeadSkinUrl, e);
} }
@ -136,9 +134,7 @@ public class FakeHeadProvider {
return; return;
} }
if (session.getUpstream().isInitialized()) {
sendSkinPacket(session, entity, skinData); sendSkinPacket(session, entity, skinData);
}
}); });
} }

View file

@ -133,7 +133,6 @@ public class SkinManager {
SkinProvider.Cape cape = skinData.cape(); SkinProvider.Cape cape = skinData.cape();
SkinProvider.SkinGeometry geometry = skinData.geometry(); SkinProvider.SkinGeometry geometry = skinData.geometry();
if (session.getUpstream().isInitialized()) {
PlayerListPacket.Entry updatedEntry = buildEntryManually( PlayerListPacket.Entry updatedEntry = buildEntryManually(
session, session,
entity.getUuid(), entity.getUuid(),
@ -159,7 +158,6 @@ public class SkinManager {
session.sendUpstreamPacket(playerRemovePacket); session.sendUpstreamPacket(playerRemovePacket);
} }
} }
}
if (skinAndCapeConsumer != null) { if (skinAndCapeConsumer != null) {
skinAndCapeConsumer.accept(new SkinProvider.SkinAndCape(skinData.skin(), skinData.cape())); skinAndCapeConsumer.accept(new SkinProvider.SkinAndCape(skinData.skin(), skinData.cape()));