GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

Use an immutable view in GeyserDefineCommandsEvent

Browse source 
Methods to properly register/unregister commands are provided in the command manager
This commit is contained in:
RednedEpic 2022-07-02 12:30:23 -05:00
parent 36c49a7256
commit b5eb27693f
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
api/geyser/src/main/java/org/geysermc/geyser/api/event/lifecycle/GeyserDefineCommandsEvent.java
View file

@ -36,8 +36,7 @@ import java.util.Map;
* Called when commands are defined within Geyser. * Called when commands are defined within Geyser.
* *
* @param commandManager the command manager * @param commandManager the command manager
* @param commands a mutable list of the currently * @param commands an immutable view of the default commands
* registered default commands
*/ */
public record GeyserDefineCommandsEvent(@NonNull CommandManager commandManager, @NonNull Map<String, Command> commands) implements Event { public record GeyserDefineCommandsEvent(@NonNull CommandManager commandManager, @NonNull Map<String, Command> commands) implements Event {
} }

2
core/src/main/java/org/geysermc/geyser/command/GeyserCommandManager.java
View file

@ -70,7 +70,7 @@ public abstract class GeyserCommandManager extends CommandManager {
register(new StopCommand(geyser, "stop", "geyser.commands.stop.desc", "geyser.command.stop")); register(new StopCommand(geyser, "stop", "geyser.commands.stop.desc", "geyser.command.stop"));
} }
this.geyser.eventBus().fire(new GeyserDefineCommandsEvent(this, this.commands)); this.geyser.eventBus().fire(new GeyserDefineCommandsEvent(this, this.commands()));
} }
@Override @Override