Handle blank permissions properly

bootstrap/bungeecord/src/main/java/org/geysermc/geyser/platform/bungeecord/command/BungeeCommandSource.java

@@ -97,7 +97,8 @@ public class BungeeCommandSource implements GeyserCommandSource {
 
     @Override
     public boolean hasPermission(String permission) {
-        return handle.hasPermission(permission);
+        // Handle blank permissions ourselves, as cloud only handles empty ones
+        return permission.isBlank() || handle.hasPermission(permission);
     }
 
     @Override

bootstrap/mod/neoforge/src/main/java/org/geysermc/geyser/platform/neoforge/GeyserNeoForgeCommandRegistry.java

@@ -93,7 +93,8 @@ public class GeyserNeoForgeCommandRegistry extends CommandRegistry {
         // We can't realistically ensure that every permission is registered (calls by API users), so we catch this.
         // This works for our calls, but not for cloud's internal usage. For that case, see above.
         try {
-            return super.hasPermission(source, permission);
+            // Handle blank permissions ourselves, as cloud only handles empty ones
+            return permission.isBlank() || super.hasPermission(source, permission);
         } catch (PermissionNotRegisteredException e) {
             return false;
         }

bootstrap/spigot/src/main/java/org/geysermc/geyser/platform/spigot/command/SpigotCommandSource.java

@@ -36,7 +36,6 @@ import org.geysermc.geyser.command.GeyserCommandSource;
 import org.geysermc.geyser.platform.spigot.PaperAdventure;
 import org.geysermc.geyser.text.GeyserLocale;
 
-import java.util.Optional;
 import java.util.UUID;
 
 public class SpigotCommandSource implements GeyserCommandSource {

bootstrap/velocity/src/main/java/org/geysermc/geyser/platform/velocity/command/VelocityCommandSource.java

@@ -93,7 +93,8 @@ public class VelocityCommandSource implements GeyserCommandSource {
 
     @Override
     public boolean hasPermission(String permission) {
-        return handle.hasPermission(permission);
+        // Handle blank permissions ourselves, as cloud only handles empty ones
+        return permission.isBlank() || handle.hasPermission(permission);
     }
 
     @Override

core/src/main/java/org/geysermc/geyser/command/CommandRegistry.java

@@ -266,7 +266,8 @@ public class CommandRegistry implements EventRegistrar {
     }
 
     public boolean hasPermission(GeyserCommandSource source, String permission) {
-        return cloud.hasPermission(source, permission);
+        // Handle blank permissions ourselves, as cloud only handles empty ones
+        return permission.isBlank() || cloud.hasPermission(source, permission);
     }
 
     /**

core/src/main/java/org/geysermc/geyser/command/GeyserCommand.java

@@ -91,6 +91,7 @@ public abstract class GeyserCommand implements org.geysermc.geyser.api.command.C
             throw new IllegalArgumentException("Command cannot be null or blank!");
         }
         if (permission.isBlank()) {
+            permission = ""; // Cloud treats empty permissions as available to everyone, but not blank permissions.
             permissionDefault = null;
         }
 

core/src/main/java/org/geysermc/geyser/command/standalone/StandaloneCloudCommandManager.java

@@ -103,11 +103,15 @@ public class StandaloneCloudCommandManager extends CommandManager<GeyserCommandS
         // GeyserLogger#hasPermission always returns true
         // GeyserSession#hasPermission delegates to this method,
         // which is why this method doesn't just call GeyserCommandSource#hasPermission
-
         if (sender.isConsole()) {
             return true;
         }
 
+        // Handle blank permissions ourselves, as cloud only handles empty ones
+        if (permission.isBlank()) {
+            return true;
+        }
+
         for (PermissionChecker checker : permissionCheckers) {
             Boolean result = checker.hasPermission(sender, permission).toBoolean();
             if (result != null) {