GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

Fix rare StackOverflowError in DeclareCommands

Browse source 
This behavior is exhibited with the NanoLimbo software version 1.2.2.
This commit is contained in:
Camotoy 2021-08-13 23:56:44 -04:00
parent 1afa22d5cf
commit 9f4c2ce5fc
No known key found for this signature in database
GPG key ID: 7EEFB66FE798081F
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
connector/src/main/java/org/geysermc/connector/network/translators/java/JavaDeclareCommandsTranslator.java
View file

@ -295,6 +295,11 @@ public class JavaDeclareCommandsTranslator extends PacketTranslator<ServerDeclar
for (int paramID : paramNode.getChildIndices()) { for (int paramID : paramNode.getChildIndices()) {
CommandNode paramNode = allNodes[paramID]; CommandNode paramNode = allNodes[paramID];
if (paramNode == this.paramNode) {
// Fixes a StackOverflowError when an argument has itself as a child
continue;
}
if (paramNode.getParser() == null) { if (paramNode.getParser() == null) {
boolean foundCompatible = false; boolean foundCompatible = false;
for (int i = 0; i < children.size(); i++) { for (int i = 0; i < children.size(); i++) {