GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

Match Advancement Packet Behavior Towards Java (#4684)

Browse source 
* Send advancement packet regardless of current tab

* Send advancement close packet when single-advancement form closed
This commit is contained in:
gecko10000 2024-05-22 02:26:32 -07:00 committed by GitHub
parent 96bfda2ed3
commit 6f4c29c834
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
core/src/main/java/org/geysermc/geyser/session/cache/AdvancementsCache.java vendored
View file

@ -91,11 +91,9 @@ public class AdvancementsCache {
builder.validResultHandler((response) -> { builder.validResultHandler((response) -> {
String id = rootAdvancementIds.get(response.clickedButtonId()); String id = rootAdvancementIds.get(response.clickedButtonId());
if (!id.equals("")) { if (!id.equals("")) {
if (!id.equals(currentAdvancementCategoryId)) { // Send a packet indicating that we are opening this particular advancement window
// Send a packet indicating that we are opening this particular advancement window ServerboundSeenAdvancementsPacket packet = new ServerboundSeenAdvancementsPacket(id);
ServerboundSeenAdvancementsPacket packet = new ServerboundSeenAdvancementsPacket(id); session.sendDownstreamGamePacket(packet);
session.sendDownstreamGamePacket(packet);
}
currentAdvancementCategoryId = id; currentAdvancementCategoryId = id;
buildAndShowListForm(); buildAndShowListForm();
} }
@ -188,6 +186,10 @@ public class AdvancementsCache {
.content(content) .content(content)
.button(GeyserLocale.getPlayerLocaleString("gui.back", language)) .button(GeyserLocale.getPlayerLocaleString("gui.back", language))
.validResultHandler((response) -> buildAndShowListForm()) .validResultHandler((response) -> buildAndShowListForm())
.closedResultHandler(() -> {
// Indicate that we have closed the current advancement tab
session.sendDownstreamGamePacket(new ServerboundSeenAdvancementsPacket());
})
); );
} }