GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

null safety on auth/handshake errors

Browse source
This commit is contained in:
Blue Kelp 2019-08-02 13:54:40 -07:00
parent f62aa390d2
commit 5f93b5bec4
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
connector/src/main/java/org/geysermc/connector/network/session/GeyserSession.java
View file

@ -158,8 +158,12 @@ public class GeyserSession implements PlayerSession, Player {
public void disconnect(String reason) { public void disconnect(String reason) {
if (!closed) { if (!closed) {
loggedIn = false; loggedIn = false;
downstream.getSession().disconnect(reason); if (downstream != null && downstream.getSession() != null) {
upstream.disconnect(reason); downstream.getSession().disconnect(reason);
}
if (upstream != null) {
upstream.disconnect(reason);
}
} }
} }

9
connector/src/main/java/org/geysermc/connector/utils/LoginEncryptionUtils.java
View file

@ -150,10 +150,13 @@ public class LoginEncryptionUtils {
return false; return false;
CustomFormResponse response = (CustomFormResponse) customFormWindow.getResponse(); CustomFormResponse response = (CustomFormResponse) customFormWindow.getResponse();
String email = response.getInputResponses().get(2);
String password = response.getInputResponses().get(3);
session.authenticate(email, password); if (response != null) {
String email = response.getInputResponses().get(2);
String password = response.getInputResponses().get(3);
session.authenticate(email, password);
}
// TODO should we clear the window cache in all cases or just if not already logged in? // TODO should we clear the window cache in all cases or just if not already logged in?
// Clear windows so authentication data isn't accidentally cached // Clear windows so authentication data isn't accidentally cached