GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

Fix message translation regression

Browse source
This commit is contained in:
Camotoy 2023-04-26 15:33:36 -04:00
parent 321f98c75d
commit 545087fba4
No known key found for this signature in database
GPG key ID: 7EEFB66FE798081F
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
core/src/main/java/org/geysermc/geyser/text/MinecraftTranslationRegistry.java
View file

@ -53,12 +53,14 @@ public class MinecraftTranslationRegistry extends TranslatableComponentRenderer<
// Get the locale string
String localeString = MinecraftLocale.getLocaleStringIfPresent(key, locale);
if (localeString == null) {
if (fallback == null) {
// No fallback and no match for string; nothing will be translated/inserted
return null;
if (fallback != null) {
// Fallback strings will still have their params inserted
localeString = fallback;
} else {
// The original translation will be translated
// Can be tested with 1.19.4: {"translate":"%s","with":[{"text":"weeeeeee"}]}
localeString = key;
}
// Fallback strings will still have their params inserted
localeString = fallback;
}
// Replace the `%s` with numbered inserts `{0}`