GeyserMC/Geyser
GeyserMC/Geyser
4
4
Fork 3
mirror of https://github.com/GeyserMC/Geyser.git synced 2024-08-14 23:57:35 +00:00
Code Issues 103 Projects Releases Wiki Activity

create less array/set instances

Browse source
This commit is contained in:
Konicai 2024-06-02 16:50:48 -05:00
parent 814761bfd2
commit 49167b041f
2 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
api/src/main/java/org/geysermc/geyser/api/bedrock/camera/CameraData.java
View file

@ -172,9 +172,9 @@ public interface CameraData {
boolean isHudElementHidden(@NonNull GuiElement element);
/**
* Returns the currently hidden {@link GuiElement}.
* Returns the currently hidden {@link GuiElement}s.
*
* @return an immutable set of all currently hidden {@link GuiElement}s
* @return an unmodifiable view of all currently hidden {@link GuiElement}s
*/
@NonNull Set<GuiElement> hiddenElements();
}
}

12
core/src/main/java/org/geysermc/geyser/impl/camera/GeyserCameraData.java
View file

@ -58,6 +58,8 @@ import java.util.Set;
import java.util.UUID;
public class GeyserCameraData implements CameraData {
private static final HudElement[] HUD_ELEMENT_VALUES = HudElement.values();
private static final Set<HudElement> ALL_HUD_ELEMENTS = Set.of(HUD_ELEMENT_VALUES);
/**
* An array of elements to hide when the player is in spectator mode.
@ -264,7 +266,7 @@ public class GeyserCameraData implements CameraData {
for (GuiElement element : elements) {
this.hiddenHudElements.add(element);
elementSet.add(HudElement.values()[element.ordinal()]);
elementSet.add(HUD_ELEMENT_VALUES[element.ordinal()]);
}
session.sendUpstreamPacket(packet);
@ -279,11 +281,11 @@ public class GeyserCameraData implements CameraData {
if (elements.length != 0) {
for (GuiElement element : elements) {
this.hiddenHudElements.remove(element);
elementSet.add(HudElement.values()[element.ordinal()]);
elementSet.add(HUD_ELEMENT_VALUES[element.ordinal()]);
}
} else {
this.hiddenHudElements.clear();
elementSet.addAll(Set.of(HudElement.values()));
elementSet.addAll(ALL_HUD_ELEMENTS);
}
session.sendUpstreamPacket(packet);
@ -297,7 +299,7 @@ public class GeyserCameraData implements CameraData {
@Override
public @NonNull Set<GuiElement> hiddenElements() {
return Set.copyOf(this.hiddenHudElements);
return Collections.unmodifiableSet(hiddenHudElements);
}
/**
@ -317,4 +319,4 @@ public class GeyserCameraData implements CameraData {
}
}
}
}
}